chore: remove more lints from ignores

Author: o-santi

src/auth/pyproject.toml

@@ -66,8 +66,7 @@ select = [
   "I",
   "ANN2"
 ]
-ignore = ["F403", "E712", "E501", "E402", "E722", "E731", "UP006", "UP035"]
-# isort.required-imports = ["from __future__ import annotations"]
+ignore = ["F403", "E501", "E402", "UP006", "UP035"]
 
 [tool.ruff.lint.pyupgrade]
 # Preserve types, even if a file imports `from __future__ import annotations`.

src/auth/src/supabase_auth/_async/gotrue_client.py

@@ -1274,7 +1274,7 @@ def __del__(self) -> None:
             try:
                 # Try to cancel the timer
                 self._refresh_token_timer.cancel()
-            except:
+            except Exception:
                 # Ignore errors if event loop is closed or selector is not registered
                 pass
             finally:

src/auth/src/supabase_auth/_sync/gotrue_client.py

@@ -1264,7 +1264,7 @@ def __del__(self) -> None:
             try:
                 # Try to cancel the timer
                 self._refresh_token_timer.cancel()
-            except:
+            except Exception:
                 # Ignore errors if event loop is closed or selector is not registered
                 pass
             finally:

src/auth/src/supabase_auth/helpers.py

@@ -13,7 +13,7 @@
 from urllib.parse import urlparse
 
 from httpx import HTTPStatusError, Response
-from pydantic import BaseModel, TypeAdapter
+from pydantic import BaseModel, TypeAdapter, ValidationError
 
 from .constants import (
     API_VERSION_HEADER_NAME,
@@ -80,7 +80,7 @@ def parse_auth_response(response: Response) -> AuthResponse:
     try:
         session = model_validate(Session, response.content)
         user = session.user
-    except:
+    except ValidationError:
         session = None
         user = model_validate(User, response.content)
     return AuthResponse(user=user, session=session)
@@ -125,9 +125,10 @@ def parse_jwks(response: Response) -> JWKSet:
 
 def get_error_message(error: Any) -> str:
     props = ["msg", "message", "error_description", "error"]
-    filter = lambda prop: (
-        prop in error if isinstance(error, dict) else hasattr(error, prop)
-    )
+
+    def filter(prop) -> bool:
+        return prop in error if isinstance(error, dict) else hasattr(error, prop)
+
     return next((error[prop] for prop in props if filter(prop)), str(error))
 
 

src/auth/tests/_async/test_gotrue.py

@@ -516,7 +516,7 @@ async def test_sign_in_with_otp() -> None:
         assert args[0] == "POST"
         assert args[1] == "otp"
         assert kwargs["body"]["email"] == email
-        assert kwargs["body"]["create_user"] == True
+        assert kwargs["body"]["create_user"]
         assert kwargs["body"]["data"] == {"custom": "data"}
         assert (
             kwargs["body"]["gotrue_meta_security"]["captcha_token"]
@@ -552,7 +552,7 @@ async def test_sign_in_with_otp() -> None:
         assert args[0] == "POST"
         assert args[1] == "otp"
         assert kwargs["body"]["phone"] == phone
-        assert kwargs["body"]["create_user"] == True
+        assert kwargs["body"]["create_user"]
         assert kwargs["body"]["data"] == {"custom": "data"}
         assert kwargs["body"]["channel"] == "whatsapp"
         assert (

src/auth/tests/_sync/test_gotrue.py

@@ -514,7 +514,7 @@ def test_sign_in_with_otp() -> None:
         assert args[0] == "POST"
         assert args[1] == "otp"
         assert kwargs["body"]["email"] == email
-        assert kwargs["body"]["create_user"] == True
+        assert kwargs["body"]["create_user"]
         assert kwargs["body"]["data"] == {"custom": "data"}
         assert (
             kwargs["body"]["gotrue_meta_security"]["captcha_token"]
@@ -550,7 +550,7 @@ def test_sign_in_with_otp() -> None:
         assert args[0] == "POST"
         assert args[1] == "otp"
         assert kwargs["body"]["phone"] == phone
-        assert kwargs["body"]["create_user"] == True
+        assert kwargs["body"]["create_user"]
         assert kwargs["body"]["data"] == {"custom": "data"}
         assert kwargs["body"]["channel"] == "whatsapp"
         assert (

src/auth/tests/_sync/test_gotrue_admin_api.py

@@ -142,23 +142,27 @@ def test_modify_confirm_email_using_update_user_by_id() -> None:
 
 def test_invalid_credential_sign_in_with_phone() -> None:
     try:
-        client_api_auto_confirm_off_signups_enabled_client().sign_in_with_password(
-            {
-                "phone": "+123456789",
-                "password": "strong_pwd",
-            }
+        (
+            client_api_auto_confirm_off_signups_enabled_client().sign_in_with_password(
+                {
+                    "phone": "+123456789",
+                    "password": "strong_pwd",
+                }
+            )
         )
     except AuthApiError as e:
         assert e.to_dict()
 
 
 def test_invalid_credential_sign_in_with_email() -> None:
     try:
-        client_api_auto_confirm_off_signups_enabled_client().sign_in_with_password(
-            {
-                "email": "[email protected]",
-                "password": "strong_pwd",
-            }
+        (
+            client_api_auto_confirm_off_signups_enabled_client().sign_in_with_password(
+                {
+                    "email": "[email protected]",
+                    "password": "strong_pwd",
+                }
+            )
         )
     except AuthApiError as e:
         assert e.to_dict()