feat: log more detail on skipped event triggers

There's not enough explanation on the cause of the skipped event
triggers when `supautils.log_skipped_evtrigs` is enabled.

Now logs will show the extra DETAIL to solve this:

```sql
create table supa_stuff();
NOTICE:  Skipping event trigger function "show_current_user" for user "postgres"
DETAIL:  "postgres" is a superuser and the function "show_current_user" is not superuser-owned, it's owned by "privileged_role"
```

Author: steve-chavez

src/supautils.c

@@ -101,11 +101,21 @@ static void supautils_fmgr_hook(FmgrHookEventType event, FmgrInfo *flinfo, Datum
     // we only need to change behavior before the function gets executed
     case FHET_START: {
         const char *current_role_name = GetUserNameFromId(GetUserId(), false);
-        if (superuser() || is_reserved_role(current_role_name, false)) {
-            bool function_is_owned_by_super = superuser_arg(get_function_owner((func_owner_search){ .as = FO_SEARCH_FINFO, .val.finfo = flinfo }));
+        const bool role_is_super = superuser();
+        const bool role_is_reserved = is_reserved_role(current_role_name, false);
+        if (role_is_super || role_is_reserved) {
+            Oid func_owner = get_function_owner((func_owner_search){ .as = FO_SEARCH_FINFO, .val.finfo = flinfo });
+            bool function_is_owned_by_super = superuser_arg(func_owner);
             if (!function_is_owned_by_super){
-                if (log_skipped_evtrigs)
-                  elog(NOTICE, "Skipping event trigger function \"%s\" for user \"%s\"", get_func_name(flinfo->fn_oid), current_role_name);
+                if (log_skipped_evtrigs){
+                  char *func_name = get_func_name(flinfo->fn_oid);
+                  ereport(
+                    NOTICE,
+                    errmsg("Skipping event trigger function \"%s\" for user \"%s\"", func_name, current_role_name),
+                    errdetail("\"%s\" %s and the function \"%s\" is not superuser-owned, it's owned by \"%s\"",
+                        current_role_name, role_is_super?"is a superuser":"is a reserved role", func_name, GetUserNameFromId(func_owner, false))
+                  );
+                }
                 // we can't skip execution directly inside the fmgr_hook (although we can abort it with ereport)
                 // so instead we use the workaround of changing the event trigger function to a noop function
                 force_noop(flinfo);

test/expected/event_triggers.out.in

@@ -116,13 +116,27 @@ select count(*) = 1 as only_one_super from pg_roles where rolsuper;
  t
 (1 row)
 
--- ensure logging skipped event triggers happens when enabled
+-- ensure logging skipped event triggers happens when enabled, for superusers and reserved roles
 set supautils.log_skipped_evtrigs = true;
 \echo
 
 create table supa_stuff();
 NOTICE:  Skipping event trigger function "show_current_user" for user "postgres"
+DETAIL:  "postgres" is a superuser and the function "show_current_user" is not superuser-owned, it's owned by "privileged_role"
 NOTICE:  Skipping event trigger function "become_super" for user "postgres"
+DETAIL:  "postgres" is a superuser and the function "become_super" is not superuser-owned, it's owned by "privileged_role"
+\echo
+
+set role supabase_storage_admin;
+\echo
+
+create table some_stuff();
+NOTICE:  Skipping event trigger function "show_current_user" for user "supabase_storage_admin"
+DETAIL:  "supabase_storage_admin" is a reserved role and the function "show_current_user" is not superuser-owned, it's owned by "privileged_role"
+NOTICE:  Skipping event trigger function "become_super" for user "supabase_storage_admin"
+DETAIL:  "supabase_storage_admin" is a reserved role and the function "become_super" is not superuser-owned, it's owned by "privileged_role"
+\echo
+
 reset supautils.log_skipped_evtrigs;
 \echo
 

test/sql/event_triggers.sql

@@ -101,11 +101,18 @@ set role postgres;
 create table super_duper_stuff();
 select count(*) = 1 as only_one_super from pg_roles where rolsuper;
 
--- ensure logging skipped event triggers happens when enabled
+-- ensure logging skipped event triggers happens when enabled, for superusers and reserved roles
 set supautils.log_skipped_evtrigs = true;
 \echo
 
 create table supa_stuff();
+\echo
+
+set role supabase_storage_admin;
+\echo
+
+create table some_stuff();
+\echo
 
 reset supautils.log_skipped_evtrigs;
 \echo