Skip to content

Commit 8443e16

Browse files
authored
chore(s3vectors): remove bucket_name option from import foreign schema statement (#525)
1 parent e9ca7eb commit 8443e16

File tree

4 files changed

+12
-21
lines changed

4 files changed

+12
-21
lines changed

docs/catalog/s3vectors.md

Lines changed: 4 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -126,11 +126,8 @@ For example, using below SQL can automatically create foreign tables in the `s3_
126126

127127
```sql
128128
-- create foreign table for each index from S3 Vector bucket
129-
import foreign schema s3_vectors
130-
from server s3_vectors_server into s3_vectors
131-
options (
132-
bucket_name 'my-vector-bucket'
133-
);
129+
import foreign schema "my-vector-bucket"
130+
from server s3_vectors_server into s3_vectors;
134131
```
135132

136133
### S3 Vector Tables
@@ -375,11 +372,8 @@ Import the foreign table:
375372

376373
```sql
377374
-- Import all indexes from a vector bucket
378-
import foreign schema s3_vectors
379-
from server s3_vectors_server into s3_vectors
380-
options (
381-
bucket_name 'my-vector-bucket'
382-
);
375+
import foreign schema "my-vector-bucket"
376+
from server s3_vectors_server into s3_vectors;
383377

384378
-- or, create the foreign table manually
385379
create foreign table if not exists s3_vectors.embeddings (

wrappers/src/fdw/s3vectors_fdw/README.md

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,8 @@ This is a foreign data wrapper for [AWS S3 Vectors](https://aws.amazon.com/s3/fe
88

99
## Changelog
1010

11-
| Version | Date | Notes |
12-
| ------- | ---------- | ---------------------------------------------------- |
13-
| 0.1.1 | 2025-11-17 | Changed 'embd' type name to 's3vec' |
14-
| 0.1.0 | 2025-09-14 | Initial version |
11+
| Version | Date | Notes |
12+
| ------- | ---------- | ---------------------------------------------------------- |
13+
| 0.1.2 | 2025-11-19 | Removed 'bucket_name' option from 'import foreign schema' |
14+
| 0.1.1 | 2025-11-17 | Changed 'embd' type name to 's3vec' |
15+
| 0.1.0 | 2025-09-14 | Initial version |

wrappers/src/fdw/s3vectors_fdw/s3vectors_fdw.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ use super::s3vec::S3Vec;
1919
use super::{S3VectorsFdwError, S3VectorsFdwResult};
2020

2121
#[wrappers_fdw(
22-
version = "0.1.1",
22+
version = "0.1.2",
2323
author = "Supabase",
2424
website = "https://github.com/supabase/wrappers/tree/main/wrappers/src/fdw/s3vectors_fdw",
2525
error_type = "S3VectorsFdwError"
@@ -453,7 +453,7 @@ impl ForeignDataWrapper<S3VectorsFdwError> for S3VectorsFdw {
453453
&mut self,
454454
import_stmt: ImportForeignSchemaStmt,
455455
) -> S3VectorsFdwResult<Vec<String>> {
456-
let bucket_name = require_option("bucket_name", &import_stmt.options)?;
456+
let bucket_name = &import_stmt.remote_schema;
457457
let mut next_token: Option<String> = None;
458458
let mut ret: Vec<String> = Vec::new();
459459

wrappers/src/fdw/s3vectors_fdw/tests.rs

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -29,11 +29,7 @@ mod tests {
2929
c.update(r#"CREATE SCHEMA IF NOT EXISTS s3_vectors"#, None, &[])
3030
.unwrap();
3131
c.update(
32-
r#"IMPORT FOREIGN SCHEMA "s3_vectors" FROM SERVER s3_vectors_server INTO s3_vectors
33-
OPTIONS (
34-
bucket_name 'my-vector-bucket'
35-
)
36-
"#,
32+
r#"IMPORT FOREIGN SCHEMA "my-vector-bucket" FROM SERVER s3_vectors_server INTO s3_vectors"#,
3733
None,
3834
&[],
3935
)

0 commit comments

Comments
 (0)