drop raven (#4990)

we're not using it anyhow

Author: petrjasek

package-lock.json

@@ -103,7 +103,6 @@
     "postscribe": "2.0.8",
     "prop-types": "15.6.1",
     "rangy": "1.3.0",
-    "raven-js": "3.22.3",
     "react": "16.9.0",
     "react-autocomplete": "1.8.1",
     "react-bootstrap": "0.32.1",

package.json

@@ -1,44 +1,9 @@
-import Raven from 'raven-js';
-import {appConfig} from 'appConfig';
-
-ErrorHttpInterceptorFactory.$inject = ['$q'];
-function ErrorHttpInterceptorFactory($q) {
-    return {
-        responseError: function responseError(rejection) {
-            if (rejection.status >= 500 && rejection.status < 600) {
-                Raven.captureException(new Error('HTTP response error'), {
-                    tags: {component: 'server'},
-                    extra: {
-                        status: rejection.status,
-                        request: rejection.config,
-                        response: rejection.data,
-                    },
-                });
-            }
-            return $q.reject(rejection);
-        },
-    };
-}
-
 /**
  * @ngdoc module
  * @module superdesk.core.error
  * @name superdesk.core.error
  * @packageName superdesk.core
  * @description Superdesk error reporting module.
+ * @deprecated
  */
-angular.module('superdesk.core.error', [])
-    .config(['$httpProvider', '$provide', function($httpProvider, $provide) {
-        if (appConfig.raven != null && appConfig.raven.dsn) {
-            Raven.config(appConfig.raven.dsn, {
-                logger: 'javascript-client',
-                release: appConfig.version,
-            }).install();
-
-            $httpProvider.interceptors.push(ErrorHttpInterceptorFactory);
-
-            $provide.factory('$exceptionHandler', () => function errorCatcherHandler(exception, cause) {
-                Raven.captureException(exception, {tags: {component: 'ui'}, extra: exception});
-            });
-        }
-    }]);
+angular.module('superdesk.core.error', []);

scripts/core/error/error.ts

@@ -1,58 +1,16 @@
-import Raven, {RavenOptions} from 'raven-js';
-
 class Logger {
-    constructor() {
-        /* globals __SUPERDESK_CONFIG__: true */
-        const appConfig = __SUPERDESK_CONFIG__;
-
-        if (appConfig.raven && appConfig.raven.dsn.length > 0) {
-            Raven.config(appConfig.raven.dsn, {
-                logger: 'javascript-client',
-                release: appConfig.version,
-            }).install();
-        }
-    }
-
     error(
         e: Error,
         additionalData?: any, // has to be serializable to JSON string
     ) {
-        console.error(e);
-
-        const options: RavenOptions = {};
-
-        if (additionalData != null) {
-            try {
-                options.extra = {additionalData: JSON.stringify(additionalData)};
-            } catch (e) {
-                options.extra = {additionalData: 'Failed to serialize'};
-            }
-        }
-
-        Raven.captureException(e, options);
+        console.error(e, additionalData || '');
     }
 
     warn(
         message: string,
         additionalData?, // has to be serializable to JSON string
     ) {
-        const options: RavenOptions = {};
-
-        options['level'] = 'warning';
-
-        if (additionalData != null) {
-            try {
-                options.extra = {additionalData: JSON.stringify(additionalData)};
-            } catch (e) {
-                options.extra = {additionalData: 'Failed to serialize'};
-            }
-        }
-
-        console.warn(message, options);
-
-        if (Raven.isSetup()) {
-            Raven.captureMessage(message, options);
-        }
+        console.warn(message, additionalData || '');
     }
 }
 

scripts/core/services/logger.ts

@@ -15,7 +15,6 @@ import 'angular-contenteditable';
 import 'angular-vs-repeat';
 import 'angular-moment';
 import 'ng-file-upload';
-import 'raven-js';
 import 'rangy';
 import 'rangy-saverestore';
 import 'ment.io';

scripts/vendor.ts

@@ -318,11 +318,6 @@ function getDefaults(grunt) {
         // application version
         version: version || grunt.file.readJSON(path.join(__dirname, 'package.json')).version,
 
-        // raven settings
-        raven: {
-            dsn: process.env.SUPERDESK_RAVEN_DSN || '',
-        },
-
         // backend server URLs configuration
         server: {
             url: grunt.option('server') || process.env.SUPERDESK_URL || 'http://localhost:5000/api',