fix send to tab desk preferred desks handling (#5138)

use it for preselected value as well

SDESK-7438

Author: petrjasek

scripts/core/interactive-article-actions-panel/actions/duplicate-to-tab.tsx

@@ -23,11 +23,22 @@ interface IState {
 }
 
 export class DuplicateToTab extends React.PureComponent<IProps, IState> {
+    private userPreferredDesks: {[key: string]: boolean};
+
     constructor(props: IProps) {
         super(props);
 
+        const preferredDesks = sdApi.preferences.get('desks:preferred');
+
+        this.userPreferredDesks = preferredDesks?.selected ?? {};
+
         this.state = {
-            selectedDestination: getInitialDestination(props.items, canSendToPersonal(props.items)),
+            selectedDestination: getInitialDestination(
+                props.items,
+                canSendToPersonal(props.items),
+                undefined,
+                this.userPreferredDesks,
+            ),
         };
 
         this.duplicateItems = this.duplicateItems.bind(this);
@@ -59,6 +70,7 @@ export class DuplicateToTab extends React.PureComponent<IProps, IState> {
                 <PanelContent markupV2={markupV2}>
                     <ToggleBox variant="simple" title={gettext('Destination')} initiallyOpen>
                         <DestinationSelect
+                            preferredDesks={this.userPreferredDesks}
                             value={this.state.selectedDestination}
                             onChange={(value) => {
                                 this.setState({

scripts/core/interactive-article-actions-panel/actions/fetch-to-tab.tsx

@@ -24,11 +24,17 @@ interface IState {
 }
 
 export class FetchToTab extends React.PureComponent<IProps, IState> {
+    private userPreferredDesks: {[key: string]: boolean};
+
     constructor(props: IProps) {
         super(props);
 
+        const preferredDesks = sdApi.preferences.get('desks:preferred');
+
+        this.userPreferredDesks = preferredDesks?.selected ?? {};
+
         this.state = {
-            selectedDestination: getInitialDestination(props.items, false),
+            selectedDestination: getInitialDestination(props.items, false, undefined, this.userPreferredDesks),
         };
 
         this.fetchItems = this.fetchItems.bind(this);
@@ -76,6 +82,7 @@ export class FetchToTab extends React.PureComponent<IProps, IState> {
                 <PanelContent markupV2={markupV2}>
                     <ToggleBox variant="simple" title={gettext('Destination')} initiallyOpen>
                         <DestinationSelect
+                            preferredDesks={this.userPreferredDesks}
                             value={this.state.selectedDestination}
                             onChange={(value) => {
                                 this.setState({

scripts/core/interactive-article-actions-panel/actions/send-to-tab.tsx

@@ -50,6 +50,7 @@ export class SendToTab extends React.PureComponent<IProps, IState> {
                 props.items,
                 canSendToPersonal(props.items),
                 this.availableDesks,
+                this.userPreferredDesks,
             ),
             publishingDateOptions: getInitialPublishingDateOptions(props.items),
         };

scripts/core/interactive-article-actions-panel/utils/get-initial-destination.ts

@@ -8,6 +8,7 @@ export function getInitialDestination(
     items: Array<IArticle>,
     canSendToPersonal: boolean,
     availableDesks: OrderedMap<string, IDesk> = sdApi.desks.getAllDesks(),
+    userPreferredDesks: {[key: string]: boolean} = {},
 ): ISendToDestination {
     const lastDestination: ISendToDestination | null = sdApi.preferences.get('destination:active');
 
@@ -25,14 +26,17 @@ export function getInitialDestination(
         } else if (items.length === 1 && items[0].task?.desk != null) {
             return items[0].task.desk;
         } else {
-            return availableDesks.first()?._id ?? null;
+            return availableDesks.find((desk) => desk != null && userPreferredDesks[desk._id] === true)?._id
+                ?? availableDesks.first()?._id
+                ?? null;
         }
     })();
 
-    // If destinationDesk isn't found in availableDesks we set the
-    // destinationDesk to the first item from availableDesks
+    // If destinationDesk is no longer available, use the same fallback priority
+    // as initial selection: preferred desk first, then first available desk.
     if (!availableDesks.has(destinationDesk)) {
-        destinationDesk = availableDesks.first()?._id;
+        destinationDesk = availableDesks.find((desk) => desk != null && userPreferredDesks[desk._id] === true)?._id
+            ?? availableDesks.first()?._id;
     }
 
     if (destinationDesk == null) {