Skip to content

Commit 27d88cf

Browse files
committed
fix tie_breaker test
1 parent c76e323 commit 27d88cf

File tree

1 file changed

+16
-13
lines changed

1 file changed

+16
-13
lines changed

py/correctness/tests/test_sync.py

Lines changed: 16 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -397,38 +397,41 @@ def test_merge_same_w_tie_breaker():
397397
db3.execute("SELECT crsql_config_set('merge-equal-values', 1);")
398398
db3.commit()
399399

400+
# Sync changes so all nodes have seen changes from other nodes
400401
sync_left_to_right(db1, db2, 0)
401-
changes2 = db2.execute("SELECT \"table\", pk, cid, val, col_version, site_id, db_version FROM crsql_changes").fetchall()
402-
403402
sync_left_to_right(db2, db1, 0)
404-
changes1 = db1.execute("SELECT \"table\", pk, cid, val, col_version, site_id, db_version FROM crsql_changes").fetchall()
405-
406403
sync_left_to_right(db2, db3, 0)
407-
changes3 = db3.execute("SELECT \"table\", pk, cid, val, col_version, site_id, db_version FROM crsql_changes").fetchall()
404+
sync_left_to_right(db3, db2, 0)
405+
sync_left_to_right(db3, db1, 0)
406+
407+
changes1 = db1.execute("SELECT \"table\", pk, cid, val, col_version, site_id, db_version FROM crsql_changes").fetchall()[0]
408+
changes2 = db2.execute("SELECT \"table\", pk, cid, val, col_version, site_id, db_version FROM crsql_changes").fetchall()[0]
409+
changes3 = db3.execute("SELECT \"table\", pk, cid, val, col_version, site_id, db_version FROM crsql_changes").fetchall()[0]
408410

409-
# check that everything by db_version is the same
410-
assert (changes2[:-6] == changes1[:-6] == changes3[:-6])
411+
# check that everything but db_version is the same
412+
# print("changes2", changes2)
413+
assert (changes2[:-1] == changes1[:-1] == changes3[:-1])
411414

412415
# Test that we're stable / do not loop when we tie break equal values
413416

414417
sync_left_to_right(db2, db1, 0)
415-
changes1_2 = db1.execute("SELECT \"table\", pk, cid, val, col_version, site_id, db_version FROM crsql_changes").fetchall()
418+
changes1_2 = db1.execute("SELECT \"table\", pk, cid, val, col_version, site_id, db_version FROM crsql_changes").fetchall()[0]
416419
sync_left_to_right(db3, db2, 0)
417-
changes2_2 = db2.execute("SELECT \"table\", pk, cid, val, col_version, site_id, db_version FROM crsql_changes").fetchall()
420+
changes2_2 = db2.execute("SELECT \"table\", pk, cid, val, col_version, site_id, db_version FROM crsql_changes").fetchall()[0]
418421
sync_left_to_right(db1, db3, 0)
419-
changes3_2 = db3.execute("SELECT \"table\", pk, cid, val, col_version, site_id, db_version FROM crsql_changes").fetchall()
422+
changes3_2 = db3.execute("SELECT \"table\", pk, cid, val, col_version, site_id, db_version FROM crsql_changes").fetchall()[0]
420423

421424
# everything should stay the same, including db_version
422425
assert (changes1 == changes1_2)
423426
assert (changes2 == changes2_2)
424427
assert (changes3 == changes3_2)
425428

426429
sync_left_to_right(db3, db1, 0)
427-
changes1_2 = db1.execute("SELECT \"table\", pk, cid, val, col_version, site_id, db_version FROM crsql_changes").fetchall()
430+
changes1_2 = db1.execute("SELECT \"table\", pk, cid, val, col_version, site_id, db_version FROM crsql_changes").fetchall()[0]
428431
sync_left_to_right(db1, db2, 0)
429-
changes2_2 = db2.execute("SELECT \"table\", pk, cid, val, col_version, site_id, db_version FROM crsql_changes").fetchall()
432+
changes2_2 = db2.execute("SELECT \"table\", pk, cid, val, col_version, site_id, db_version FROM crsql_changes").fetchall()[0]
430433
sync_left_to_right(db2, db3, 0)
431-
changes3_2 = db3.execute("SELECT \"table\", pk, cid, val, col_version, site_id, db_version FROM crsql_changes").fetchall()
434+
changes3_2 = db3.execute("SELECT \"table\", pk, cid, val, col_version, site_id, db_version FROM crsql_changes").fetchall()[0]
432435

433436
# everything should stay the same, including db_version
434437
assert (changes1 == changes1_2)

0 commit comments

Comments
 (0)