fix test

Signed-off-by: Somtochi Onyekwere <somtochionyekwere@gmail.com>

Author: somtochiama

py/correctness/tests/test_dbversion.py

@@ -1,4 +1,6 @@
 import pathlib
+import sqlite3
+import pytest
 from crsql_correctness import connect, close, min_db_v, get_site_id, sync_left_to_right
 
 # c1
@@ -142,7 +144,7 @@ def create_db():
         return db1
 
 
-    db = create_db()
+    db1 = create_db()
     db2 = create_db()
 
     db1_site_id = get_site_id(db1)
@@ -218,20 +220,24 @@ def create_db():
     close(db2)
 
 def test_site_id_ordinal_is_set_and_updated():
-    c = connect(":memory:")
-
+    c1 = connect(":memory:")
     c2 = connect(":memory:")
-    other_site_id = get_site_id(c)
 
+    other_site_id = get_site_id(c2)
+    c1_site_id = get_site_id(c1)
     # first insert, assert db_version and ordinal is set
-    c.execute("SELECT crsql_set_db_version(?, ?)", (bytes(other_site_id), 3))
-    assert c.execute("SELECT db_version from crsql_db_versions where site_id = ?", (bytes(other_site_id),)).fetchone()[0] == 3
-    assert c.execute("SELECT count(*) from crsql_db_versions").fetchone()[0] == 2
-    assert c.execute("SELECT ordinal from crsql_site_id where site_id = ?", (bytes(other_site_id),)).fetchone()[0] == 1
+    c1.execute("SELECT crsql_set_db_version(?, ?)", (bytes(other_site_id), 3))
+    c1.commit()
+    assert c1.execute("SELECT db_version from crsql_db_versions where site_id = ?", (bytes(other_site_id),)).fetchone()[0] == 3
+    assert c1.execute("SELECT count(*) from crsql_site_id").fetchone()[0] == 2
+    assert c1.execute("SELECT ordinal from crsql_site_id where site_id = ?", (bytes(other_site_id),)).fetchone()[0] == 1
+
+    c1.execute("SELECT crsql_set_db_version(?, ?)", (bytes(other_site_id), 5))
+    assert c1.execute("SELECT db_version from crsql_db_versions where site_id = ?", (bytes(other_site_id),)).fetchone()[0] == 5
 
-    c.execute("SELECT crsql_set_db_version(?, ?)", (bytes(other_site_id), 5))
-    assert c.execute("SELECT db_version from crsql_db_versions where site_id = ?", (bytes(other_site_id),)).fetchone()[0] == 5
+    # smaller db_version should not get set`x`
+    c1.execute("SELECT crsql_set_db_version(?, ?)", (bytes(other_site_id), 2))
+    assert c1.execute("SELECT db_version from crsql_db_versions where site_id = ?", (bytes(other_site_id),)).fetchone()[0] == 5
 
-    # smaller db_version should not get set``
-    c.execute("SELECT crsql_set_db_version(?, ?)", (bytes(other_site_id), 2))
-    assert c.execute("SELECT db_version from crsql_db_versions where site_id = ?", (bytes(other_site_id),)).fetchone()[0] == 5
+    close(c1)
+    close(c2)