Validate machine limits before performing b/g deployment (#2817)

validate org limits before performing bluegreen deployment

Author: gwuah

api/resource_deploy.go

@@ -121,3 +121,22 @@ func (c *Client) GetReleaseCommand(ctx context.Context, id string) (*ReleaseComm
 
 	return data.ReleaseCommandNode, nil
 }
+
+func (c *Client) CanPerformBluegreenDeployment(ctx context.Context, appName string) (bool, error) {
+	query := `
+		query ($appName: String!) {
+			canPerformBluegreenDeployment(name: $appName)
+		}
+	`
+
+	req := c.NewRequest(query)
+
+	req.Var("appName", appName)
+
+	data, err := c.RunWithContext(ctx, req)
+	if err != nil {
+		return false, err
+	}
+
+	return data.CanPerformBluegreenDeployment, nil
+}

api/types.go

@@ -215,6 +215,8 @@ type Query struct {
 	UpdateRemoteBuilder struct {
 		Organization Organization
 	}
+
+	CanPerformBluegreenDeployment bool
 }
 
 type CreatedWireGuardPeer struct {

gql/schema.graphql

@@ -6292,7 +6292,7 @@ input MigrateVolumeInput {
   """
   The target Volume ID to be migrated
   """
-  targetVolumeId: Int!
+  targetVolumeId: String!
 
   """
   Use the latest snapshot instead of creating a new one.
@@ -8222,6 +8222,16 @@ type Queries {
     type: String @deprecated(reason: "will be removed")
   ): AppConnection!
 
+  """
+  Verifies if an app can undergo a bluegreen deployment
+  """
+  canPerformBluegreenDeployment(
+    """
+    The name of the app
+    """
+    name: String!
+  ): Boolean!
+
   """
   Find a certificate by ID
   """
@@ -8674,7 +8684,7 @@ input RegisterVolumeInput {
   """
   The application to attach the new volume to
   """
-  appId: ID!
+  appId: Int!
   autoBackupEnabled: Boolean!
 
   """
@@ -8702,7 +8712,7 @@ input RegisterVolumeInput {
   Desired volume size, in GB
   """
   sizeGb: Int!
-  snapshotId: ID
+  snapshot: ID
   volumeId: String!
 }
 

internal/command/deploy/strategy_bluegreen.go

@@ -13,6 +13,7 @@ import (
 
 	"github.com/superfly/flyctl/api"
 	"github.com/superfly/flyctl/flaps"
+	"github.com/superfly/flyctl/internal/appconfig"
 	"github.com/superfly/flyctl/internal/ctrlc"
 	"github.com/superfly/flyctl/internal/machine"
 	"github.com/superfly/flyctl/iostreams"
@@ -27,21 +28,23 @@ var (
 	ErrMarkReadyForTraffic = errors.New("failed to mark green machines as ready")
 	ErrDestroyBlueMachines = errors.New("failed to destroy previous deployment")
 	ErrValidationError     = errors.New("app not in valid state for bluegreen deployments")
+	ErrOrgLimit            = errors.New("app can't undergo bluegreen deployment due to org limits")
 )
 
 type blueGreen struct {
-	greenMachines   []machine.LeasableMachine
-	blueMachines    []*machineUpdateEntry
-	flaps           *flaps.Client
-	io              *iostreams.IOStreams
-	colorize        *iostreams.ColorScheme
-	clearLinesAbove func(count int)
-	timeout         time.Duration
-	aborted         atomic.Bool
-	healthLock      sync.RWMutex
-	stateLock       sync.RWMutex
-	ctrlcHook       ctrlc.Handle
-
+	greenMachines       []machine.LeasableMachine
+	blueMachines        []*machineUpdateEntry
+	flaps               *flaps.Client
+	apiClient           *api.Client
+	io                  *iostreams.IOStreams
+	colorize            *iostreams.ColorScheme
+	clearLinesAbove     func(count int)
+	timeout             time.Duration
+	aborted             atomic.Bool
+	healthLock          sync.RWMutex
+	stateLock           sync.RWMutex
+	ctrlcHook           ctrlc.Handle
+	appConfig           *appconfig.Config
 	hangingBlueMachines []string
 }
 
@@ -50,6 +53,8 @@ func BlueGreenStrategy(md *machineDeployment, blueMachines []*machineUpdateEntry
 		greenMachines:       []machine.LeasableMachine{},
 		blueMachines:        blueMachines,
 		flaps:               md.flapsClient,
+		apiClient:           md.apiClient,
+		appConfig:           md.appConfig,
 		timeout:             md.waitTimeout,
 		io:                  md.io,
 		colorize:            md.colorize,
@@ -415,6 +420,15 @@ func (bg *blueGreen) Deploy(ctx context.Context) error {
 		return ErrAborted
 	}
 
+	canPerform, err := bg.apiClient.CanPerformBluegreenDeployment(ctx, bg.appConfig.AppName)
+	if err != nil {
+		return err
+	}
+
+	if !canPerform {
+		return ErrOrgLimit
+	}
+
 	bg.attachCustomTopLevelChecks()
 
 	totalChecks := 0