Skip to content

Commit 91239eb

Browse files
authored
perf: remove queue traces (#11)
They are too noisy. We'll replace them by metrics in a future patch. Signed-off-by: Juliana Oliveira <juliana@fly.io>
1 parent 81acae3 commit 91239eb

File tree

1 file changed

+0
-6
lines changed

1 file changed

+0
-6
lines changed

internal/queue/queue.go

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -376,9 +376,7 @@ func (q *Queue) getNextItem(ctx context.Context) (*queueItem, error) {
376376

377377
element := q.items.Front()
378378
if element == nil {
379-
_, waitSpan := trace.StartSpan(ctx, "waitForItem")
380379
q.cond.Wait()
381-
waitSpan.End()
382380
continue
383381
}
384382

@@ -397,9 +395,7 @@ func (q *Queue) getNextItem(ctx context.Context) (*queueItem, error) {
397395
// Item is delayed. Only one worker waits on the timer.
398396
// Other workers just wait for a signal.
399397
if q.timerLeaderActive {
400-
_, waitSpan := trace.StartSpan(ctx, "waitForReady")
401398
q.cond.Wait()
402-
waitSpan.End()
403399
continue
404400
}
405401

@@ -418,9 +414,7 @@ func (q *Queue) getNextItem(ctx context.Context) (*queueItem, error) {
418414
q.cond.Broadcast()
419415
}()
420416

421-
_, waitSpan := trace.StartSpan(ctx, "waitForReadyAsLeader")
422417
q.cond.Wait()
423-
waitSpan.End()
424418
timer.Stop()
425419
close(timerDone)
426420
q.timerLeaderActive = false

0 commit comments

Comments
 (0)