feat: refactor hover window configuration and update logic

- Updated hover window size calculations to use a default width from configuration.
- Removed unused properties related to hover window dimensions from ConfigModel.
- Simplified UpdateMeeting method by removing max title width parameter.
- Adjusted hover window update calls throughout the application to reflect changes in method signature and configuration.

Author: Marcus Markiewicz

src/ComingUpNextTray/HoverWindow.cs

@@ -37,8 +37,8 @@ public HoverWindow()
                 Font = new Font(FontFamily.GenericSansSerif, 10f, FontStyle.Bold, GraphicsUnit.Point),
                 Location = new Point(8, 8),
 
-                // Let layout compute width; we'll cap in UpdateMeeting to avoid overly wide windows.
-                Size = new Size(204, 18),
+                // Let layout compute width; default to the configured hover window width.
+                Size = new Size(UiLayout.DefaultHoverWindowWidth - (this.Padding.Horizontal + 8), 18),
             };
 
             this.timeLabel = new Label
@@ -73,9 +73,8 @@ public HoverWindow()
         /// <param name="now">Reference time for formatting.</param>
         /// <param name="overlayToken">Optional overlay token (e.g. "5" or "1h" or "5 min") to display after the title as "(In X)".</param>
         /// <param name="fetchError">Optional fetch error message to display instead of meeting information.</param>
-        /// <param name="maxTitleWidthPx">Optional override max title width in pixels for truncation. If null uses <see cref="UiLayout.DefaultMaxTextWidth"/>.</param>
         [System.Diagnostics.CodeAnalysis.SuppressMessage("Usage", "CA1303:Do not pass literals as localized parameters", Justification = "Using centralized UiText constants; localization pending.")]
-        public void UpdateMeeting(CalendarEntry? meeting, DateTime now, string? overlayToken = null, string? fetchError = null, int? maxTitleWidthPx = null)
+        public void UpdateMeeting(CalendarEntry? meeting, DateTime now, string? overlayToken = null, string? fetchError = null)
         {
             // If an error occurred during fetch, display the error prominently instead of meeting info.
             if (!string.IsNullOrEmpty(fetchError))
@@ -118,10 +117,10 @@ public void UpdateMeeting(CalendarEntry? meeting, DateTime now, string? overlayT
                     this.titleLabel.Text = title;
                 }
 
-                // Truncate title to fit within reasonable width to avoid overly wide hover window.
-                // If an overlay token is present, reserve space for the suffix (e.g. " (in 5 min)") so it is not lost.
-                int defaultMax = UiLayout.DefaultMaxTextWidth;
-                int maxInnerWidth = (maxTitleWidthPx ?? defaultMax) - this.Padding.Horizontal - 8; // leave some margin
+                // Truncate title to fit within the configured hover window width.
+                // Compute inner available width (account for padding and small margin).
+                int formWidth = UiLayout.DefaultHoverWindowWidth;
+                int maxInnerWidth = formWidth - this.Padding.Horizontal - 8; // leave some margin
 
                 string suffix = string.Empty;
                 if (!string.IsNullOrEmpty(overlayToken)
@@ -146,6 +145,9 @@ public void UpdateMeeting(CalendarEntry? meeting, DateTime now, string? overlayT
 
                 this.titleLabel.Text = string.Concat(truncatedBase, suffix);
 
+                // Ensure titleLabel fills the inner width so ellipsis/AutoEllipsis layout works predictably.
+                this.titleLabel.Size = new Size(maxInnerWidth, this.titleLabel.Height);
+
                 // Apply ellipsis behavior on the label control; UiTruncation already appends '...' when truncating the base title.
                 this.titleLabel.AutoEllipsis = true;
 
@@ -154,10 +156,10 @@ public void UpdateMeeting(CalendarEntry? meeting, DateTime now, string? overlayT
                 this.timeLabel.Text = meeting.StartTime.ToString(timeFormat, CultureInfo.CurrentCulture);
             }
 
-            // Resize to fit
+            // Resize to fit, but never exceed the configured hover window default width.
             int width = Math.Max(this.titleLabel.Width, this.timeLabel.Width) + this.Padding.Horizontal + 8;
             int height = this.timeLabel.Bottom + this.Padding.Bottom + 8;
-            this.Size = new Size(Math.Min(width, UiLayout.DefaultMaxTextWidth), height);
+            this.Size = new Size(Math.Min(width, UiLayout.DefaultHoverWindowWidth), height);
         }
 
         /// <summary>

src/ComingUpNextTray/Models/ConfigModel.cs

@@ -28,17 +28,5 @@ internal sealed class ConfigModel
 
         /// <summary>Gets or sets saved top coordinate of hover window (screen coordinates).</summary>
         public int? HoverWindowTop { get; set; }
-
-        /// <summary>Gets or sets saved width of hover window in pixels.</summary>
-        public int? HoverWindowWidth { get; set; }
-
-        /// <summary>Gets or sets saved height of hover window in pixels.</summary>
-        public int? HoverWindowHeight { get; set; }
-
-        /// <summary>Gets or sets maximum hover title width in pixels for truncation (optional).</summary>
-        public int? MaxHoverTitleWidth { get; set; }
-
-        /// <summary>Gets or sets maximum menu text width in pixels for truncation (optional).</summary>
-        public int? MaxMenuTextWidth { get; set; }
     }
 }

src/ComingUpNextTray/TrayApplication.cs

@@ -26,10 +26,6 @@ internal sealed class TrayApplication : IDisposable
         private string? _lastFetchError;
         private int? _hoverWindowLeft;
         private int? _hoverWindowTop;
-        private int? _hoverWindowWidth;
-        private int? _hoverWindowHeight;
-        private int? _maxHoverTitleWidth;
-        private int? _maxMenuTextWidth;
 
         // Overlay is now always enabled; legacy flag retained only for backward compatible config file reads.
 
@@ -384,7 +380,7 @@ internal void SetCalendarUrl(string? url)
             this._calendarUrl = string.IsNullOrWhiteSpace(url) ? string.Empty : url.Trim();
 
             // Save full config to preserve other values
-            this.SaveConfig(new ConfigModel { CalendarUrl = this._calendarUrl, RefreshMinutes = this._refreshMinutes, ShowHoverWindow = this._showHoverWindow, IgnoreFreeOrFollowing = this._ignoreFreeOrFollowing, HoverWindowLeft = this._hoverWindowLeft, HoverWindowTop = this._hoverWindowTop, HoverWindowWidth = this._hoverWindowWidth, HoverWindowHeight = this._hoverWindowHeight, MaxHoverTitleWidth = this._maxHoverTitleWidth, MaxMenuTextWidth = this._maxMenuTextWidth });
+            this.SaveConfig(new ConfigModel { CalendarUrl = this._calendarUrl, RefreshMinutes = this._refreshMinutes, ShowHoverWindow = this._showHoverWindow, IgnoreFreeOrFollowing = this._ignoreFreeOrFollowing, HoverWindowLeft = this._hoverWindowLeft, HoverWindowTop = this._hoverWindowTop });
         }
 
         /// <summary>Sets refresh interval minutes and persists config.</summary>
@@ -397,7 +393,7 @@ internal void SetRefreshMinutes(int minutes)
             }
 
             this._refreshMinutes = minutes;
-            this.SaveConfig(new ConfigModel { CalendarUrl = this._calendarUrl, RefreshMinutes = this._refreshMinutes, ShowHoverWindow = this._showHoverWindow, IgnoreFreeOrFollowing = this._ignoreFreeOrFollowing, HoverWindowLeft = this._hoverWindowLeft, HoverWindowTop = this._hoverWindowTop, HoverWindowWidth = this._hoverWindowWidth, HoverWindowHeight = this._hoverWindowHeight, MaxHoverTitleWidth = this._maxHoverTitleWidth, MaxMenuTextWidth = this._maxMenuTextWidth });
+            this.SaveConfig(new ConfigModel { CalendarUrl = this._calendarUrl, RefreshMinutes = this._refreshMinutes, ShowHoverWindow = this._showHoverWindow, IgnoreFreeOrFollowing = this._ignoreFreeOrFollowing, HoverWindowLeft = this._hoverWindowLeft, HoverWindowTop = this._hoverWindowTop });
         }
 
         /// <summary>Gets whether to show the hover window.</summary>
@@ -409,7 +405,7 @@ internal void SetRefreshMinutes(int minutes)
         internal void SetShowHoverWindow(bool v)
         {
             this._showHoverWindow = v;
-            this.SaveConfig(new ConfigModel { CalendarUrl = this._calendarUrl, RefreshMinutes = this._refreshMinutes, ShowHoverWindow = this._showHoverWindow, IgnoreFreeOrFollowing = this._ignoreFreeOrFollowing, HoverWindowLeft = this._hoverWindowLeft, HoverWindowTop = this._hoverWindowTop, HoverWindowWidth = this._hoverWindowWidth, HoverWindowHeight = this._hoverWindowHeight, MaxHoverTitleWidth = this._maxHoverTitleWidth, MaxMenuTextWidth = this._maxMenuTextWidth });
+            this.SaveConfig(new ConfigModel { CalendarUrl = this._calendarUrl, RefreshMinutes = this._refreshMinutes, ShowHoverWindow = this._showHoverWindow, IgnoreFreeOrFollowing = this._ignoreFreeOrFollowing, HoverWindowLeft = this._hoverWindowLeft, HoverWindowTop = this._hoverWindowTop });
         }
 
         /// <summary>
@@ -424,37 +420,7 @@ internal void SetShowHoverWindow(bool v)
         /// <returns>Top coordinate in screen pixels, or null if not set.</returns>
         internal int? GetHoverWindowTopForUi() => this._hoverWindowTop;
 
-        /// <summary>Gets saved hover window width in pixels.</summary>
-        /// <returns>Width in pixels or null.</returns>
-        internal int? GetHoverWindowWidthForUi() => this._hoverWindowWidth;
-
-        /// <summary>Gets saved hover window height in pixels.</summary>
-        /// <returns>Height in pixels or null.</returns>
-        internal int? GetHoverWindowHeightForUi() => this._hoverWindowHeight;
-
-        /// <summary>Gets configured maximum hover title width in pixels for truncation purposes.</summary>
-        /// <returns>Max hover title width in pixels or null to use default.</returns>
-        internal int? GetHoverTitleMaxWidthForUi() => this._maxHoverTitleWidth;
-
-        /// <summary>Sets configured maximum hover title width in pixels and persists config.</summary>
-        /// <param name="pixels">Width in pixels or null to clear.</param>
-        internal void SetHoverTitleMaxWidth(int? pixels)
-        {
-            this._maxHoverTitleWidth = pixels;
-            this.SaveConfig(new ConfigModel { CalendarUrl = this._calendarUrl, RefreshMinutes = this._refreshMinutes, ShowHoverWindow = this._showHoverWindow, IgnoreFreeOrFollowing = this._ignoreFreeOrFollowing, HoverWindowLeft = this._hoverWindowLeft, HoverWindowTop = this._hoverWindowTop, HoverWindowWidth = this._hoverWindowWidth, HoverWindowHeight = this._hoverWindowHeight, MaxHoverTitleWidth = this._maxHoverTitleWidth, MaxMenuTextWidth = this._maxMenuTextWidth });
-        }
-
-        /// <summary>Gets configured maximum menu text width in pixels for truncation purposes.</summary>
-        /// <returns>Max menu text width in pixels or null to use default.</returns>
-        internal int? GetMenuTextMaxWidthForUi() => this._maxMenuTextWidth;
-
-        /// <summary>Sets configured maximum menu text width in pixels and persists config.</summary>
-        /// <param name="pixels">Width in pixels or null to clear.</param>
-        internal void SetMenuTextMaxWidth(int? pixels)
-        {
-            this._maxMenuTextWidth = pixels;
-            this.SaveConfig(new ConfigModel { CalendarUrl = this._calendarUrl, RefreshMinutes = this._refreshMinutes, ShowHoverWindow = this._showHoverWindow, IgnoreFreeOrFollowing = this._ignoreFreeOrFollowing, HoverWindowLeft = this._hoverWindowLeft, HoverWindowTop = this._hoverWindowTop, HoverWindowWidth = this._hoverWindowWidth, HoverWindowHeight = this._hoverWindowHeight, MaxHoverTitleWidth = this._maxHoverTitleWidth, MaxMenuTextWidth = this._maxMenuTextWidth });
-        }
+        // Hover window size getters removed; sizes are not persisted.
 
         /// <summary>
         /// Sets hover window position and persists config.
@@ -465,17 +431,7 @@ internal void SetHoverWindowPosition(int? left, int? top)
         {
             this._hoverWindowLeft = left;
             this._hoverWindowTop = top;
-            this.SaveConfig(new ConfigModel { CalendarUrl = this._calendarUrl, RefreshMinutes = this._refreshMinutes, ShowHoverWindow = this._showHoverWindow, IgnoreFreeOrFollowing = this._ignoreFreeOrFollowing, HoverWindowLeft = this._hoverWindowLeft, HoverWindowTop = this._hoverWindowTop, HoverWindowWidth = this._hoverWindowWidth, HoverWindowHeight = this._hoverWindowHeight, MaxHoverTitleWidth = this._maxHoverTitleWidth, MaxMenuTextWidth = this._maxMenuTextWidth });
-        }
-
-        /// <summary>Sets hover window size and persists config.</summary>
-        /// <param name="width">Width in pixels, or null to clear.</param>
-        /// <param name="height">Height in pixels, or null to clear.</param>
-        internal void SetHoverWindowSize(int? width, int? height)
-        {
-            this._hoverWindowWidth = width;
-            this._hoverWindowHeight = height;
-            this.SaveConfig(new ConfigModel { CalendarUrl = this._calendarUrl, RefreshMinutes = this._refreshMinutes, ShowHoverWindow = this._showHoverWindow, IgnoreFreeOrFollowing = this._ignoreFreeOrFollowing, HoverWindowLeft = this._hoverWindowLeft, HoverWindowTop = this._hoverWindowTop, HoverWindowWidth = this._hoverWindowWidth, HoverWindowHeight = this._hoverWindowHeight, MaxHoverTitleWidth = this._maxHoverTitleWidth, MaxMenuTextWidth = this._maxMenuTextWidth });
+            this.SaveConfig(new ConfigModel { CalendarUrl = this._calendarUrl, RefreshMinutes = this._refreshMinutes, ShowHoverWindow = this._showHoverWindow, IgnoreFreeOrFollowing = this._ignoreFreeOrFollowing, HoverWindowLeft = this._hoverWindowLeft, HoverWindowTop = this._hoverWindowTop });
         }
 
         /// <summary>Gets whether free/following meetings are ignored.</summary>
@@ -487,7 +443,7 @@ internal void SetHoverWindowSize(int? width, int? height)
         internal void SetIgnoreFreeOrFollowing(bool v)
         {
             this._ignoreFreeOrFollowing = v;
-            this.SaveConfig(new ConfigModel { CalendarUrl = this._calendarUrl, RefreshMinutes = this._refreshMinutes, ShowHoverWindow = this._showHoverWindow, IgnoreFreeOrFollowing = this._ignoreFreeOrFollowing, HoverWindowLeft = this._hoverWindowLeft, HoverWindowTop = this._hoverWindowTop, HoverWindowWidth = this._hoverWindowWidth, HoverWindowHeight = this._hoverWindowHeight, MaxHoverTitleWidth = this._maxHoverTitleWidth, MaxMenuTextWidth = this._maxMenuTextWidth });
+            this.SaveConfig(new ConfigModel { CalendarUrl = this._calendarUrl, RefreshMinutes = this._refreshMinutes, ShowHoverWindow = this._showHoverWindow, IgnoreFreeOrFollowing = this._ignoreFreeOrFollowing, HoverWindowLeft = this._hoverWindowLeft, HoverWindowTop = this._hoverWindowTop });
         }
 
         /// <summary>
@@ -564,26 +520,6 @@ private void LoadConfig()
                     {
                         this._hoverWindowTop = ht;
                     }
-
-                    if (cfg.HoverWindowWidth is int ww)
-                    {
-                        this._hoverWindowWidth = ww;
-                    }
-
-                    if (cfg.MaxHoverTitleWidth is int mhw)
-                    {
-                        this._maxHoverTitleWidth = mhw;
-                    }
-
-                    if (cfg.MaxMenuTextWidth is int mmw)
-                    {
-                        this._maxMenuTextWidth = mmw;
-                    }
-
-                    if (cfg.HoverWindowHeight is int wh)
-                    {
-                        this._hoverWindowHeight = wh;
-                    }
                 }
             }
             catch (JsonException)
@@ -608,7 +544,5 @@ private void LoadConfig()
                 this._configErrorDetected = true;
             }
         }
-
-        // Removed legacy MaybeShowBalloon method.
     }
 }