Skip to content

Commit 759ce60

Browse files
committed
fix: ensure correct UTC time verification in calendar entry tests
Updated assertions in CalendarServiceTests to verify event start times in UTC, avoiding discrepancies due to local time zone differences. Adjusted tests for single event parsing and biweekly occurrences to reflect accurate UTC conversion.
1 parent aa0ef7c commit 759ce60

File tree

1 file changed

+7
-4
lines changed

1 file changed

+7
-4
lines changed

tests/ComingUpNextTray.Tests/CalendarServiceTests.cs

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,8 @@ public void ParseIcs_ParsesSingleEvent() {
1515
IReadOnlyList<Models.CalendarEntry> result = CalendarService.ParseIcs(ics);
1616
Models.CalendarEntry evt = Assert.Single(result);
1717
Assert.Equal("Test Meeting", evt.Title);
18-
Assert.Equal(new DateTime(2025, 1, 1, 10, 0, 0, DateTimeKind.Utc).ToLocalTime().Hour, evt.StartTime.Hour);
18+
// Verify time in UTC to avoid time zone differences
19+
Assert.Equal(10, evt.StartTime.ToUniversalTime().Hour);
1920
// Uri normalization adds trailing slash to bare host; expect slash
2021
Assert.Equal("https://example.com/", evt.MeetingUrl?.ToString());
2122
}
@@ -151,9 +152,11 @@ public void ParseIcs_RRULEWithUntilOnTuesday_GeneratesTuesdayWhenWeekStartsLater
151152
e.Title == "FAB Eng Sync");
152153

153154
Assert.NotNull(tuesdayOccurrence);
154-
// Verify it's the correct time (14:35 PST = 17:35 EST in standard time)
155-
Assert.Equal(17, tuesdayOccurrence.StartTime.Hour); // 5 PM hour
156-
Assert.Equal(35, tuesdayOccurrence.StartTime.Minute);
155+
// Verify it's the correct time (14:35 PST = 22:35 UTC)
156+
// Convert to UTC to avoid time zone differences between local and CI
157+
DateTime startUtc = tuesdayOccurrence.StartTime.ToUniversalTime();
158+
Assert.Equal(22, startUtc.Hour);
159+
Assert.Equal(35, startUtc.Minute);
157160
}
158161

159162
[Fact]

0 commit comments

Comments
 (0)