Skip to content

Commit 923892b

Browse files
authored
fix: Revert updateMutation that breaks github integration (#3462)
Starting with a simpler hotfix revert. Signed-off-by: Igor Šarčević <igor@operately.com>
1 parent 4d264c9 commit 923892b

File tree

1 file changed

+14
-21
lines changed

1 file changed

+14
-21
lines changed

web_src/src/pages/organization/settings/IntegrationDetails.tsx

Lines changed: 14 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -1,25 +1,25 @@
1-
import { ArrowLeft, CircleX, ExternalLink, Loader2, Plug, Trash2 } from "lucide-react";
2-
import { Link, useNavigate, useParams } from "react-router-dom";
3-
import { useState, useEffect, useMemo } from "react";
1+
import type { ConfigurationField } from "@/api-client";
2+
import { PermissionTooltip } from "@/components/PermissionGate";
3+
import { Button } from "@/components/ui/button";
4+
import { Input } from "@/components/ui/input";
5+
import { Label } from "@/components/ui/label";
6+
import { usePermissions } from "@/contexts/PermissionsContext";
47
import {
58
useAvailableIntegrations,
69
useDeleteIntegration,
710
useIntegration,
811
useUpdateIntegration,
912
} from "@/hooks/useIntegrations";
10-
import { Button } from "@/components/ui/button";
11-
import { Input } from "@/components/ui/input";
12-
import { Label } from "@/components/ui/label";
13+
import { Alert, AlertDescription } from "@/ui/alert";
14+
import { IntegrationIcon } from "@/ui/componentSidebar/integrationIcons";
1315
import { ConfigurationFieldRenderer } from "@/ui/configurationFieldRenderer";
14-
import type { ConfigurationField } from "@/api-client";
15-
import { showErrorToast, showSuccessToast } from "@/utils/toast";
16+
import { IntegrationInstructions } from "@/ui/IntegrationInstructions";
1617
import { getApiErrorMessage } from "@/utils/errors";
1718
import { getIntegrationTypeDisplayName } from "@/utils/integrationDisplayName";
18-
import { IntegrationIcon } from "@/ui/componentSidebar/integrationIcons";
19-
import { IntegrationInstructions } from "@/ui/IntegrationInstructions";
20-
import { PermissionTooltip } from "@/components/PermissionGate";
21-
import { usePermissions } from "@/contexts/PermissionsContext";
22-
import { Alert, AlertDescription } from "@/ui/alert";
19+
import { showErrorToast, showSuccessToast } from "@/utils/toast";
20+
import { ArrowLeft, CircleX, ExternalLink, Loader2, Plug, Trash2 } from "lucide-react";
21+
import { useEffect, useMemo, useState } from "react";
22+
import { Link, useNavigate, useParams } from "react-router-dom";
2323
import { renderIntegrationMetadata } from "./integrationMetadataRenderers";
2424

2525
interface IntegrationDetailsProps {
@@ -155,7 +155,7 @@ export function IntegrationDetails({ organizationId }: IntegrationDetailsProps)
155155
}
156156
};
157157

158-
const handleBrowserAction = async () => {
158+
const handleBrowserAction = () => {
159159
if (!integration?.status?.browserAction) return;
160160

161161
const { url, method, formFields } = integration.status.browserAction;
@@ -186,13 +186,6 @@ export function IntegrationDetails({ organizationId }: IntegrationDetailsProps)
186186
window.open(url, "_blank");
187187
}
188188
}
189-
190-
// Trigger a resync with installed=true so the backend transitions to ready
191-
try {
192-
await updateMutation.mutateAsync({ configuration: { ...configValues, installed: "true" } });
193-
} catch {
194-
// Resync is best-effort
195-
}
196189
};
197190

198191
const handleDelete = async () => {

0 commit comments

Comments
 (0)