Skip to content

Commit c6cf15d

Browse files
GH files
1 parent 6283736 commit c6cf15d

File tree

2 files changed

+53
-0
lines changed

2 files changed

+53
-0
lines changed

.github/CODEOWNERS

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
* @idanasulin2706

.github/PULL_REQUEST_TEMPLATE.md

Lines changed: 52 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,52 @@
1+
## How Has This Been Tested?
2+
3+
Please describe the tests that you ran to verify your changes. Please also note any relevant details for your test configuration.
4+
- [ ] Test A
5+
- [ ] Test B
6+
7+
## Checklist:
8+
9+
- [ ] I have performed a self-review of my code
10+
- [ ] I have made corresponding changes to the knowledge base (if needed)
11+
- [ ] My changes generate no new warnings
12+
- [ ] I have verified that the specification is met and all functionalities are working as expected
13+
- [ ] I resolved conflicts
14+
- [ ] Code is passing compilation
15+
16+
## Reviewer Score - 100%
17+
18+
- [x] **Meeting Task Specifications (50%)**
19+
- This includes both UI design and backend functionality.
20+
- Ensure that the task requirements are fully met and that the implementation aligns with the specifications provided.
21+
22+
- [x] **Attention to Edge Cases (10%)**
23+
- Identify and handle edge cases that may not be immediately obvious.
24+
- Demonstrate thorough testing and consideration of potential issues.
25+
26+
- [x] **Writing Performant and Efficient Code (10%)**
27+
- Optimize the code for performance and efficiency.
28+
- Avoid unnecessary computations and strive for optimal resource usage.
29+
30+
- [x] **Addressing Feedback from Previous Code Reviews (10%)**
31+
- Act on feedback provided in previous code reviews.
32+
- Show improvement and a proactive approach to learning from past reviews.
33+
34+
- [x] **Adherence to Coding Conventions (5%)**
35+
- Follow the established coding standards and guidelines.
36+
- Maintain consistency in style and structure throughout the codebase.
37+
38+
- [x] **Writing Readable Code (5%)**
39+
- Write code that is easy to read and understand.
40+
- Use clear and meaningful variable names, and include comments where necessary.
41+
42+
- [x] **Considering Aspects Not Explicitly Mentioned in the Specification (5%)**
43+
- Demonstrate initiative by considering aspects that may not be explicitly mentioned in the task specification.
44+
- Enhance the implementation by thinking beyond the basic requirements.
45+
46+
- [x] **Completing Pull Request Form (2.5%)**
47+
- Demonstrate initiative by considering aspects that may not be explicitly mentioned in the task specification.
48+
- Enhance the implementation by thinking beyond the basic requirements.
49+
50+
- [x] **Up to 2 Cycles of Code Review (2.5%)**
51+
- Engage in up to two cycles of code review to refine and improve the code.
52+
- Incorporate suggestions and resolve any identified issues.

0 commit comments

Comments
 (0)