test: improve test stability

Author: porcellus

test/constants.js

@@ -33,6 +33,7 @@ export const SEND_VERIFY_EMAIL_API = `${TEST_APPLICATION_SERVER_BASE_URL}/auth/u
 export const VERIFY_EMAIL_API = `${TEST_APPLICATION_SERVER_BASE_URL}/auth/user/email/verify`;
 export const SIGN_IN_UP_API = `${TEST_APPLICATION_SERVER_BASE_URL}/auth/signinup`;
 export const GET_AUTH_URL_API = `${TEST_APPLICATION_SERVER_BASE_URL}/auth/authorisationurl`;
+export const LOGIN_METHODS_API = `${TEST_APPLICATION_SERVER_BASE_URL}/auth/loginmethods`;
 export const ST_ROOT_SELECTOR = `#${ST_ROOT_ID}`;
 
 export const SOMETHING_WENT_WRONG_ERROR = "Something went wrong. Please try again.";

test/end-to-end/multitenancy.dynamic_login_methods.test.js

@@ -47,6 +47,7 @@ import {
     TEST_SERVER_BASE_URL,
     SIGN_IN_UP_API,
     SOMETHING_WENT_WRONG_ERROR,
+    LOGIN_METHODS_API,
 } from "../constants";
 
 // Run the tests in a DOM environment.
@@ -211,6 +212,20 @@ describe("SuperTokens Multitenancy dynamic login methods", function () {
     });
 
     it("should postpone render with no react-router-dom", async function () {
+        await page.setRequestInterception(true);
+        let resolveLoginMethodsReq;
+        const loginMethodsReqPromise = new Promise((res) => {
+            resolveLoginMethodsReq = res;
+        });
+        const requestHandler = async (request) => {
+            if (request.url().startsWith(LOGIN_METHODS_API)) {
+                await loginMethodsReqPromise;
+                request.continue();
+            } else {
+                request.continue();
+            }
+        };
+        page.on("request", requestHandler);
         await enableDynamicLoginMethods(page, {
             emailPassword: { enabled: false },
             passwordless: { enabled: false },
@@ -223,7 +238,7 @@ describe("SuperTokens Multitenancy dynamic login methods", function () {
 
         const spinner = await waitForSTElement(page, "[data-supertokens~=delayedRender]");
         assert.ok(spinner);
-        await page.waitForTimeout(2000);
+        resolveLoginMethodsReq();
         const providers = await getProvidersLabels(page);
         compareArrayContents(providers, ["Continue with Apple"]);
     });

test/helpers.js

@@ -119,7 +119,7 @@ export async function getSubmitFormButtonLabel(page) {
 }
 
 export async function getProvidersLabels(page) {
-    await waitForSTElement(page);
+    await waitForSTElement(page, "[data-supertokens~=headerTitle]");
     return await page.evaluate(
         ({ ST_ROOT_SELECTOR }) =>
             Array.from(