test: update tests to fix CI (#802)

* test: update tests to fix CI

* test: add more missing var declarations

Author: porcellus

test/end-to-end/accountlinking.test.js

@@ -437,43 +437,6 @@ describe("SuperTokens Account linking", function () {
                 assert.strictEqual(new URL(page.url()).pathname, "/auth/");
             });
 
-            // TODO: explain
-            it.skip("should not allow sign up w/ passwordless after changing the email if it conflicts with an unverified user", async function () {
-                const email = `test-user+${Date.now()}@supertokens.com`;
-                const email2 = `test-user-2+${Date.now()}@supertokens.com`;
-
-                await setAccountLinkingConfig(true, false);
-                // 1. Sign up without account linking with an unverified ep user & log out
-                await tryEmailPasswordSignUp(page, email);
-                await logOut(page);
-
-                // 2. Sign up with passwordless
-                await tryPasswordlessSignInUp(page, email2);
-                await Promise.all([page.waitForSelector(".sessionInfo-user-id"), page.waitForNetworkIdle()]);
-                const accessTokenPayload = await page.evaluate(() =>
-                    window.__supertokensSessionRecipe.getAccessTokenPayloadSecurely()
-                );
-                const userId = accessTokenPayload.sub;
-                await logOut(page);
-
-                await page.evaluate(() => localStorage.removeItem("supertokens-passwordless-loginAttemptInfo"));
-                await Promise.all([
-                    page.goto(`${TEST_CLIENT_BASE_URL}/auth/?authRecipe=passwordless`),
-                    page.waitForNavigation({ waitUntil: "networkidle0" }),
-                ]);
-                await changeEmail("passwordless", userId, email);
-                await setAccountLinkingConfig(true, true, true);
-
-                await setInputValues(page, [{ name: "emailOrPhone", value: email }]);
-                await submitForm(page);
-
-                assert.strictEqual(
-                    await getGeneralError(page),
-                    "Cannot sign in / up due to security reasons. Please try a different login method or contact support. (ERR_CODE_003)"
-                );
-                assert.strictEqual(new URL(page.url()).pathname, "/auth/");
-            });
-
             it("should not allow sign up w/ passwordless if it conflicts with an unverified user", async function () {
                 const email = `test-user+${Date.now()}@supertokens.com`;
 

test/end-to-end/mfa.chooserscreen.test.js

@@ -65,6 +65,7 @@ describe("SuperTokens SignIn w/ MFA", function () {
     let browser;
     let page;
     let consoleLogs = [];
+    let skipped = false;
 
     before(async function () {
         if (!(await isMFASupported())) {

test/end-to-end/mfa.default_reqs.test.js

@@ -66,6 +66,7 @@ describe("SuperTokens SignIn w/ MFA", function () {
     let browser;
     let page;
     let consoleLogs = [];
+    let skipped = false;
 
     before(async function () {
         if (!(await isMFASupported())) {

test/end-to-end/mfa.factorscreen.otp.test.js

@@ -66,6 +66,7 @@ describe("SuperTokens SignIn w/ MFA", function () {
     let browser;
     let page;
     let consoleLogs = [];
+    let skipped = false;
 
     before(async function () {
         if (!(await isMFASupported())) {

test/end-to-end/mfa.factorscreen.totp.test.js

@@ -66,6 +66,7 @@ describe("SuperTokens SignIn w/ MFA", function () {
     let browser;
     let page;
     let consoleLogs = [];
+    let skipped = false;
 
     before(async function () {
         if (!(await isMFASupported())) {

test/end-to-end/mfa.helpers.js

@@ -17,7 +17,6 @@ import { TEST_CLIENT_BASE_URL } from "../constants";
 import { getTestPhoneNumber } from "../exampleTestHelpers";
 
 export async function setupUserWithAllFactors(page) {
-    // TODO: it'd be cleaner if this part was not done through the app
     const email = await getTestEmail();
     const phoneNumber = getTestPhoneNumber();
     await clearBrowserCookiesWithoutAffectingConsole(page, []);