Add fixes for tests to make them run

Author: deepjyoti30-st

package-lock.json

@@ -64,6 +64,8 @@ let page;
 let consoleLogs;
 
 describe("General error rendering", function () {
+    let coreUrl;
+    let enabledRecipes = undefined;
     before(async function () {
         const _isGeneralErrorSupported = await isGeneralErrorSupported();
         if (!_isGeneralErrorSupported) {
@@ -76,8 +78,8 @@ describe("General error rendering", function () {
 
     beforeEach(async function () {
         await backendHook("beforeEach");
-        const coreUrl = await setupCoreApp();
-        await setupST({ coreUrl });
+        coreUrl = await setupCoreApp();
+        await setupST({ coreUrl, enabledRecipes });
         page = await browser.newPage();
 
         consoleLogs = [];
@@ -212,11 +214,18 @@ describe("General error rendering", function () {
     });
 
     describe("ThirdPartyEmailPassword", function () {
+        before(async function () {
+            enabledRecipes = ["thirdpartyemailpassword", "session"];
+        });
+
         getEmailPasswordTests("thirdpartyemailpassword", "THIRD_PARTY_EMAIL_PASSWORD");
         getThirdPartyTests("thirdpartyemailpassword", "THIRD_PARTY_EMAIL_PASSWORD");
     });
 
     describe("ThirdPartyPasswordless", function () {
+        before(async function () {
+            enabledRecipes = ["thirdpartypasswordless", "session"];
+        });
         getThirdPartyTests("thirdpartypasswordless", "THIRD_PARTY_PASSWORDLESS");
     });
 

test/end-to-end/generalerror.test.js

@@ -334,7 +334,7 @@ describe("SuperTokens SignIn w/ MFA", function () {
                 }
             });
 
-            it("should redirect back if visited after sign in without stepUp param", async () => {
+            it("should show a link redirecting back if visited after sign in - setup", async () => {
                 await setupST({
                     ...appConfig,
                     mfaInfo: {
@@ -350,31 +350,12 @@ describe("SuperTokens SignIn w/ MFA", function () {
                     page.goto(`${TEST_CLIENT_BASE_URL}/auth/mfa/${factorId}`),
                     page.waitForNavigation({ waitUntil: "networkidle0" }),
                 ]);
-                await waitForDashboard(page);
-            });
-
-            it("should show a link redirecting back if visited after sign in - force setup", async () => {
-                await setupST({
-                    ...appConfig,
-                    mfaInfo: {
-                        requirements: [],
-                        alreadySetup: [factorId],
-                        allowedToSetup: [factorId],
-                    },
-                });
-
-                await tryEmailPasswordSignIn(page, email);
-
-                await Promise.all([
-                    page.goto(`${TEST_CLIENT_BASE_URL}/auth/mfa/${factorId}?setup=true`),
-                    page.waitForNavigation({ waitUntil: "networkidle0" }),
-                ]);
                 const backBtn = await waitForSTElement(page, "[data-supertokens~=backButton]");
                 await backBtn.click();
                 await waitForDashboard(page);
             });
 
-            it("should show a link redirecting back if visited after sign in - setup in stepUp", async () => {
+            it("should show a link redirecting back if visited after sign in - verification", async () => {
                 await setupST({
                     ...appConfig,
                     mfaInfo: {
@@ -387,28 +368,7 @@ describe("SuperTokens SignIn w/ MFA", function () {
                 await tryEmailPasswordSignIn(page, email);
 
                 await Promise.all([
-                    page.goto(`${TEST_CLIENT_BASE_URL}/auth/mfa/${factorId}?stepUp=true`),
-                    page.waitForNavigation({ waitUntil: "networkidle0" }),
-                ]);
-                const backBtn = await waitForSTElement(page, "[data-supertokens~=backButton]");
-                await backBtn.click();
-                await waitForDashboard(page);
-            });
-
-            it("should show a link redirecting back if visited after sign in - verification in stepUp", async () => {
-                await setupST({
-                    ...appConfig,
-                    mfaInfo: {
-                        requirements: [],
-                        alreadySetup: [factorId],
-                        allowedToSetup: [],
-                    },
-                });
-
-                await tryEmailPasswordSignIn(page, email);
-
-                await Promise.all([
-                    page.goto(`${TEST_CLIENT_BASE_URL}/auth/mfa/${factorId}?stepUp=true`),
+                    page.goto(`${TEST_CLIENT_BASE_URL}/auth/mfa/${factorId}`),
                     page.waitForNavigation({ waitUntil: "networkidle0" }),
                 ]);
                 const backBtn = await waitForSTElement(page, "[data-supertokens~=backButton]");

test/end-to-end/mfa.factorscreen.totp.test.js

@@ -258,7 +258,7 @@ describe("SuperTokens SignIn w/ MFA", function () {
         });
 
         it("should throw error if there are no valid next options", async () => {
-            setupST({
+            await setupST({
                 ...appConfig,
                 mfaInfo: {
                     requirements: ["unknown"],

test/end-to-end/mfa.signin.test.js

@@ -537,11 +537,6 @@ export function getPasswordlessTestCases({ authRecipe, logId, generalErrorRecipe
     });
 
     function getTestCases(contactMethod, inputName, contactInfo) {
-        let contactInfoSubmitLogs =
-            authRecipe === "all" && inputName == "email"
-                ? contactInfoSubmitLogsWithEmailChecks
-                : contactInfoSubmitLogsWithoutEmailChecks;
-
         let accountLinkingSupported;
         let coreUrl;
         const appId = randomUUID();

test/end-to-end/passwordless.test.js

@@ -363,7 +363,7 @@ describe("SuperTokens SignUp => Server Error", function () {
     });
 
     after(async function () {
-        await browser.close();
+        await browser?.close();
         await backendHook("after");
     });
 

test/end-to-end/signup.test.js

@@ -40,6 +40,7 @@ import {
     setupCoreApp,
     setupST,
     screenshotOnFailure,
+    isReact16,
 } from "../helpers";
 import { TEST_CLIENT_BASE_URL, SIGN_IN_UP_API, GET_AUTH_URL_API } from "../constants";