Skip to content

Commit 71db6ba

Browse files
deepjyoti30-stdeepjyoti30-st
committed
fix: Webauthn test updates due to changes
1 parent cf1c3c8 commit 71db6ba

File tree

6 files changed

+28
-61
lines changed

6 files changed

+28
-61
lines changed

‎lib/build/webauthnprebuiltui.js‎

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎lib/ts/recipe/webauthn/components/features/signIn/index.tsx‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -127,8 +127,8 @@ const SignInFeatureInner: React.FC<
127127
props.clearError,
128128
props.resetFactorList,
129129
props.onSignInUpSwitcherClick,
130-
isPasskeySupported,
131-
props.showBackButton
130+
props.showBackButton,
131+
isPasskeySupported
132132
)!;
133133

134134
return (

‎test/end-to-end/webauthn.recover_account.test.js‎

Lines changed: 7 additions & 28 deletions
Original file line numberDiff line numberDiff line change
@@ -167,10 +167,7 @@ describe("SuperTokens Webauthn Recover Account", () => {
167167
// Use the token to recover the account
168168
await openRecoveryWithToken(page, "test");
169169

170-
const errorTextContainer = await waitForSTElement(
171-
page,
172-
"[data-supertokens~='passkeyRecoverableErrorContainer']"
173-
);
170+
const errorTextContainer = await waitForSTElement(page, "[data-supertokens~='generalError']");
174171
const errorText = await errorTextContainer.evaluate((el) => el.textContent);
175172
assert.strictEqual(
176173
errorText,
@@ -215,10 +212,7 @@ describe("SuperTokens Webauthn Recover Account", () => {
215212
// Use the token to recover the account
216213
await openRecoveryWithToken(page, "test");
217214

218-
const errorTextContainer = await waitForSTElement(
219-
page,
220-
"[data-supertokens~='passkeyRecoverableErrorContainer']"
221-
);
215+
const errorTextContainer = await waitForSTElement(page, "[data-supertokens~='generalError']");
222216
const errorText = await errorTextContainer.evaluate((el) => el.textContent);
223217
assert.strictEqual(errorText, "Something went wrong, please refresh the page or reach out to support.");
224218

@@ -240,10 +234,7 @@ describe("SuperTokens Webauthn Recover Account", () => {
240234

241235
await submitFormUnsafe(page);
242236

243-
const errorTextContainer = await waitForSTElement(
244-
page,
245-
"[data-supertokens~='passkeyRecoverableErrorContainer']"
246-
);
237+
const errorTextContainer = await waitForSTElement(page, "[data-supertokens~='generalError']");
247238
const errorText = await errorTextContainer.evaluate((el) => el.textContent);
248239
assert.strictEqual(errorText, "Failed to recover account, please try again.");
249240

@@ -265,10 +256,7 @@ describe("SuperTokens Webauthn Recover Account", () => {
265256

266257
await submitFormUnsafe(page);
267258

268-
const errorTextContainer = await waitForSTElement(
269-
page,
270-
"[data-supertokens~='passkeyRecoverableErrorContainer']"
271-
);
259+
const errorTextContainer = await waitForSTElement(page, "[data-supertokens~='generalError']");
272260
const errorText = await errorTextContainer.evaluate((el) => el.textContent);
273261
assert.strictEqual(
274262
errorText,
@@ -293,10 +281,7 @@ describe("SuperTokens Webauthn Recover Account", () => {
293281

294282
await submitFormUnsafe(page);
295283

296-
const errorTextContainer = await waitForSTElement(
297-
page,
298-
"[data-supertokens~='passkeyRecoverableErrorContainer']"
299-
);
284+
const errorTextContainer = await waitForSTElement(page, "[data-supertokens~='generalError']");
300285
const errorText = await errorTextContainer.evaluate((el) => el.textContent);
301286
assert.strictEqual(errorText, "Failed to recover account, please try again.");
302287

@@ -318,10 +303,7 @@ describe("SuperTokens Webauthn Recover Account", () => {
318303

319304
await submitFormUnsafe(page);
320305

321-
const errorTextContainer = await waitForSTElement(
322-
page,
323-
"[data-supertokens~='passkeyRecoverableErrorContainer']"
324-
);
306+
const errorTextContainer = await waitForSTElement(page, "[data-supertokens~='generalError']");
325307
const errorText = await errorTextContainer.evaluate((el) => el.textContent);
326308
assert.strictEqual(errorText, "Invalid authenticator, please try again.");
327309

@@ -344,10 +326,7 @@ describe("SuperTokens Webauthn Recover Account", () => {
344326
await submitFormUnsafe(page);
345327
await new Promise((res) => setTimeout(res, 1000));
346328

347-
const errorTextContainer = await waitForSTElement(
348-
page,
349-
"[data-supertokens~='passkeyRecoverableErrorContainer']"
350-
);
329+
const errorTextContainer = await waitForSTElement(page, "[data-supertokens~='generalError']");
351330
const errorText = await errorTextContainer.evaluate((el) => el.textContent);
352331
assert.strictEqual(
353332
errorText,

‎test/end-to-end/webauthn.recovery_email.test.js‎

Lines changed: 2 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -139,10 +139,7 @@ describe("SuperTokens Webauthn Recovery Email", () => {
139139
const email = await getTestEmail();
140140
await openRecoveryAccountPage(page, email, true);
141141

142-
const errorTextContainer = await waitForSTElement(
143-
page,
144-
"[data-supertokens~='passkeyRecoverableErrorContainer']"
145-
);
142+
const errorTextContainer = await waitForSTElement(page, "[data-supertokens~='generalError']");
146143
const errorText = await errorTextContainer.evaluate((el) => el.textContent);
147144
assert.strictEqual(errorText, "Account Recovery is not allowed, please contact support.");
148145

@@ -157,10 +154,7 @@ describe("SuperTokens Webauthn Recovery Email", () => {
157154
});
158155
const email = await getTestEmail();
159156
await openRecoveryAccountPage(page, email, true);
160-
const errorTextContainer = await waitForSTElement(
161-
page,
162-
"[data-supertokens~='passkeyRecoverableErrorContainer']"
163-
);
157+
const errorTextContainer = await waitForSTElement(page, "[data-supertokens~='generalError']");
164158
const errorText = await errorTextContainer.evaluate((el) => el.textContent);
165159
assert.strictEqual(
166160
errorText,

‎test/end-to-end/webauthn.signin.test.js‎

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,13 @@ describe("SuperTokens Webauthn SignIn", () => {
6060

6161
describe("SignIn test", () => {
6262
it("signup with passkey", async () => {
63+
// Override to enable webauthn support
64+
await page.evaluateOnNewDocument(() => {
65+
localStorage.setItem("overrideWebauthnSupport", "true");
66+
});
67+
6368
await tryWebauthnSignIn(page);
69+
await page.waitForTimeout(3000);
6470

6571
// Most of the sign-in mock is defined in the override for the web
6672
// test server.
@@ -91,7 +97,7 @@ describe("SuperTokens Webauthn SignIn", () => {
9197
localStorage.setItem("webauthnErrorStatus", "FAILED_TO_AUTHENTICATE_USER");
9298
});
9399
await tryWebauthnSignIn(page);
94-
await waitForSTElement(page, "[data-supertokens~='passkeyRecoverableErrorContainer']");
100+
await waitForSTElement(page, "[data-supertokens~='generalError']");
95101

96102
// Remove the error and retry
97103
await page.evaluateOnNewDocument(() => {
@@ -112,7 +118,7 @@ describe("SuperTokens Webauthn SignIn", () => {
112118
localStorage.setItem("webauthnErrorStatus", "FAILED_TO_AUTHENTICATE_USER");
113119
});
114120
await tryWebauthnSignIn(page);
115-
await waitForSTElement(page, "[data-supertokens~='passkeyRecoverableErrorContainer']");
121+
await waitForSTElement(page, "[data-supertokens~='generalError']");
116122

117123
await page.evaluateOnNewDocument(() => {
118124
localStorage.removeItem("webauthnErrorStatus");
@@ -124,10 +130,7 @@ describe("SuperTokens Webauthn SignIn", () => {
124130
localStorage.setItem("webauthnErrorStatus", "WEBAUTHN_NOT_SUPPORTED");
125131
});
126132
await tryWebauthnSignIn(page);
127-
const errorTextContainer = await waitForSTElement(
128-
page,
129-
"[data-supertokens~='passkeyRecoverableErrorContainer']"
130-
);
133+
const errorTextContainer = await waitForSTElement(page, "[data-supertokens~='generalError']");
131134
const errorText = await errorTextContainer.evaluate((el) => el.textContent);
132135
assert.strictEqual(
133136
errorText,
@@ -144,10 +147,7 @@ describe("SuperTokens Webauthn SignIn", () => {
144147
localStorage.setItem("webauthnErrorStatus", "INVALID_OPTIONS_ERROR");
145148
});
146149
await tryWebauthnSignIn(page);
147-
const errorTextContainer = await waitForSTElement(
148-
page,
149-
"[data-supertokens~='passkeyRecoverableErrorContainer']"
150-
);
150+
const errorTextContainer = await waitForSTElement(page, "[data-supertokens~='generalError']");
151151
const errorText = await errorTextContainer.evaluate((el) => el.textContent);
152152
assert.strictEqual(
153153
errorText,
@@ -164,7 +164,7 @@ describe("SuperTokens Webauthn SignIn", () => {
164164
localStorage.setItem("throwWebauthnError", "true");
165165
});
166166
await tryWebauthnSignIn(page);
167-
await waitForSTElement(page, "[data-supertokens~='passkeyRecoverableErrorContainer']");
167+
await waitForSTElement(page, "[data-supertokens~='generalError']");
168168

169169
await page.evaluateOnNewDocument(() => {
170170
localStorage.removeItem("throwWebauthnError");

‎test/end-to-end/webauthn.signup.test.js‎

Lines changed: 4 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -153,10 +153,7 @@ describe("SuperTokens Webauthn SignUp", () => {
153153
await submitFormUnsafe(page);
154154
await page.waitForTimeout(1000);
155155

156-
const errorTextContainer = await waitForSTElement(
157-
page,
158-
"[data-supertokens~='passkeyRecoverableErrorContainer']"
159-
);
156+
const errorTextContainer = await waitForSTElement(page, "[data-supertokens~='generalError']");
160157
const errorText = await errorTextContainer.evaluate((el) => el.textContent);
161158
assert.strictEqual(errorText, "Email already exists, please sign in instead.");
162159

@@ -200,7 +197,7 @@ describe("SuperTokens Webauthn SignUp", () => {
200197
// We should be in the confirmation page now.
201198
await submitFormUnsafe(page);
202199

203-
await waitForSTElement(page, "[data-supertokens~='passkeyRecoverableErrorContainer']");
200+
await waitForSTElement(page, "[data-supertokens~='generalError']");
204201

205202
// Remove the error and retry
206203
await page.evaluateOnNewDocument(() => {
@@ -227,7 +224,7 @@ describe("SuperTokens Webauthn SignUp", () => {
227224
// We should be in the confirmation page now.
228225
await submitFormUnsafe(page);
229226

230-
await waitForSTElement(page, "[data-supertokens~='passkeyRecoverableErrorContainer']");
227+
await waitForSTElement(page, "[data-supertokens~='generalError']");
231228

232229
await page.evaluateOnNewDocument(() => {
233230
localStorage.removeItem("webauthnErrorStatus");
@@ -245,10 +242,7 @@ describe("SuperTokens Webauthn SignUp", () => {
245242
// We should be in the confirmation page now.
246243
await submitFormUnsafe(page);
247244

248-
const errorTextContainer = await waitForSTElement(
249-
page,
250-
"[data-supertokens~='passkeyRecoverableErrorContainer']"
251-
);
245+
const errorTextContainer = await waitForSTElement(page, "[data-supertokens~='generalError']");
252246
const errorText = await errorTextContainer.evaluate((el) => el.textContent);
253247
assert.strictEqual(
254248
errorText,

0 commit comments

Comments
 (0)