update: mfa.factorscreen.totp tests use core apps

Author: namsnath

test/end-to-end/mfa.factorscreen.totp.test.js

@@ -18,43 +18,30 @@
  */
 
 import assert from "assert";
-import puppeteer from "puppeteer";
 import {
     clearBrowserCookiesWithoutAffectingConsole,
-    setInputValues,
-    submitForm,
     waitForSTElement,
     screenshotOnFailure,
-    backendBeforeEach,
     getTestEmail,
-    getPasswordlessDevice,
     waitFor,
-    getFactorChooserOptions,
     isMFASupported,
-    setAccountLinkingConfig,
     waitForUrl,
     setupBrowser,
+    backendHook,
+    setupCoreApp,
+    setupST
 } from "../helpers";
-import fetch from "isomorphic-fetch";
-import { CREATE_CODE_API, CREATE_TOTP_DEVICE_API, MFA_INFO_API } from "../constants";
+import { CREATE_TOTP_DEVICE_API, MFA_INFO_API } from "../constants";
 
-import { TEST_CLIENT_BASE_URL, TEST_SERVER_BASE_URL } from "../constants";
-import { getTestPhoneNumber } from "../exampleTestHelpers";
+import { TEST_CLIENT_BASE_URL } from "../constants";
 import {
-    setMFAInfo,
     tryEmailPasswordSignUp,
     waitForDashboard,
-    completeOTP,
-    setupOTP,
-    logout,
     tryEmailPasswordSignIn,
     chooseFactor,
-    tryPasswordlessSignInUp,
     setupTOTP,
     getTOTPSecret,
     completeTOTP,
-    setupUserWithAllFactors,
-    goToFactorChooser,
     waitForAccessDenied,
     waitForLoadingScreen,
     waitForBlockedScreen,
@@ -67,44 +54,26 @@ describe("SuperTokens SignIn w/ MFA", function () {
     let browser;
     let page;
     let consoleLogs = [];
-    let skipped = false;
+
+    const appConfig = {
+        accountLinkingConfig: {
+            enabled: true,
+            shouldAutoLink: {
+                shouldAutomaticallyLink: true,
+                shouldRequireVerification: false,
+            },
+        },
+    };
 
     before(async function () {
         if (!(await isMFASupported())) {
-            skipped = true;
             this.skip();
-            return;
         }
-        await backendBeforeEach();
-
-        await fetch(`${TEST_SERVER_BASE_URL}/startst`, {
-            method: "POST",
-        }).catch(console.error);
-        await setAccountLinkingConfig(true, true, false);
-
+        await backendHook("before");
         browser = await setupBrowser();
-    });
-
-    after(async function () {
-        if (skipped) {
-            return;
-        }
-        await browser.close();
-
-        await fetch(`${TEST_SERVER_BASE_URL}/after`, {
-            method: "POST",
-        }).catch(console.error);
-
-        await fetch(`${TEST_SERVER_BASE_URL}/stopst`, {
-            method: "POST",
-        }).catch(console.error);
-    });
-
-    afterEach(async function () {
-        await screenshotOnFailure(this, browser);
-        if (page) {
-            await page.close();
-        }
+        const coreUrl = await setupCoreApp();
+        appConfig.coreUrl = coreUrl;
+        await setupST(appConfig);
     });
 
     beforeEach(async function () {
@@ -124,14 +93,27 @@ describe("SuperTokens SignIn w/ MFA", function () {
         await page.evaluate(() => window.localStorage.setItem("enableAllRecipes", "true"));
     });
 
+    afterEach(async function () {
+        await screenshotOnFailure(this, browser);
+        await page?.close();
+        await backendHook("afterEach");
+    });
+
+    after(async function () {
+        await browser?.close();
+        await backendHook("after");
+    });
+
     describe("factor screens", () => {
         describe("totp", () => {
             const factorId = "totp";
 
             let email, phoneNumber;
             before(async () => {
-                await setMFAInfo({
-                    allowedToSetup: ["totp"],
+                await setupST({
+                    mfaInfo: {
+                        allowedToSetup: ["totp"],
+                    }
                 });
                 page = await browser.newPage();
 
@@ -156,10 +138,12 @@ describe("SuperTokens SignIn w/ MFA", function () {
             });
 
             it("should respect redirectToPath", async () => {
-                await setMFAInfo({
-                    requirements: [],
-                    alreadySetup: [factorId],
-                    allowedToSetup: [factorId],
+                await setupST({
+                    mfaInfo: {
+                        requirements: [],
+                        alreadySetup: [factorId],
+                        allowedToSetup: [factorId],
+                    }
                 });
 
                 await tryEmailPasswordSignIn(page, email);
@@ -179,10 +163,12 @@ describe("SuperTokens SignIn w/ MFA", function () {
             });
 
             it("should show access denied if the app navigates to the setup page but the user it is not allowed to set up the factor", async () => {
-                await setMFAInfo({
-                    requirements: [],
-                    alreadySetup: [factorId],
-                    allowedToSetup: [],
+                await setupST({
+                    mfaInfo: {
+                        requirements: [],
+                        alreadySetup: [factorId],
+                        allowedToSetup: [],
+                    }
                 });
 
                 await tryEmailPasswordSignIn(page, email);
@@ -196,10 +182,12 @@ describe("SuperTokens SignIn w/ MFA", function () {
             });
 
             it("should show access denied if setup is not allowed but the factor is not set up", async () => {
-                await setMFAInfo({
-                    requirements: [factorId],
-                    alreadySetup: [],
-                    allowedToSetup: [],
+                await setupST({
+                    mfaInfo: {
+                        requirements: [factorId],
+                        alreadySetup: [],
+                        allowedToSetup: [],
+                    }
                 });
 
                 await tryEmailPasswordSignIn(page, email);
@@ -212,10 +200,12 @@ describe("SuperTokens SignIn w/ MFA", function () {
             });
 
             it("should show loading screen", async () => {
-                await setMFAInfo({
-                    requirements: [factorId],
-                    alreadySetup: [factorId],
-                    allowedToSetup: [],
+                await setupST({
+                    mfaInfo: {
+                        requirements: [factorId],
+                        alreadySetup: [factorId],
+                        allowedToSetup: [],
+                    }
                 });
 
                 await tryEmailPasswordSignIn(page, email);
@@ -243,10 +233,12 @@ describe("SuperTokens SignIn w/ MFA", function () {
             });
 
             it("should show blocked screen after too many retries", async () => {
-                await setMFAInfo({
-                    requirements: [factorId],
-                    alreadySetup: [factorId],
-                    allowedToSetup: [],
+                await setupST({
+                    mfaInfo: {
+                        requirements: [factorId],
+                        alreadySetup: [factorId],
+                        allowedToSetup: [],
+                    }
                 });
 
                 await tryEmailPasswordSignIn(page, email);
@@ -257,10 +249,12 @@ describe("SuperTokens SignIn w/ MFA", function () {
             });
 
             it("should handle mfa info api failures gracefully", async () => {
-                await setMFAInfo({
-                    requirements: [factorId],
-                    alreadySetup: [factorId],
-                    allowedToSetup: [],
+                await setupST({
+                    mfaInfo: {
+                        requirements: [factorId],
+                        alreadySetup: [factorId],
+                        allowedToSetup: [],
+                    }
                 });
 
                 await tryEmailPasswordSignIn(page, email);
@@ -296,10 +290,12 @@ describe("SuperTokens SignIn w/ MFA", function () {
             });
 
             it("should handle createDevice failures gracefully", async () => {
-                await setMFAInfo({
-                    requirements: [factorId],
-                    alreadySetup: [],
-                    allowedToSetup: [factorId],
+                await setupST({
+                    mfaInfo: {
+                        requirements: [factorId],
+                        alreadySetup: [],
+                        allowedToSetup: [factorId],
+                    }
                 });
 
                 await page.setRequestInterception(true);
@@ -330,10 +326,12 @@ describe("SuperTokens SignIn w/ MFA", function () {
             });
 
             it("should redirect back if visited after sign in without stepUp param", async () => {
-                await setMFAInfo({
-                    requirements: [],
-                    alreadySetup: [factorId],
-                    allowedToSetup: [],
+                await setupST({
+                    mfaInfo: {
+                        requirements: [],
+                        alreadySetup: [factorId],
+                        allowedToSetup: [],
+                    }
                 });
 
                 await tryEmailPasswordSignIn(page, email);
@@ -346,10 +344,12 @@ describe("SuperTokens SignIn w/ MFA", function () {
             });
 
             it("should show a link redirecting back if visited after sign in - force setup", async () => {
-                await setMFAInfo({
-                    requirements: [],
-                    alreadySetup: [factorId],
-                    allowedToSetup: [factorId],
+                await setupST({
+                    mfaInfo: {
+                        requirements: [],
+                        alreadySetup: [factorId],
+                        allowedToSetup: [factorId],
+                    }
                 });
 
                 await tryEmailPasswordSignIn(page, email);
@@ -364,10 +364,12 @@ describe("SuperTokens SignIn w/ MFA", function () {
             });
 
             it("should show a link redirecting back if visited after sign in - setup in stepUp", async () => {
-                await setMFAInfo({
-                    requirements: [],
-                    alreadySetup: [],
-                    allowedToSetup: [factorId],
+                await setupST({
+                    mfaInfo: {
+                        requirements: [],
+                        alreadySetup: [],
+                        allowedToSetup: [factorId],
+                    }
                 });
 
                 await tryEmailPasswordSignIn(page, email);
@@ -382,10 +384,12 @@ describe("SuperTokens SignIn w/ MFA", function () {
             });
 
             it("should show a link redirecting back if visited after sign in - verification in stepUp", async () => {
-                await setMFAInfo({
-                    requirements: [],
-                    alreadySetup: [factorId],
-                    allowedToSetup: [],
+                await setupST({
+                    mfaInfo: {
+                        requirements: [],
+                        alreadySetup: [factorId],
+                        allowedToSetup: [],
+                    }
                 });
 
                 await tryEmailPasswordSignIn(page, email);
@@ -400,10 +404,12 @@ describe("SuperTokens SignIn w/ MFA", function () {
             });
 
             it("should show a back button redirecting to the chooser screen if other options are available during sign in - setup", async () => {
-                await setMFAInfo({
-                    requirements: [{ oneOf: [factorId, "otp-email"] }],
-                    alreadySetup: ["otp-email"],
-                    allowedToSetup: [factorId],
+                await setupST({
+                    mfaInfo: {
+                        requirements: [{ oneOf: [factorId, "otp-email"] }],
+                        alreadySetup: ["otp-email"],
+                        allowedToSetup: [factorId],
+                    }
                 });
 
                 await tryEmailPasswordSignIn(page, email);
@@ -419,10 +425,12 @@ describe("SuperTokens SignIn w/ MFA", function () {
             });
 
             it("should show a back button redirecting to the chooser screen if other options are available during sign in - verification", async () => {
-                await setMFAInfo({
-                    requirements: [{ oneOf: [factorId, "otp-email"] }],
-                    alreadySetup: [factorId, "otp-email"],
-                    allowedToSetup: [],
+                await setupST({
+                    mfaInfo: {
+                        requirements: [{ oneOf: [factorId, "otp-email"] }],
+                        alreadySetup: [factorId, "otp-email"],
+                        allowedToSetup: [],
+                    }
                 });
 
                 await tryEmailPasswordSignIn(page, email);
@@ -437,10 +445,12 @@ describe("SuperTokens SignIn w/ MFA", function () {
             });
 
             it("should show a logout link - setup", async () => {
-                await setMFAInfo({
-                    requirements: [factorId],
-                    alreadySetup: [],
-                    allowedToSetup: [factorId],
+                await setupST({
+                    mfaInfo: {
+                        requirements: [factorId],
+                        alreadySetup: [],
+                        allowedToSetup: [factorId],
+                    }
                 });
 
                 await tryEmailPasswordSignIn(page, email);
@@ -456,10 +466,12 @@ describe("SuperTokens SignIn w/ MFA", function () {
             });
 
             it("should show a logout link - verify", async () => {
-                await setMFAInfo({
-                    requirements: [factorId],
-                    alreadySetup: [factorId],
-                    allowedToSetup: [],
+                await setupST({
+                    mfaInfo: {
+                        requirements: [factorId],
+                        alreadySetup: [factorId],
+                        allowedToSetup: [],
+                    }
                 });
 
                 await tryEmailPasswordSignIn(page, email);