update: generalerror tests use core apps

Author: namsnath

test/end-to-end/generalerror.test.js

@@ -40,7 +40,8 @@ import {
     loginWithAuth0,
     isGeneralErrorSupported,
     setGeneralErrorToLocalStorage,
-    backendBeforeEach,
+    backendHook,
+    createCoreApp,
     waitForUrl,
     setupBrowser,
 } from "../helpers";
@@ -57,48 +58,53 @@ import {
     SIGN_IN_UP_API,
 } from "../constants";
 
+let browser;
+let page;
+let consoleLogs;
+
 describe("General error rendering", function () {
     before(async function () {
         const _isGeneralErrorSupported = await isGeneralErrorSupported();
         if (!_isGeneralErrorSupported) {
             this.skip();
         }
-    });
 
-    describe("EmailPassword", function () {
-        getEmailPasswordTests("emailpassword", "EMAIL_PASSWORD");
+        await backendHook("before");
+        browser = await setupBrowser();
     });
 
-    describe("Email verification", function () {
-        let browser;
-        let page;
-        before(async function () {
-            await backendBeforeEach();
-
-            await fetch(`${TEST_SERVER_BASE_URL}/startst`, {
-                method: "POST",
-            }).catch(console.error);
-
-            browser = await setupBrowser();
+    beforeEach(async function () {
+        await backendHook("beforeEach");
+        await createCoreApp();
+        page = await browser.newPage();
+
+        consoleLogs = [];
+        page.on("console", (consoleObj) => {
+            const log = consoleObj.text();
+            if (log.startsWith("ST_LOGS")) {
+                consoleLogs.push(log);
+            }
         });
+        consoleLogs = await clearBrowserCookiesWithoutAffectingConsole(page, consoleLogs);
+    });
 
-        after(async function () {
-            await browser.close();
-            await fetch(`${TEST_SERVER_BASE_URL}/after`, {
-                method: "POST",
-            }).catch(console.error);
-            await fetch(`${TEST_SERVER_BASE_URL}/stopst`, {
-                method: "POST",
-            }).catch(console.error);
-        });
+    afterEach(async function () {
+        await screenshotOnFailure(this, browser);
+        await page?.close();
+        await backendHook("afterEach");
+    });
 
-        afterEach(function () {
-            return screenshotOnFailure(this, browser);
-        });
+    after(async function () {
+        await browser?.close();
+        await backendHook("after");
+    });
+
+    describe("EmailPassword", function () {
+        getEmailPasswordTests("emailpassword", "EMAIL_PASSWORD");
+    });
 
+    describe("Email verification", function () {
         beforeEach(async function () {
-            page = await browser.newPage();
-            await clearBrowserCookiesWithoutAffectingConsole(page, []);
             await page.evaluate(() => localStorage.removeItem("SHOW_GENERAL_ERROR"));
             await Promise.all([
                 page.goto(`${TEST_CLIENT_BASE_URL}/auth?mode=REQUIRED`),
@@ -229,34 +235,7 @@ describe("General error rendering", function () {
 
 function getEmailPasswordTests(rid, ridForStorage) {
     describe("Email Password Tests", function () {
-        let browser;
-        let page;
-        before(async function () {
-            await backendBeforeEach();
-
-            await fetch(`${TEST_SERVER_BASE_URL}/startst`, {
-                method: "POST",
-            }).catch(console.error);
-
-            browser = await setupBrowser();
-        });
-
-        after(async function () {
-            await browser.close();
-            await fetch(`${TEST_SERVER_BASE_URL}/after`, {
-                method: "POST",
-            }).catch(console.error);
-            await fetch(`${TEST_SERVER_BASE_URL}/stopst`, {
-                method: "POST",
-            }).catch(console.error);
-        });
-
-        afterEach(function () {
-            return screenshotOnFailure(this, browser);
-        });
-
         beforeEach(async function () {
-            page = await browser.newPage();
             await Promise.all([
                 page.goto(`${TEST_CLIENT_BASE_URL}/auth?authRecipe=${rid}`),
                 page.waitForNavigation({ waitUntil: "networkidle0" }),
@@ -364,34 +343,7 @@ function getEmailPasswordTests(rid, ridForStorage) {
 
 function getThirdPartyTests(rid, ridForStorage) {
     describe("Third Party Tests", function () {
-        let browser;
-        let page;
-        before(async function () {
-            await backendBeforeEach();
-
-            await fetch(`${TEST_SERVER_BASE_URL}/startst`, {
-                method: "POST",
-            }).catch(console.error);
-
-            browser = await setupBrowser();
-        });
-
-        after(async function () {
-            await browser.close();
-            await fetch(`${TEST_SERVER_BASE_URL}/after`, {
-                method: "POST",
-            }).catch(console.error);
-            await fetch(`${TEST_SERVER_BASE_URL}/stopst`, {
-                method: "POST",
-            }).catch(console.error);
-        });
-
-        afterEach(function () {
-            return screenshotOnFailure(this, browser);
-        });
-
         beforeEach(async function () {
-            page = await browser.newPage();
             await page.goto(`${TEST_CLIENT_BASE_URL}/auth?authRecipe=${rid}`);
             await page.evaluate(() => localStorage.removeItem("SHOW_GENERAL_ERROR"));
         });