fix: factorChooser issues and tenant interactions race condition

Author: deepjyoti30-st

test/end-to-end/mfa.chooserscreen.test.js

@@ -256,7 +256,7 @@ describe("SuperTokens SignIn w/ MFA", function () {
             await chooseFactor(page, "otp-phone");
             await completeOTP(page);
 
-            await goToFactorChooser(page);
+            await goToFactorChooser(page, true, false);
 
             await waitForSTElement(page, "[data-supertokens~=backButton]");
         });

test/end-to-end/mfa.helpers.js

@@ -191,10 +191,16 @@ export async function tryPasswordlessSignInUp(page, contactInfo, queryParams) {
     await submitForm(page);
     await new Promise((res) => setTimeout(res, 1000));
 }
-export async function goToFactorChooser(page, waitForList = true) {
+export async function goToFactorChooser(page, waitForList = true, waitForNetworkIdle = true) {
     const ele = await page.waitForSelector(".goToFactorChooser");
-    await waitFor(100);
-    await Promise.all([page.waitForNavigation({ waitUntil: "networkidle0" }), ele.click()]);
+    await waitFor(waitForNetworkIdle ? 100 : 1000);
+    const steps = [ele.click()];
+    if (waitForNetworkIdle) {
+        // Insert at the start of the array
+        steps.unshift(page.waitForNavigation({ waitUntil: "networkidle0" }));
+    }
+
+    await Promise.all(steps);
     if (waitForList) {
         await waitForSTElement(page, "[data-supertokens~=factorChooserList]");
     }

test/end-to-end/mfa.requirement_handling.test.js

@@ -124,7 +124,7 @@ describe("SuperTokens SignIn w/ MFA", function () {
 
             await tryEmailPasswordSignUp(page, email);
             await waitForDashboard(page);
-            await goToFactorChooser(page);
+            await goToFactorChooser(page, true, false);
             await chooseFactor(page, "otp-email");
             await completeOTP(page);
             await setupOTP(page, "PHONE", phoneNumber);

test/end-to-end/multitenancy.tenant_interactions.test.js

@@ -647,6 +647,11 @@ describe("SuperTokens Multitenancy tenant interactions", function () {
 
             await removeTenant("customer1");
 
+            // We need to wait for a while so that the login_methods
+            // endpoint doesn't crash. Essentially, it seems like the core
+            // take a few seconds to update.
+            await page.waitForTimeout(3000);
+
             let getDynamicLoginMethodsCalled = false;
             await page.setRequestInterception(true);
             const requestHandler = (request) => {