Skip to content

Commit bab5144

Browse files
authored
test: add missing skips for closing the browser (#804)
* test: update tests to fix CI * test: add more missing var declarations * test: fix missing skip condition * refactor: rework how we get session payload for newSessionCreated * test: add missing skips for closing the browser
1 parent 528958f commit bab5144

File tree

2 files changed

+6
-2
lines changed

2 files changed

+6
-2
lines changed

test/end-to-end/mfa.chooserscreen.test.js

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -87,7 +87,9 @@ describe("SuperTokens SignIn w/ MFA", function () {
8787
});
8888

8989
after(async function () {
90-
await browser.close();
90+
if (!skipped) {
91+
await browser.close();
92+
}
9193

9294
await fetch(`${TEST_SERVER_BASE_URL}/after`, {
9395
method: "POST",

test/end-to-end/mfa.factorscreen.totp.test.js

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -88,7 +88,9 @@ describe("SuperTokens SignIn w/ MFA", function () {
8888
});
8989

9090
after(async function () {
91-
await browser.close();
91+
if (skipped) {
92+
await browser.close();
93+
}
9294

9395
await fetch(`${TEST_SERVER_BASE_URL}/after`, {
9496
method: "POST",

0 commit comments

Comments
 (0)