Skip to content

Commit f28cd4c

Browse files
authored
test: fix mfa tests (#805)
1 parent 9e0916d commit f28cd4c

File tree

5 files changed

+21
-6
lines changed

5 files changed

+21
-6
lines changed

test/end-to-end/mfa.chooserscreen.test.js

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -87,9 +87,10 @@ describe("SuperTokens SignIn w/ MFA", function () {
8787
});
8888

8989
after(async function () {
90-
if (!skipped) {
91-
await browser.close();
90+
if (skipped) {
91+
return;
9292
}
93+
await browser.close();
9394

9495
await fetch(`${TEST_SERVER_BASE_URL}/after`, {
9596
method: "POST",

test/end-to-end/mfa.factorscreen.otp.test.js

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -88,6 +88,9 @@ describe("SuperTokens SignIn w/ MFA", function () {
8888
});
8989

9090
after(async function () {
91+
if (skipped) {
92+
return;
93+
}
9194
await browser.close();
9295

9396
await fetch(`${TEST_SERVER_BASE_URL}/after`, {

test/end-to-end/mfa.factorscreen.totp.test.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -89,8 +89,9 @@ describe("SuperTokens SignIn w/ MFA", function () {
8989

9090
after(async function () {
9191
if (skipped) {
92-
await browser.close();
92+
return;
9393
}
94+
await browser.close();
9495

9596
await fetch(`${TEST_SERVER_BASE_URL}/after`, {
9697
method: "POST",

test/end-to-end/mfa.requirement_handling.test.js

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -31,6 +31,7 @@ import {
3131
waitFor,
3232
getFactorChooserOptions,
3333
setAccountLinkingConfig,
34+
isMFASupported,
3435
} from "../helpers";
3536
import fetch from "isomorphic-fetch";
3637
import { CREATE_CODE_API, CREATE_TOTP_DEVICE_API, MFA_INFO_API } from "../constants";
@@ -64,8 +65,14 @@ describe("SuperTokens SignIn w/ MFA", function () {
6465
let browser;
6566
let page;
6667
let consoleLogs = [];
68+
let skipped;
6769

6870
before(async function () {
71+
if (!(await isMFASupported())) {
72+
skipped = true;
73+
this.skip();
74+
return;
75+
}
6976
await backendBeforeEach();
7077

7178
await fetch(`${TEST_SERVER_BASE_URL}/startst`, {
@@ -79,6 +86,9 @@ describe("SuperTokens SignIn w/ MFA", function () {
7986
});
8087

8188
after(async function () {
89+
if (skipped) {
90+
return;
91+
}
8292
await browser.close();
8393

8494
await fetch(`${TEST_SERVER_BASE_URL}/after`, {

test/server/package-lock.json

Lines changed: 3 additions & 3 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)