feat(multifactorauth): add getSecondaryFactors to multifactor recipe method and enhance error handling for plugin version mismatches and duplicates

Author: niftyvictor

lib/build/genericComponentOverrideContext.js

@@ -87,13 +87,20 @@ export default class Wrapper {
         });
     }
 
+    static getSecondaryFactors(input: { userContext?: UserContext }) {
+        return MultiFactorAuthRecipe.getInstanceOrThrow().getSecondaryFactors(
+            getNormalisedUserContext(input.userContext)
+        );
+    }
+
     static ComponentsOverrideProvider = RecipeComponentsOverrideContextProvider;
 }
 
 const init = Wrapper.init;
 const resyncSessionAndFetchMFAInfo = Wrapper.resyncSessionAndFetchMFAInfo;
 const redirectToFactor = Wrapper.redirectToFactor;
 const redirectToFactorChooser = Wrapper.redirectToFactorChooser;
+const getSecondaryFactors = Wrapper.getSecondaryFactors;
 const MultiFactorAuthComponentsOverrideProvider = Wrapper.ComponentsOverrideProvider;
 const MultiFactorAuthClaim = MultiFactorAuthRecipe.MultiFactorAuthClaim;
 
@@ -102,6 +109,7 @@ export {
     resyncSessionAndFetchMFAInfo,
     redirectToFactor,
     redirectToFactorChooser,
+    getSecondaryFactors,
     MultiFactorAuthComponentsOverrideProvider,
     GetRedirectionURLContext,
     PreAPIHookContext as PreAPIHookContext,

lib/build/multifactorauth.js

@@ -110,11 +110,6 @@ export default class SessionAPIWrapper {
     }
 
     static ComponentsOverrideProvider = RecipeComponentsOverrideContextProvider;
-
-    // todo add exports like this to all recipes
-    // static internal = {
-    //     getInstanceOrThrow: Session.getInstanceOrThrow.bind(Session),
-    // };
 }
 
 const useSessionContext = SessionAPIWrapper.useSessionContext;

lib/build/recipe/multifactorauth/index.d.ts

@@ -121,7 +121,6 @@ export default class Wrapper {
         });
     }
 
-    // todo figure out how to make use of dynamic providers
     static getProviders(): { id: string; name: string }[] {
         return ThirdParty.getInstanceOrThrow().config.signInAndUpFeature.providers.map((provider) => ({
             id: provider.id,

lib/build/thirdparty.js

@@ -213,7 +213,11 @@ export default class SuperTokens {
                         : [plugin.compatibleAuthReactSDKVersions];
                     if (!versionContraints.includes(package_version)) {
                         // TODO: better checks
-                        throw new Error("Plugin version mismatch");
+                        throw new Error(
+                            `Plugin version mismatch. Version ${package_version} not found in compatible versions: ${versionContraints.join(
+                                ", "
+                            )}`
+                        );
                     }
                 }
                 if (plugin.dependencies) {
@@ -233,6 +237,13 @@ export default class SuperTokens {
             }
         }
 
+        const duplicatePluginIds = finalPluginList.filter((plugin, index) =>
+            finalPluginList.some((elem, idx) => elem.id === plugin.id && idx !== index)
+        );
+        if (duplicatePluginIds.length > 0) {
+            throw new Error(`Duplicate plugin IDs: ${duplicatePluginIds.map((plugin) => plugin.id).join(", ")}`);
+        }
+
         for (const plugin of finalPluginList) {
             if (plugin.config) {
                 // prevent override of appInfo

lib/ts/recipe/multifactorauth/index.ts

@@ -524,7 +524,7 @@ export type PluginRouteHandler = {
 
 // TODO: this should probably derive from the web-js version
 export type SuperTokensPlugin = {
-    id: string; // TODO: validate that no two plugins have the same id
+    id: string;
     version?: string;
     compatibleAuthReactSDKVersions?: string | string[]; // match the syntax of the engines field in package.json
     compatibleWebJSSDKVersions?: string | string[]; // match the syntax of the engines field in package.json