Add tests and cleanup for recovery with token

deepjyoti30-st · deepjyoti30-st · commit ffa8a0723c99 · 2025-02-12T15:02:49.000+05:30
diff --git a/examples/for-tests-react-16/src/App.js b/examples/for-tests-react-16/src/App.js
@@ -890,7 +890,7 @@ function getThirdPartyConfigs({ staticProviderList, disableDefaultUI, thirdParty
     });
 }
 
-function getWebauthnConfigs({ throwWebauthnError, webauthnErrorStatus }) {
+function getWebauthnConfigs({ throwWebauthnError, webauthnErrorStatus, webauthnRecoverAccountErrorStatus }) {
     return Webauthn.init({
         style: `          
             [data-supertokens~=container] {
@@ -1043,6 +1043,18 @@ function getWebauthnConfigs({ throwWebauthnError, webauthnErrorStatus }) {
 
                         return implementation.generateRecoverAccountToken(...args);
                     },
+                    recoverAccount(...args) {
+                        log(`RECOVER ACCOUNT`);
+
+                        // Return error status if the user passed that.
+                        if (webauthnRecoverAccountErrorStatus) {
+                            return {
+                                status: webauthnRecoverAccountErrorStatus,
+                            };
+                        }
+
+                        return implementation.recoverAccount(...args);
+                    },
                 };
             },
         },
diff --git a/examples/for-tests-react-16/src/testContext.js b/examples/for-tests-react-16/src/testContext.js
@@ -26,6 +26,7 @@ export function getTestContext() {
             localStorage.getItem("disableRedirectionAfterSuccessfulSignInUp") === "true",
         throwWebauthnError: localStorage.getItem("throwWebauthnError") === "true",
         webauthnErrorStatus: localStorage.getItem("webauthnErrorStatus") || undefined,
+        webauthnRecoverAccountErrorStatus: localStorage.getItem("webauthnRecoverAccountErrorStatus") || undefined,
     };
     return ret;
 }
diff --git a/examples/for-tests/src/App.js b/examples/for-tests/src/App.js
@@ -1152,7 +1152,7 @@ function setIsNewUserToStorage(recipeName, isNewRecipeUser) {
     localStorage.setItem("isNewUserCheck", `${recipeName}-${isNewRecipeUser}`);
 }
 
-function getWebauthnConfigs({ throwWebauthnError, webauthnErrorStatus }) {
+function getWebauthnConfigs({ throwWebauthnError, webauthnErrorStatus, webauthnRecoverAccountErrorStatus }) {
     return Webauthn.init({
         override: {
             functions: (implementation) => {
@@ -1167,13 +1167,6 @@ function getWebauthnConfigs({ throwWebauthnError, webauthnErrorStatus }) {
                             throw new STGeneralError("TEST ERROR");
                         }
 
-                        // Return error status if the user passed that.
-                        if (webauthnErrorStatus) {
-                            return {
-                                status: webauthnErrorStatus,
-                            };
-                        }
-
                         return implementation.getRegisterOptions(...args);
                     },
                     async getSignInOptions(...args) {
@@ -1312,6 +1305,18 @@ function getWebauthnConfigs({ throwWebauthnError, webauthnErrorStatus }) {
 
                         return implementation.generateRecoverAccountToken(...args);
                     },
+                    recoverAccount(...args) {
+                        log(`RECOVER ACCOUNT`);
+
+                        // Return error status if the user passed that.
+                        if (webauthnRecoverAccountErrorStatus) {
+                            return {
+                                status: webauthnRecoverAccountErrorStatus,
+                            };
+                        }
+
+                        return implementation.recoverAccount(...args);
+                    },
                 };
             },
         },
diff --git a/examples/for-tests/src/testContext.js b/examples/for-tests/src/testContext.js
@@ -27,6 +27,7 @@ export function getTestContext() {
             localStorage.getItem("disableRedirectionAfterSuccessfulSignInUp") === "true",
         throwWebauthnError: localStorage.getItem("throwWebauthnError") === "true",
         webauthnErrorStatus: localStorage.getItem("webauthnErrorStatus") || undefined,
+        webauthnRecoverAccountErrorStatus: localStorage.getItem("webauthnRecoverAccountErrorStatus") || undefined,
     };
     return ret;
 }
diff --git a/test/end-to-end/webauthn.recover_account.test.js b/test/end-to-end/webauthn.recover_account.test.js
@@ -158,6 +158,7 @@ describe("SuperTokens Webauthn Recover Account", () => {
                 "ST_LOGS WEBAUTHN PRE_API_HOOKS REGISTER_OPTIONS",
                 "ST_LOGS WEBAUTHN PRE_API_HOOKS REGISTER_OPTIONS",
                 "ST_LOGS WEBAUTHN OVERRIDE REGISTER CREDENTIAL",
+                "ST_LOGS WEBAUTHN OVERRIDE RECOVER ACCOUNT",
                 "ST_LOGS WEBAUTHN PRE_API_HOOKS RECOVER_ACCOUNT",
                 "ST_LOGS SUPERTOKENS GET_REDIRECTION_URL TO_AUTH",
                 "ST_LOGS SESSION OVERRIDE ADD_FETCH_INTERCEPTORS_AND_RETURN_MODIFIED_FETCH",
@@ -227,5 +228,112 @@ describe("SuperTokens Webauthn Recover Account", () => {
                 localStorage.setItem("throwWebauthnError", undefined);
             });
         });
+        it("should show error when generated options are invalid", async () => {
+            // Set the error to be thrown
+            await page.evaluateOnNewDocument(() => {
+                localStorage.setItem("webauthnRecoverAccountErrorStatus", "INVALID_GENERATED_OPTIONS_ERROR");
+            });
+
+            // Use the token to recover the account
+            // Get the token from the email
+            const token = await getTokenFromEmail(email);
+            assert.ok(token);
+            assert.strictEqual(token.length, 128);
+            await openRecoveryWithToken(page, token);
+
+            await submitForm(page);
+
+            const errorTextContainer = await waitForSTElement(
+                page,
+                "[data-supertokens~='passkeyRecoverableErrorContainer']"
+            );
+            const errorText = await errorTextContainer.evaluate((el) => el.textContent);
+            assert.strictEqual(errorText, "Failed to recover account, please try again.");
+
+            await page.evaluateOnNewDocument(() => {
+                localStorage.setItem("webauthnRecoverAccountErrorStatus", undefined);
+            });
+        });
+        it("should show error when credentials are invalid", async () => {
+            // Set the error to be thrown
+            await page.evaluateOnNewDocument(() => {
+                localStorage.setItem("webauthnRecoverAccountErrorStatus", "INVALID_CREDENTIALS_ERROR");
+            });
+
+            // Use the token to recover the account
+            // Get the token from the email
+            const token = await getTokenFromEmail(email);
+            assert.ok(token);
+            assert.strictEqual(token.length, 128);
+            await openRecoveryWithToken(page, token);
+
+            await submitForm(page);
+
+            const errorTextContainer = await waitForSTElement(
+                page,
+                "[data-supertokens~='passkeyRecoverableErrorContainer']"
+            );
+            const errorText = await errorTextContainer.evaluate((el) => el.textContent);
+            assert.strictEqual(
+                errorText,
+                "The passkey is invalid, please try again, possibly with a different device."
+            );
+
+            await page.evaluateOnNewDocument(() => {
+                localStorage.setItem("webauthnRecoverAccountErrorStatus", undefined);
+            });
+        });
+        it("should show error when generated options are not found", async () => {
+            // Set the error to be thrown
+            await page.evaluateOnNewDocument(() => {
+                localStorage.setItem("webauthnRecoverAccountErrorStatus", "GENERATED_OPTIONS_NOT_FOUND_ERROR");
+            });
+
+            // Use the token to recover the account
+            // Get the token from the email
+            const token = await getTokenFromEmail(email);
+            assert.ok(token);
+            assert.strictEqual(token.length, 128);
+            await openRecoveryWithToken(page, token);
+
+            await submitForm(page);
+
+            const errorTextContainer = await waitForSTElement(
+                page,
+                "[data-supertokens~='passkeyRecoverableErrorContainer']"
+            );
+            const errorText = await errorTextContainer.evaluate((el) => el.textContent);
+            assert.strictEqual(errorText, "Failed to recover account, please try again.");
+
+            await page.evaluateOnNewDocument(() => {
+                localStorage.setItem("webauthnRecoverAccountErrorStatus", undefined);
+            });
+        });
+        it("should show error when authenticator is invalid", async () => {
+            // Set the error to be thrown
+            await page.evaluateOnNewDocument(() => {
+                localStorage.setItem("webauthnRecoverAccountErrorStatus", "INVALID_AUTHENTICATOR_ERROR");
+            });
+
+            // Use the token to recover the account
+            // Get the token from the email
+            const token = await getTokenFromEmail(email);
+            assert.ok(token);
+            assert.strictEqual(token.length, 128);
+            await openRecoveryWithToken(page, token);
+
+            await submitForm(page);
+
+            const errorTextContainer = await waitForSTElement(
+                page,
+                "[data-supertokens~='passkeyRecoverableErrorContainer']"
+            );
+            const errorText = await errorTextContainer.evaluate((el) => el.textContent);
+            assert.strictEqual(errorText, "Invalid authenticator, please try again.");
+
+            await page.evaluateOnNewDocument(() => {
+                localStorage.setItem("webauthnRecoverAccountErrorStatus", undefined);
+            });
+        });
     });
 });

Original file line number	Diff line number	Diff line change
`@@ -26,6 +26,7 @@ export function getTestContext() {`
`26`	`26`	`localStorage.getItem("disableRedirectionAfterSuccessfulSignInUp") === "true",`
`27`	`27`	`throwWebauthnError: localStorage.getItem("throwWebauthnError") === "true",`
`28`	`28`	`webauthnErrorStatus: localStorage.getItem("webauthnErrorStatus") \|\| undefined,`
	`29`	`+ webauthnRecoverAccountErrorStatus: localStorage.getItem("webauthnRecoverAccountErrorStatus") \|\| undefined,`
`29`	`30`	`};`
`30`	`31`	`return ret;`
`31`	`32`	`}`
Original file line number	Diff line number	Diff line change
`@@ -27,6 +27,7 @@ export function getTestContext() {`
`27`	`27`	`localStorage.getItem("disableRedirectionAfterSuccessfulSignInUp") === "true",`
`28`	`28`	`throwWebauthnError: localStorage.getItem("throwWebauthnError") === "true",`
`29`	`29`	`webauthnErrorStatus: localStorage.getItem("webauthnErrorStatus") \|\| undefined,`
	`30`	`+ webauthnRecoverAccountErrorStatus: localStorage.getItem("webauthnRecoverAccountErrorStatus") \|\| undefined,`
`30`	`31`	`};`
`31`	`32`	`return ret;`
`32`	`33`	`}`