test: thirdparty json (#860)

Author: sattvikc

src/test/java/io/supertokens/test/multitenant/api/TestMultitenancyAPIHelper.java

@@ -17,6 +17,7 @@
 package io.supertokens.test.multitenant.api;
 
 import com.google.gson.Gson;
+import com.google.gson.GsonBuilder;
 import com.google.gson.JsonObject;
 import io.supertokens.Main;
 import io.supertokens.pluginInterface.multitenancy.TenantIdentifier;
@@ -234,9 +235,8 @@ public static JsonObject addOrUpdateThirdPartyProviderConfig(TenantIdentifier te
 
     public static JsonObject addOrUpdateThirdPartyProviderConfig(TenantIdentifier tenantIdentifier, ThirdPartyConfig.Provider provider, boolean skipValidation, Main main)
             throws HttpResponseException, IOException {
-        Gson gson = new Gson();
         JsonObject requestBody = new JsonObject();
-        JsonObject tpConfig = gson.toJsonTree(provider).getAsJsonObject();
+        JsonObject tpConfig = provider.toJson();
         requestBody.add("config", tpConfig);
         requestBody.addProperty("skipValidation", skipValidation);
 

src/test/java/io/supertokens/test/multitenant/api/TestThirdPartyProvider.java

@@ -17,6 +17,7 @@
 package io.supertokens.test.multitenant.api;
 
 import com.google.gson.Gson;
+import com.google.gson.GsonBuilder;
 import com.google.gson.JsonObject;
 import io.supertokens.ProcessState;
 import io.supertokens.featureflag.EE_FEATURES;
@@ -40,6 +41,8 @@
 import org.junit.Test;
 
 import java.io.IOException;
+import java.util.HashMap;
+import java.util.Map;
 
 import static org.junit.Assert.*;
 
@@ -106,6 +109,44 @@ public void testAddThirdPartyConfig() throws Exception {
         assertEquals(new Gson().toJsonTree(provider), resultProvider);
     }
 
+    @Test
+    public void testAddThirdPartyConfigWithNullValues() throws Exception {
+        if (StorageLayer.getStorage(process.getProcess()).getType() != STORAGE_TYPE.SQL) {
+            return;
+        }
+
+        JsonObject objWithNulls = new JsonObject();
+        objWithNulls.addProperty("key1", "value");
+        objWithNulls.add("key2", null);
+
+        ThirdPartyConfig.Provider provider = new ThirdPartyConfig.Provider(
+                "google",
+                "Google",
+                null,
+                null,
+                objWithNulls,
+                null,
+                objWithNulls,
+                null,
+                objWithNulls,
+                objWithNulls,
+                null,
+                null,
+                null,
+                null
+        );
+        JsonObject response = TestMultitenancyAPIHelper.addOrUpdateThirdPartyProviderConfig(
+                new TenantIdentifier(null, null, null),
+                provider,
+                process.getProcess()
+        );
+        assertTrue(response.get("createdNew").getAsBoolean());
+
+        response = TestMultitenancyAPIHelper.getTenant(new TenantIdentifier(null, null, null), process.getProcess());
+        JsonObject resultProvider = response.get("thirdParty").getAsJsonObject().get("providers").getAsJsonArray().get(0).getAsJsonObject();
+        assertEquals(provider.toJson(), resultProvider);
+    }
+
     @Test
     public void testUpdateThirdPartyConfig() throws Exception {
         if (StorageLayer.getStorage(process.getProcess()).getType() != STORAGE_TYPE.SQL) {