Merge pull request #219 from supertokens/dashboard-api-issue

rishabhpoddar · web-flow · commit 079f8f93c2ca · 2022-12-26T11:51:45.000+05:30
fix: fixes newPassword validation
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -6,6 +6,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
 ## [unreleased]
+-   Fixes `newPassword` validation in Dashboard API
 
 ## [0.9.11]
 -   Fixes panic issue with dashboard usersGet API
diff --git a/recipe/dashboard/api/userdetails/userPasswordPut.go b/recipe/dashboard/api/userdetails/userPasswordPut.go
@@ -91,7 +91,7 @@ func UserPasswordPut(apiInterface dashboardmodels.APIInterface, options dashboar
 			}
 		}
 
-		validationError := passwordField.Validate(readBody.NewPassword)
+		validationError := passwordField.Validate(*readBody.NewPassword)
 
 		if validationError != nil {
 			return userPasswordPutResponse{
@@ -134,7 +134,7 @@ func UserPasswordPut(apiInterface dashboardmodels.APIInterface, options dashboar
 		}
 	}
 
-	validationError := passwordField.Validate(readBody.NewPassword)
+	validationError := passwordField.Validate(*readBody.NewPassword)
 
 	if validationError != nil {
 		return userPasswordPutResponse{

Original file line number	Diff line number	Diff line change
`@@ -91,7 +91,7 @@ func UserPasswordPut(apiInterface dashboardmodels.APIInterface, options dashboar`
`91`	`91`	`}`
`92`	`92`	`}`
`93`	`93`
`94`		`- validationError := passwordField.Validate(readBody.NewPassword)`
	`94`	`+ validationError := passwordField.Validate(*readBody.NewPassword)`
`95`	`95`
`96`	`96`	`if validationError != nil {`
`97`	`97`	`return userPasswordPutResponse{`
`@@ -134,7 +134,7 @@ func UserPasswordPut(apiInterface dashboardmodels.APIInterface, options dashboar`
`134`	`134`	`}`
`135`	`135`	`}`
`136`	`136`
`137`		`- validationError := passwordField.Validate(readBody.NewPassword)`
	`137`	`+ validationError := passwordField.Validate(*readBody.NewPassword)`
`138`	`138`
`139`	`139`	`if validationError != nil {`
`140`	`140`	`return userPasswordPutResponse{`