fix: postinit callbacks

sattvikc · sattvikc · commit 2954c7499942 · 2022-09-01T15:06:21.000+05:30
diff --git a/recipe/thirdparty/recipe.go b/recipe/thirdparty/recipe.go
@@ -57,11 +57,12 @@ func MakeRecipe(recipeId string, appInfo supertokens.NormalisedAppinfo, config *
 	r.RecipeImpl = verifiedConfig.Override.Functions(MakeRecipeImplementation(*querierInstance))
 	r.Providers = config.SignInAndUpFeature.Providers
 
-	supertokens.AddPostInitCallback(func() {
+	supertokens.AddPostInitCallback(func() error {
 		evRecipe := emailverification.GetRecipeInstance()
 		if evRecipe != nil {
 			evRecipe.AddGetEmailForUserIdFunc(r.getEmailForUserId)
 		}
+		return nil
 	})
 
 	return *r, nil
diff --git a/recipe/thirdparty/tp_userIdMapping_test.go b/recipe/thirdparty/tp_userIdMapping_test.go
@@ -50,7 +50,7 @@ func TestCreateUserIdMappingUsingEmail(t *testing.T) {
 		return
 	}
 
-	signUpResponse, err := SignInUp("google", "googleID", tpmodels.EmailStruct{ID: "test@example.com"})
+	signUpResponse, err := SignInUp("google", "googleID", "test@example.com")
 	assert.NoError(t, err)
 
 	externalUserId := "externalId"
diff --git a/recipe/thirdpartyemailpassword/recipe.go b/recipe/thirdpartyemailpassword/recipe.go
@@ -125,11 +125,12 @@ func MakeRecipe(recipeId string, appInfo supertokens.NormalisedAppinfo, config *
 		}
 	}
 
-	supertokens.AddPostInitCallback(func() {
+	supertokens.AddPostInitCallback(func() error {
 		evRecipe := emailverification.GetRecipeInstance()
 		if evRecipe != nil {
 			evRecipe.AddGetEmailForUserIdFunc(r.getEmailForUserId)
 		}
+		return nil
 	})
 
 	return *r, nil
diff --git a/recipe/thirdpartyemailpassword/tpep_userIdMapping_test.go b/recipe/thirdpartyemailpassword/tpep_userIdMapping_test.go
@@ -50,7 +50,7 @@ func TestCreateUserIdMappingUsingEmail(t *testing.T) {
 		return
 	}
 
-	signUpResponse, err := ThirdPartySignInUp("google", "googleID", tpepmodels.EmailStruct{ID: "test@example.com"})
+	signUpResponse, err := ThirdPartySignInUp("google", "googleID", "test@example.com")
 	assert.NoError(t, err)
 
 	externalUserId := "externalId"
diff --git a/recipe/thirdpartypasswordless/recipe.go b/recipe/thirdpartypasswordless/recipe.go
@@ -135,11 +135,12 @@ func MakeRecipe(recipeId string, appInfo supertokens.NormalisedAppinfo, config t
 		}
 	}
 
-	supertokens.AddPostInitCallback(func() {
+	supertokens.AddPostInitCallback(func() error {
 		evRecipe := emailverification.GetRecipeInstance()
 		if evRecipe != nil {
 			evRecipe.AddGetEmailForUserIdFunc(r.getEmailForUserId)
 		}
+		return nil
 	})
 
 	return *r, nil
diff --git a/recipe/thirdpartypasswordless/tpl_userIdMapping_test.go b/recipe/thirdpartypasswordless/tpl_userIdMapping_test.go
@@ -55,7 +55,7 @@ func TestCreateUserIdMappingUsingEmail(t *testing.T) {
 		return
 	}
 
-	signUpResponse, err := ThirdPartySignInUp("google", "googleID", tplmodels.EmailStruct{ID: "test@example.com"})
+	signUpResponse, err := ThirdPartySignInUp("google", "googleID", "test@example.com")
 	assert.NoError(t, err)
 
 	externalUserId := "externalId"

Original file line number	Diff line number	Diff line change
`@@ -50,7 +50,7 @@ func TestCreateUserIdMappingUsingEmail(t *testing.T) {`
`50`	`50`	`return`
`51`	`51`	`}`
`52`	`52`
`53`		`- signUpResponse, err := SignInUp("google", "googleID", tpmodels.EmailStruct{ID: "[email protected]"})`
	`53`	`+ signUpResponse, err := SignInUp("google", "googleID", "[email protected]")`
`54`	`54`	`assert.NoError(t, err)`
`55`	`55`
`56`	`56`	`externalUserId := "externalId"`
Original file line number	Diff line number	Diff line change
`@@ -125,11 +125,12 @@ func MakeRecipe(recipeId string, appInfo supertokens.NormalisedAppinfo, config *`
`125`	`125`	`}`
`126`	`126`	`}`
`127`	`127`
`128`		`- supertokens.AddPostInitCallback(func() {`
	`128`	`+ supertokens.AddPostInitCallback(func() error {`
`129`	`129`	`evRecipe := emailverification.GetRecipeInstance()`
`130`	`130`	`if evRecipe != nil {`
`131`	`131`	`evRecipe.AddGetEmailForUserIdFunc(r.getEmailForUserId)`
`132`	`132`	`}`
	`133`	`+ return nil`
`133`	`134`	`})`
`134`	`135`
`135`	`136`	`return *r, nil`
Original file line number	Diff line number	Diff line change
`@@ -135,11 +135,12 @@ func MakeRecipe(recipeId string, appInfo supertokens.NormalisedAppinfo, config t`
`135`	`135`	`}`
`136`	`136`	`}`
`137`	`137`
`138`		`- supertokens.AddPostInitCallback(func() {`
	`138`	`+ supertokens.AddPostInitCallback(func() error {`
`139`	`139`	`evRecipe := emailverification.GetRecipeInstance()`
`140`	`140`	`if evRecipe != nil {`
`141`	`141`	`evRecipe.AddGetEmailForUserIdFunc(r.getEmailForUserId)`
`142`	`142`	`}`
	`143`	`+ return nil`
`143`	`144`	`})`
`144`	`145`
`145`	`146`	`return *r, nil`
Original file line number	Diff line number	Diff line change
`@@ -55,7 +55,7 @@ func TestCreateUserIdMappingUsingEmail(t *testing.T) {`
`55`	`55`	`return`
`56`	`56`	`}`
`57`	`57`
`58`		`- signUpResponse, err := ThirdPartySignInUp("google", "googleID", tplmodels.EmailStruct{ID: "[email protected]"})`
	`58`	`+ signUpResponse, err := ThirdPartySignInUp("google", "googleID", "[email protected]")`
`59`	`59`	`assert.NoError(t, err)`
`60`	`60`
`61`	`61`	`externalUserId := "externalId"`