Refactor based on PR comments

Author: nkshah2

recipe/dashboard/api/signInPost.go

@@ -57,9 +57,9 @@ func SignInPost(apiInterface dashboardmodels.APIInterface, options dashboardmode
 		return apiErr
 	}
 
-	status, ok := apiResponse["status"]
+	status := apiResponse["status"]
 
-	if ok && status == "OK" {
+	if status == "OK" {
 		return supertokens.Send200Response(options.Res, map[string]interface{}{
 			"status":    "OK",
 			"sessionId": apiResponse["sessionId"].(string),

recipe/dashboard/api/signOutPost.go

@@ -11,7 +11,7 @@ type signOutPostResponse struct {
 }
 
 func SignOutPost(apiInterface dashboardmodels.APIInterface, options dashboardmodels.APIOptions) (signOutPostResponse, error) {
-	if options.Config.ApiKey != "" {
+	if options.Config.AuthMode == dashboardmodels.AuthModeAPIKey {
 		return signOutPostResponse{
 			Status: "OK",
 		}, nil

recipe/dashboard/utils.go

@@ -26,17 +26,22 @@ import (
 func validateAndNormaliseUserInput(appInfo supertokens.NormalisedAppinfo, config *dashboardmodels.TypeInput) dashboardmodels.TypeNormalisedInput {
 	typeNormalisedInput := makeTypeNormalisedInput(appInfo)
 
-	if config.ApiKey != "" {
-		typeNormalisedInput.ApiKey = config.ApiKey
+	_config := dashboardmodels.TypeInput{}
+	if config != nil {
+		_config = *config
+	}
+
+	if _config.ApiKey != "" {
+		typeNormalisedInput.ApiKey = _config.ApiKey
 		typeNormalisedInput.AuthMode = dashboardmodels.AuthModeAPIKey
 	}
 
-	if config.Override != nil {
-		if config.Override.Functions != nil {
-			typeNormalisedInput.Override.Functions = config.Override.Functions
+	if _config.Override != nil {
+		if _config.Override.Functions != nil {
+			typeNormalisedInput.Override.Functions = _config.Override.Functions
 		}
-		if config.Override.APIs != nil {
-			typeNormalisedInput.Override.APIs = config.Override.APIs
+		if _config.Override.APIs != nil {
+			typeNormalisedInput.Override.APIs = _config.Override.APIs
 		}
 	}