fix: PR Comments

Author: sattvikc

recipe/emailverification/api/implementation.go

@@ -59,10 +59,7 @@ func MakeAPIImplementation() evmodels.APIInterface {
 			return evmodels.IsEmailVerifiedGETResponse{}, err
 		}
 
-		isVerified, err := sessionContainer.GetClaimValueWithContext(evclaims.EmailVerificationClaim, userContext)
-		if err != nil {
-			return evmodels.IsEmailVerifiedGETResponse{}, err
-		}
+		isVerified := sessionContainer.GetClaimValueWithContext(evclaims.EmailVerificationClaim, userContext)
 		if isVerified == nil {
 			return evmodels.IsEmailVerifiedGETResponse{}, errors.New("should never come here: EmailVerificationClaim failed to set value")
 		}

recipe/session/session.go

@@ -192,8 +192,8 @@ func newSessionContainer(config sessmodels.TypeNormalisedInput, session *Session
 		return mergeIntoAccessTokenPayloadWithContext(update, userContext)
 	}
 
-	getClaimValueWithContext := func(claim claims.TypeSessionClaim, userContext supertokens.UserContext) (interface{}, error) {
-		return claim.GetValueFromPayload(getAccessTokenPayloadWithContext(userContext), userContext), nil
+	getClaimValueWithContext := func(claim claims.TypeSessionClaim, userContext supertokens.UserContext) interface{} {
+		return claim.GetValueFromPayload(getAccessTokenPayloadWithContext(userContext), userContext)
 	}
 
 	removeClaimWithContext := func(claim claims.TypeSessionClaim, userContext supertokens.UserContext) error {
@@ -263,7 +263,7 @@ func newSessionContainer(config sessmodels.TypeNormalisedInput, session *Session
 		SetClaimValue: func(claim claims.TypeSessionClaim, value interface{}) error {
 			return setClaimValueWithContext(claim, value, &map[string]interface{}{})
 		},
-		GetClaimValue: func(claim claims.TypeSessionClaim) (interface{}, error) {
+		GetClaimValue: func(claim claims.TypeSessionClaim) interface{} {
 			return getClaimValueWithContext(claim, &map[string]interface{}{})
 		},
 		RemoveClaim: func(claim claims.TypeSessionClaim) error {

recipe/session/sessionwithjwt/sessionContainer.go

@@ -86,7 +86,7 @@ func newSessionWithJWTContainer(originalSessionClass sessmodels.SessionContainer
 		return originalSessionClass.SetClaimValueWithContext(claim, value, userContext)
 	}
 
-	getClaimValueWithContext := func(claim claims.TypeSessionClaim, userContext supertokens.UserContext) (interface{}, error) {
+	getClaimValueWithContext := func(claim claims.TypeSessionClaim, userContext supertokens.UserContext) interface{} {
 		return originalSessionClass.GetClaimValueWithContext(claim, userContext)
 	}
 
@@ -139,7 +139,7 @@ func newSessionWithJWTContainer(originalSessionClass sessmodels.SessionContainer
 		SetClaimValue: func(claim claims.TypeSessionClaim, value interface{}) error {
 			return setClaimValueWithContext(claim, value, &map[string]interface{}{})
 		},
-		GetClaimValue: func(claim claims.TypeSessionClaim) (interface{}, error) {
+		GetClaimValue: func(claim claims.TypeSessionClaim) interface{} {
 			return getClaimValueWithContext(claim, &map[string]interface{}{})
 		},
 		RemoveClaim: func(claim claims.TypeSessionClaim) error {

recipe/session/sessmodels/models.go

@@ -184,15 +184,15 @@ type SessionContainer struct {
 	AssertClaimsWithContext     func(claimValidators []claims.SessionClaimValidator, userContext supertokens.UserContext) error
 	FetchAndSetClaimWithContext func(claim claims.TypeSessionClaim, userContext supertokens.UserContext) error
 	SetClaimValueWithContext    func(claim claims.TypeSessionClaim, value interface{}, userContext supertokens.UserContext) error
-	GetClaimValueWithContext    func(claim claims.TypeSessionClaim, userContext supertokens.UserContext) (interface{}, error)
+	GetClaimValueWithContext    func(claim claims.TypeSessionClaim, userContext supertokens.UserContext) interface{}
 	RemoveClaimWithContext      func(claim claims.TypeSessionClaim, userContext supertokens.UserContext) error
 
 	MergeIntoAccessTokenPayload func(accessTokenPayloadUpdate map[string]interface{}) error
 
 	AssertClaims     func(claimValidators []claims.SessionClaimValidator) error
 	FetchAndSetClaim func(claim claims.TypeSessionClaim) error
 	SetClaimValue    func(claim claims.TypeSessionClaim, value interface{}) error
-	GetClaimValue    func(claim claims.TypeSessionClaim) (interface{}, error)
+	GetClaimValue    func(claim claims.TypeSessionClaim) interface{}
 	RemoveClaim      func(claim claims.TypeSessionClaim) error
 }