fix: review fixes

Author: porcellus

CHANGELOG.md

@@ -7,25 +7,24 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## Unreleased
 
--   Refactor the AccountLinking recipe to be automatically nitialized on SuperKokens init
--   Upgrade typedoc and the reference docs
--   Add a method for verifying if a recipe is initialized or not
--   Added register credential endpoint for the WebAuthn recipe
-
-## [23.0.0] - 2025-06-27
+## [23.0.0] - 2025-07-21
 
 ### Breaking changes
 
 -   The `getConsentRequest`, `acceptConsentRequest`, `rejectConsentRequest`, `acceptLoginRequest`, `rejectLoginRequest` and `introspectToken` can now possibly return an `ErrorOAuth2`.
 -   The `/oauth/introspect` can now possibly return an `ErrorAuth2`.
 -   Removed default defaultMaxAge from all built-in claims/validators. You can optionally set them when adding the validators. This should help with unexpected API calls during session verification.
+-   Added register credential endpoint for the WebAuthn recipe
 
-### Refactors
+### Refactors/Internal changes
 
 -   Refactors querier to use dynamic request body and response body types inference.
 -   Refactor internal network calls made with querier to use the new dynamic types.
 -   The `User` class now has a `fromApi` function to normalize the user object returned from the API.
 -   Added experimental support for plugins. Please note that the experimental nature of this feature means that we might break the interface in non-major version updates.
+-   Refactor the AccountLinking recipe to be automatically initialized on SuperTokens init instead during the first call
+-   Upgrade typedoc and the reference docs
+-   Add a method for verifying if a recipe is initialized or not
 
 ## [22.1.1] - 2025-06-20
 

lib/build/recipe/webauthn/api/implementation.js

@@ -70,7 +70,7 @@ export default function getAPIImplementation(): APIInterface {
                                   linkCode: input.linkCode,
                                   tenantId: input.tenantId,
                                   userContext: input.userContext,
-                              },
+                              }
                     );
                 }
 
@@ -111,7 +111,7 @@ export default function getAPIImplementation(): APIInterface {
                 }
 
                 const loginMethod = sessionUser.loginMethods.find(
-                    (lm) => lm.recipeUserId.getAsString() === input.session!.getRecipeUserId().getAsString(),
+                    (lm) => lm.recipeUserId.getAsString() === input.session!.getRecipeUserId().getAsString()
                 );
                 if (loginMethod === undefined) {
                     throw new SessionError({
@@ -187,7 +187,7 @@ export default function getAPIImplementation(): APIInterface {
                 return AuthUtils.getErrorStatusResponseWithReason(
                     preAuthChecks,
                     errorCodeMap,
-                    "SIGN_IN_UP_NOT_ALLOWED",
+                    "SIGN_IN_UP_NOT_ALLOWED"
                 );
             }
 
@@ -218,7 +218,7 @@ export default function getAPIImplementation(): APIInterface {
                           shouldTryLinkingWithSessionUser: input.shouldTryLinkingWithSessionUser,
                           tenantId: input.tenantId,
                           userContext: input.userContext,
-                      },
+                      }
             );
 
             if (
@@ -254,7 +254,7 @@ export default function getAPIImplementation(): APIInterface {
                 return AuthUtils.getErrorStatusResponseWithReason(
                     postAuthChecks,
                     errorCodeMap,
-                    "SIGN_IN_UP_NOT_ALLOWED",
+                    "SIGN_IN_UP_NOT_ALLOWED"
                 );
             }
 
@@ -298,11 +298,11 @@ export default function getAPIImplementation(): APIInterface {
                 factorIds = getEnabledPwlessFactors(input.options.config);
                 if (accountInfo.email !== undefined) {
                     factorIds = factorIds.filter((factor) =>
-                        [FactorIds.OTP_EMAIL, FactorIds.LINK_EMAIL].includes(factor),
+                        [FactorIds.OTP_EMAIL, FactorIds.LINK_EMAIL].includes(factor)
                     );
                 } else {
                     factorIds = factorIds.filter((factor) =>
-                        [FactorIds.OTP_PHONE, FactorIds.LINK_PHONE].includes(factor),
+                        [FactorIds.OTP_PHONE, FactorIds.LINK_PHONE].includes(factor)
                     );
                 }
             }
@@ -330,7 +330,7 @@ export default function getAPIImplementation(): APIInterface {
                 return AuthUtils.getErrorStatusResponseWithReason(
                     preAuthChecks,
                     errorCodeMap,
-                    "SIGN_IN_UP_NOT_ALLOWED",
+                    "SIGN_IN_UP_NOT_ALLOWED"
                 );
             }
 
@@ -344,7 +344,7 @@ export default function getAPIImplementation(): APIInterface {
                                   ? undefined
                                   : await input.options.config.getCustomUserInputCode(
                                         input.tenantId,
-                                        input.userContext,
+                                        input.userContext
                                     ),
                           session: input.session,
                           shouldTryLinkingWithSessionUser: input.shouldTryLinkingWithSessionUser,
@@ -358,12 +358,12 @@ export default function getAPIImplementation(): APIInterface {
                                   ? undefined
                                   : await input.options.config.getCustomUserInputCode(
                                         input.tenantId,
-                                        input.userContext,
+                                        input.userContext
                                     ),
                           session: input.session,
                           shouldTryLinkingWithSessionUser: input.shouldTryLinkingWithSessionUser,
                           tenantId: input.tenantId,
-                      },
+                      }
             );
 
             if (response.status !== "OK") {
@@ -454,7 +454,7 @@ export default function getAPIImplementation(): APIInterface {
                 userContext: input.userContext,
             });
             const userExists = users.some((u) =>
-                u.loginMethods.some((lm) => lm.recipeId === "passwordless" && lm.hasSameEmailAs(input.email)),
+                u.loginMethods.some((lm) => lm.recipeId === "passwordless" && lm.hasSameEmailAs(input.email))
             );
 
             return {
@@ -470,7 +470,7 @@ export default function getAPIImplementation(): APIInterface {
                     // tenantId: input.tenantId,
                 },
                 false,
-                input.userContext,
+                input.userContext
             );
 
             return {
@@ -513,7 +513,7 @@ export default function getAPIImplementation(): APIInterface {
                 },
                 userWithMatchingLoginMethod?.user,
                 true,
-                input.userContext,
+                input.userContext
             );
 
             if (authTypeInfo.status === "LINKING_TO_SESSION_USER_FAILED") {
@@ -574,7 +574,7 @@ export default function getAPIImplementation(): APIInterface {
                             factorIds,
                             input.tenantId,
                             false,
-                            input.userContext,
+                            input.userContext
                         );
                     }
 
@@ -667,8 +667,8 @@ async function getPasswordlessUserByAccountInfo(input: {
     });
     logDebugMessage(
         `getPasswordlessUserByAccountInfo got ${existingUsers.length} from core resp ${JSON.stringify(
-            input.accountInfo,
-        )}`,
+            input.accountInfo
+        )}`
     );
     const usersWithMatchingLoginMethods = existingUsers
         .map((user) => ({
@@ -677,17 +677,17 @@ async function getPasswordlessUserByAccountInfo(input: {
                 (lm) =>
                     lm.recipeId === "passwordless" &&
                     (lm.hasSameEmailAs(input.accountInfo.email) ||
-                        lm.hasSamePhoneNumberAs(input.accountInfo.phoneNumber)),
+                        lm.hasSamePhoneNumberAs(input.accountInfo.phoneNumber))
             )!,
         }))
         .filter(({ loginMethod }) => loginMethod !== undefined);
 
     logDebugMessage(
-        `getPasswordlessUserByAccountInfo ${usersWithMatchingLoginMethods.length} has matching login methods`,
+        `getPasswordlessUserByAccountInfo ${usersWithMatchingLoginMethods.length} has matching login methods`
     );
     if (usersWithMatchingLoginMethods.length > 1) {
         throw new Error(
-            "This should never happen: multiple users exist matching the accountInfo in passwordless createCode",
+            "This should never happen: multiple users exist matching the accountInfo in passwordless createCode"
         );
     }
     return usersWithMatchingLoginMethods[0];