Skip to content

Commit 2c848f5

Browse files
feat: keep support for decoding the cookie name
1 parent d40b5ca commit 2c848f5

File tree

2 files changed

+22
-2
lines changed

2 files changed

+22
-2
lines changed

lib/build/recipe/session/cookieAndHeaders.js

Lines changed: 10 additions & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

lib/ts/recipe/session/cookieAndHeaders.ts

Lines changed: 12 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -287,7 +287,18 @@ function parseCookieStringFromRequestHeaderAllowingDuplicates(cookieString: stri
287287

288288
for (const cookiePair of cookiePairs) {
289289
const [name, value] = cookiePair.trim().split("=");
290-
cookies.hasOwnProperty(name) ? cookies[name].push(value) : (cookies[name] = [value]);
290+
291+
// Try to decode the name or fallback to the original name
292+
let decodedName = name;
293+
try {
294+
decodedName = decodeURIComponent(name);
295+
} catch (e) {
296+
logDebugMessage(
297+
`parseCookieStringFromRequestHeaderAllowingDuplicates: Error decoding cookie name: ${name}`
298+
);
299+
}
300+
301+
cookies.hasOwnProperty(decodedName) ? cookies[decodedName].push(value) : (cookies[decodedName] = [value]);
291302
}
292303

293304
return cookies;

0 commit comments

Comments
 (0)