fix: thirdpartypasswordless email verification fix (#333)

Author: rishabhpoddar

CHANGELOG.md

@@ -7,6 +7,11 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## [unreleased]
 
+### Changes
+
+-   Fixes a few typos
+-   Changes `getEmailForUserIdForEmailVerification` function inside thirdpartypasswordless to take into account passwordless emails and return an empty string in case a passwordless email doesn't exist. This helps situations where the dev wants to customise the email verification functions in the thirdpartypasswordless recipe.
+
 ## [9.3.0] - 2022-06-17
 
 ### Added

lib/build/recipe/thirdpartypasswordless/recipe.js

@@ -129,12 +129,20 @@ class Recipe extends recipeModule_1.default {
                 if (userInfo === undefined) {
                     throw new Error("Unknown User ID provided");
                 } else if (!("thirdParty" in userInfo)) {
-                    // this is a passwordless user.. so we always return some random email,
-                    // and in the function for isEmailVerified, we will check if the user
-                    // is a passwordless user, and if they are, we will return true in there
-                    return "[email protected]";
+                    // this is a passwordless user
+                    if (userInfo.email !== undefined) {
+                        return userInfo.email;
+                    } else {
+                        // this is a passwordless user with only a phone number.
+                        // returning an empty string here is not a problem since
+                        // we override the email verification functions above to
+                        // send that the email is already verified for passwordless users.
+                        return "";
+                    }
+                } else {
+                    // third party user
+                    return userInfo.email;
                 }
-                return userInfo.email;
             });
         this.isInServerlessEnv = isInServerlessEnv;
         this.config = utils_1.validateAndNormaliseUserInput(this, appInfo, config);
@@ -151,7 +159,7 @@ class Recipe extends recipeModule_1.default {
             let builder = new supertokens_js_override_1.default(implementation_1.default());
             this.apiImpl = builder.override(this.config.override.apis).build();
         }
-        const recipImplReference = this.recipeInterfaceImpl;
+        const recipeImplReference = this.recipeInterfaceImpl;
         const emailVerificationConfig = this.config.emailVerificationFeature;
         this.emailDelivery =
             ingredients.emailDelivery === undefined
@@ -178,7 +186,7 @@ class Recipe extends recipeModule_1.default {
                                       return Object.assign(Object.assign({}, oI), {
                                           createEmailVerificationToken: function (input) {
                                               return __awaiter(this, void 0, void 0, function* () {
-                                                  let user = yield recipImplReference.getUserById({
+                                                  let user = yield recipeImplReference.getUserById({
                                                       userId: input.userId,
                                                       userContext: input.userContext,
                                                   });
@@ -193,7 +201,7 @@ class Recipe extends recipeModule_1.default {
                                           },
                                           isEmailVerified: function (input) {
                                               return __awaiter(this, void 0, void 0, function* () {
-                                                  let user = yield recipImplReference.getUserById({
+                                                  let user = yield recipeImplReference.getUserById({
                                                       userId: input.userId,
                                                       userContext: input.userContext,
                                                   });

lib/ts/recipe/thirdpartypasswordless/recipe.ts

@@ -36,7 +36,7 @@ import RecipeImplementation from "./recipeImplementation";
 import PasswordlessRecipeImplementation from "./recipeImplementation/passwordlessRecipeImplementation";
 import ThirdPartyRecipeImplementation from "./recipeImplementation/thirdPartyRecipeImplementation";
 import getThirdPartyIterfaceImpl from "./api/thirdPartyAPIImplementation";
-import getPasswordlessIterfaceImpl from "./api/passwordlessAPIImplementation";
+import getPasswordlessInterfaceImpl from "./api/passwordlessAPIImplementation";
 import APIImplementation from "./api/implementation";
 import { Querier } from "../../querier";
 import OverrideableBuilder from "supertokens-js-override";
@@ -98,7 +98,7 @@ export default class Recipe extends RecipeModule {
             this.apiImpl = builder.override(this.config.override.apis).build();
         }
 
-        const recipImplReference = this.recipeInterfaceImpl;
+        const recipeImplReference = this.recipeInterfaceImpl;
         const emailVerificationConfig = this.config.emailVerificationFeature;
 
         this.emailDelivery =
@@ -131,7 +131,7 @@ export default class Recipe extends RecipeModule {
                                       return {
                                           ...oI,
                                           createEmailVerificationToken: async function (input) {
-                                              let user = await recipImplReference.getUserById({
+                                              let user = await recipeImplReference.getUserById({
                                                   userId: input.userId,
                                                   userContext: input.userContext,
                                               });
@@ -145,7 +145,7 @@ export default class Recipe extends RecipeModule {
                                               }
                                           },
                                           isEmailVerified: async function (input) {
-                                              let user = await recipImplReference.getUserById({
+                                              let user = await recipeImplReference.getUserById({
                                                   userId: input.userId,
                                                   userContext: input.userContext,
                                               });
@@ -193,7 +193,7 @@ export default class Recipe extends RecipeModule {
                                   return PasswordlessRecipeImplementation(this.recipeInterfaceImpl);
                               },
                               apis: (_) => {
-                                  return getPasswordlessIterfaceImpl(this.apiImpl);
+                                  return getPasswordlessInterfaceImpl(this.apiImpl);
                               },
                           },
                       },
@@ -350,11 +350,19 @@ export default class Recipe extends RecipeModule {
         if (userInfo === undefined) {
             throw new Error("Unknown User ID provided");
         } else if (!("thirdParty" in userInfo)) {
-            // this is a passwordless user.. so we always return some random email,
-            // and in the function for isEmailVerified, we will check if the user
-            // is a passwordless user, and if they are, we will return true in there
-            return "[email protected]";
+            // this is a passwordless user
+            if (userInfo.email !== undefined) {
+                return userInfo.email;
+            } else {
+                // this is a passwordless user with only a phone number.
+                // returning an empty string here is not a problem since
+                // we override the email verification functions above to
+                // send that the email is already verified for passwordless users.
+                return "";
+            }
+        } else {
+            // third party user
+            return userInfo.email;
         }
-        return userInfo.email;
     };
 }