fix: types and linter errors

KShivendu · KShivendu · commit 2726cfb60db5 · 2023-07-06T12:56:08.000+05:30
diff --git a/supertokens_python/always_initialised_recipes.py b/supertokens_python/always_initialised_recipes.py
@@ -12,7 +12,10 @@
 # License for the specific language governing permissions and limitations
 # under the License.
 from __future__ import annotations
-from typing import Any, Callable, Union
+from typing import Callable, Optional, TYPE_CHECKING
 
+if TYPE_CHECKING:
+    from supertokens_python.recipe_module import RecipeModule
+    from supertokens_python import AppInfo
 
-DEFAULT_MULTITENANCY_RECIPE: Union[Callable[[Any], Any], None] = None
+DEFAULT_MULTITENANCY_RECIPE: Optional[Callable[[AppInfo], RecipeModule]] = None
diff --git a/supertokens_python/recipe/multitenancy/interfaces.py b/supertokens_python/recipe/multitenancy/interfaces.py
@@ -175,7 +175,9 @@ def __init__(
 
 
 class ThirdPartyProvider:
-    def __init__(self, id: str, name: Optional[str]):
+    def __init__(
+        self, id: str, name: Optional[str]
+    ):  # pylint: disable=redefined-builtin
         self.id = id
         self.name = name
 
diff --git a/supertokens_python/recipe/multitenancy/recipe.py b/supertokens_python/recipe/multitenancy/recipe.py
@@ -255,7 +255,7 @@ async def login_methods_get(
 
 class AllowedDomainsClaimClass(PrimitiveArrayClaim[List[str]]):
     def __init__(self):
-        async def fetch_value(user_id: str, user_context: Dict[str, Any]) -> List[str]:
+        async def fetch_value(_user_id: str, user_context: Dict[str, Any]) -> List[str]:
             recipe = MultitenancyRecipe.get_instance()
             tenant_id = (
                 None  # TODO fetch value will be passed with tenant_id as well later
diff --git a/supertokens_python/recipe/thirdparty/__init__.py b/supertokens_python/recipe/thirdparty/__init__.py
@@ -18,7 +18,7 @@
 
 
 from . import exceptions as ex
-from . import utils, provider
+from . import utils, provider, providers
 from .recipe import ThirdPartyRecipe
 
 InputOverrideConfig = utils.InputOverrideConfig
diff --git a/supertokens_python/recipe/thirdparty/provider.py b/supertokens_python/recipe/thirdparty/provider.py
@@ -41,43 +41,43 @@ def __init__(
 
 
 class Provider:
-    def __init__(self, id: str):
+    def __init__(self, id: str):  # pylint: disable=redefined-builtin
         self.id = id
         self.config = ProviderConfigForClientType("temp")
 
-    async def get_config_for_client_type(
+    async def get_config_for_client_type(  # pylint: disable=no-self-use
         self, client_type: Optional[str], user_context: Dict[str, Any]
     ) -> ProviderConfigForClientType:
         _ = client_type
         __ = user_context
-        raise NotImplementedError
+        raise NotImplementedError()
 
-    async def get_authorisation_redirect_url(
+    async def get_authorisation_redirect_url(  # pylint: disable=no-self-use
         self,
         redirect_uri_on_provider_dashboard: str,
         user_context: Dict[str, Any],
     ) -> AuthorisationRedirect:
         _ = redirect_uri_on_provider_dashboard
         __ = user_context
-        raise NotImplementedError
+        raise NotImplementedError()
 
-    async def exchange_auth_code_for_oauth_tokens(
+    async def exchange_auth_code_for_oauth_tokens(  # pylint: disable=no-self-use
         self,
         redirect_uri_info: RedirectUriInfo,
         user_context: Dict[str, Any],
     ) -> Dict[str, Any]:
         _ = redirect_uri_info
         __ = user_context
-        raise NotImplementedError
+        raise NotImplementedError()
 
-    async def get_user_info(
+    async def get_user_info(  # pylint: disable=no-self-use
         self,
         oauth_tokens: Dict[str, Any],
         user_context: Dict[str, Any],
     ) -> UserInfo:
         _ = oauth_tokens
         __ = user_context
-        raise NotImplementedError
+        raise NotImplementedError()
 
 
 class ProviderClientConfig:
diff --git a/supertokens_python/recipe/thirdparty/providers/active_directory.py b/supertokens_python/recipe/thirdparty/providers/active_directory.py
@@ -48,7 +48,9 @@ async def get_config_for_client_type(
         return config
 
 
-def ActiveDirectory(input: ProviderInput) -> Provider:
+def ActiveDirectory(
+    input: ProviderInput,  # pylint: disable=redefined-builtin
+) -> Provider:
     if input.config.name is None:
         input.config.name = "Active Directory"
 
diff --git a/supertokens_python/recipe/thirdparty/providers/boxy_saml.py b/supertokens_python/recipe/thirdparty/providers/boxy_saml.py
@@ -49,7 +49,7 @@ async def get_config_for_client_type(
         return config
 
 
-def BoxySAML(input: ProviderInput) -> Provider:
+def BoxySAML(input: ProviderInput) -> Provider:  # pylint: disable=redefined-builtin
     if input.config.name is None:
         input.config.name = "Boxy SAML"
 
diff --git a/supertokens_python/recipe/thirdparty/providers/custom.py b/supertokens_python/recipe/thirdparty/providers/custom.py
@@ -160,6 +160,18 @@ async def verify_id_token_from_jwks_endpoint_and_get_payload(
     raise err
 
 
+def merge_into_dict(src: Dict[str, Any], dest: Dict[str, Any]) -> Dict[str, Any]:
+    res = dest.copy()
+    for k, v in src.items():
+        if v is None:
+            if k in res:
+                del res[k]
+        else:
+            res[k] = v
+
+    return res
+
+
 class GenericProvider(Provider):
     def __init__(self, config: ProviderConfig):
         super().__init__(config.third_party_id)
@@ -288,12 +300,7 @@ async def exchange_auth_code_for_oauth_tokens(
             access_token_params["code_verifier"] = redirect_uri_info.pkce_code_verifier
 
         if self.config.token_endpoint_body_params is not None:
-            for k, v in self.config.token_endpoint_body_params:
-                if v is None:
-                    if k in access_token_params:
-                        del access_token_params[k]
-                else:
-                    access_token_params[k] = v
+            access_token_params = merge_into_dict(self.config.token_endpoint_body_params, access_token_params)
 
         # Transformation needed for dev keys BEGIN
         if is_using_oauth_development_client_id(self.config.client_id):
@@ -336,20 +343,10 @@ async def get_user_info(
 
             if self.config.user_info_endpoint is not None:
                 if self.config.user_info_endpoint_headers is not None:
-                    for k, v in self.config.user_info_endpoint_headers.items():
-                        if v is None:
-                            if k in headers:
-                                del headers[k]
-                        else:
-                            headers[k] = v
+                    headers = merge_into_dict(self.config.user_info_endpoint_headers, headers)
 
                 if self.config.user_info_endpoint_query_params is not None:
-                    for k, v in self.config.user_info_endpoint_query_params.items():
-                        if v is None:
-                            if k in query_params:
-                                del query_params[k]
-                        else:
-                            query_params[k] = v
+                    query_params = merge_into_dict(self.config.user_info_endpoint_query_params, query_params)
 
                 raw_user_info_from_provider.from_user_info_api = await do_get_request(
                     self.config.user_info_endpoint, query_params, headers
@@ -367,7 +364,7 @@ async def get_user_info(
 
 
 def NewProvider(
-    input: ProviderInput,
+    input: ProviderInput,  # pylint: disable=redefined-builtin
     base_class: Callable[[ProviderConfig], Provider] = GenericProvider,
 ) -> Provider:
     provider_instance = base_class(input.config)
diff --git a/supertokens_python/recipe/thirdparty/providers/discord.py b/supertokens_python/recipe/thirdparty/providers/discord.py
@@ -40,7 +40,7 @@ async def get_config_for_client_type(
         return config
 
 
-def Discord(input: ProviderInput) -> Provider:
+def Discord(input: ProviderInput) -> Provider:  # pylint: disable=redefined-builtin
     if input.config.name is None:
         input.config.name = "Discord"
 
diff --git a/supertokens_python/recipe/thirdparty/providers/facebook.py b/supertokens_python/recipe/thirdparty/providers/facebook.py
@@ -53,7 +53,7 @@ async def get_user_info(
         return await super().get_user_info(oauth_tokens, user_context)
 
 
-def Facebook(input: ProviderInput) -> Provider:
+def Facebook(input: ProviderInput) -> Provider:  # pylint: disable=redefined-builtin
     if input.config.name is None:
         input.config.name = "Facebook"
 
diff --git a/supertokens_python/recipe/thirdparty/providers/github.py b/supertokens_python/recipe/thirdparty/providers/github.py
@@ -61,7 +61,7 @@ async def get_user_info(
         return result
 
 
-def Github(input: ProviderInput) -> Provider:
+def Github(input: ProviderInput) -> Provider:  # pylint: disable=redefined-builtin
     if input.config.name is None:
         input.config.name = "Github"
 
diff --git a/supertokens_python/recipe/thirdparty/providers/google.py b/supertokens_python/recipe/thirdparty/providers/google.py
@@ -42,7 +42,7 @@ async def get_config_for_client_type(
 
 
 def Google(
-    input: ProviderInput,
+    input: ProviderInput,  # pylint: disable=redefined-builtin
     base_class: Callable[[ProviderConfig], GoogleImpl] = GoogleImpl,
 ) -> Provider:
     if input.config.name is None:
diff --git a/supertokens_python/recipe/thirdparty/providers/google_workspaces.py b/supertokens_python/recipe/thirdparty/providers/google_workspaces.py
@@ -40,7 +40,9 @@ async def get_config_for_client_type(
         return config
 
 
-def GoogleWorkspaces(input: ProviderInput) -> Provider:
+def GoogleWorkspaces(
+    input: ProviderInput,  # pylint: disable=redefined-builtin
+) -> Provider:
     if input.config.name is None:
         input.config.name = "Google Workspaces"
 
@@ -49,7 +51,7 @@ def GoogleWorkspaces(input: ProviderInput) -> Provider:
         async def default_validate_id_token_payload(
             id_token_payload: Dict[str, Any],
             config: ProviderConfigForClientType,
-            user_context: Dict[str, Any],
+            _user_context: Dict[str, Any],
         ):
             if (config.additional_config or {}).get("hd", "*") != "*":
                 if (config.additional_config or {}).get("hd") != id_token_payload.get(
diff --git a/supertokens_python/recipe/thirdparty/providers/linkedin.py b/supertokens_python/recipe/thirdparty/providers/linkedin.py
@@ -86,7 +86,7 @@ async def get_user_info(
         )
 
 
-def Linkedin(input: ProviderInput) -> Provider:
+def Linkedin(input: ProviderInput) -> Provider:  # pylint: disable=redefined-builtin
     if input.config.name is None:
         input.config.name = "Linkedin"
 
diff --git a/supertokens_python/recipe/thirdparty/providers/okta.py b/supertokens_python/recipe/thirdparty/providers/okta.py
@@ -50,7 +50,7 @@ async def get_config_for_client_type(
         return config
 
 
-def Okta(input: ProviderInput) -> Provider:
+def Okta(input: ProviderInput) -> Provider:  # pylint: disable=redefined-builtin
     if input.config.name is None:
         input.config.name = "Okta"
 
diff --git a/supertokens_python/recipe/thirdparty/providers/utils.py b/supertokens_python/recipe/thirdparty/providers/utils.py
@@ -1,4 +1,4 @@
-from typing import Any, Dict
+from typing import Any, Dict, Optional
 
 from httpx import AsyncClient
 
@@ -17,15 +17,22 @@ def is_using_oauth_development_client_id(client_id: str):
     return client_id.startswith(DEV_KEY_IDENTIFIER) or client_id in DEV_OAUTH_CLIENT_IDS
 
 
-def get_actual_client_id_from_development_client_id(client_id: str):
+def get_actual_client_id_from_development_client_id(client_id: str) -> str:
     if client_id.startswith(DEV_KEY_IDENTIFIER):
         return client_id.split(DEV_KEY_IDENTIFIER, 1)[1]
     return client_id
 
 
 async def do_get_request(
-    url: str, query_params: Dict[str, str] = {}, headers: Dict[str, str] = {}
+    url: str,
+    query_params: Optional[Dict[str, str]] = None,
+    headers: Optional[Dict[str, str]] = None,
 ) -> Dict[str, Any]:
+    if query_params is None:
+        query_params = {}
+    if headers is None:
+        headers = {}
+
     # TODO logging
 
     async with AsyncClient() as client:
@@ -35,9 +42,13 @@ async def do_get_request(
 
 
 async def do_post_request(
-    url: str, body_params: Dict[str, str] = {}, headers: Dict[str, str] = {}
+    url: str,
+    body_params: Optional[Dict[str, str]] = None,
+    headers: Optional[Dict[str, str]] = None,
 ) -> Dict[str, Any]:
-    if not headers:
+    if body_params is None:
+        body_params = {}
+    if headers is None:
         headers = {}
 
     headers["content-type"] = "application/x-www-form-urlencoded"
diff --git a/supertokens_python/recipe/thirdparty/utils.py b/supertokens_python/recipe/thirdparty/utils.py
@@ -13,7 +13,7 @@
 # under the License.
 from __future__ import annotations
 
-from typing import TYPE_CHECKING, Any, Callable, Dict, List, Set, Union
+from typing import TYPE_CHECKING, Any, Callable, Dict, List, Set, Union, Optional
 
 from supertokens_python.exceptions import raise_bad_input_exception
 from supertokens_python.recipe.thirdparty.provider import ProviderInput
@@ -27,7 +27,10 @@
 
 
 class SignInAndUpFeature:
-    def __init__(self, providers: List[ProviderInput] = []):
+    def __init__(self, providers: Optional[List[ProviderInput]] = None):
+        if providers is None:
+            providers = []
+
         third_party_id_set: Set[str] = set()
 
         for provider in providers:
diff --git a/supertokens_python/supertokens.py b/supertokens_python/supertokens.py
@@ -46,7 +46,7 @@
     send_non_200_response_with_message,
 )
 
-from . import always_initialised_recipes
+from .always_initialised_recipes import DEFAULT_MULTITENANCY_RECIPE
 
 if TYPE_CHECKING:
     from .recipe_module import RecipeModule
@@ -198,13 +198,8 @@ def make_recipe(recipe: Callable[[AppInfo], RecipeModule]) -> RecipeModule:
 
         self.recipe_modules: List[RecipeModule] = list(map(make_recipe, recipe_list))
 
-        if (
-            not multitenancy_found[0]
-            and always_initialised_recipes.DEFAULT_MULTITENANCY_RECIPE is not None
-        ):
-            self.recipe_modules.append(
-                always_initialised_recipes.DEFAULT_MULTITENANCY_RECIPE(self.app_info)
-            )
+        if callable(DEFAULT_MULTITENANCY_RECIPE) and not multitenancy_found[0]:
+            self.recipe_modules.append(DEFAULT_MULTITENANCY_RECIPE(self.app_info))
 
         self.telemetry = (
             telemetry
