refactor: Suggested changes

Author: KShivendu

supertokens_python/recipe/session/exceptions.py

@@ -29,7 +29,6 @@ def raise_try_refresh_token_exception(ex: Union[str, Exception]) -> NoReturn:
     if isinstance(ex, SuperTokensError):
         raise ex
 
-    assert isinstance(ex, str)
     raise TryRefreshTokenError(ex) from None
 
 
@@ -38,27 +37,18 @@ def raise_unauthorised_exception(
     clear_tokens: bool = True,
     response_mutators: Optional[List[ResponseMutator]] = None,
 ) -> NoReturn:
-    if response_mutators is None:
-        response_mutators = []
-
     err = UnauthorisedError(msg, clear_tokens)
-    err.extend_response_mutators(response_mutators)
+
+    if response_mutators is not None:
+        err.response_mutators.extend(response_mutators)
 
     raise err
 
 
 class SuperTokensSessionError(SuperTokensError):
-    def __init__(
-        self, msg: str, response_mutators: Optional[List[ResponseMutator]] = None
-    ):
-        super().__init__(msg)
-        self.response_mutators = response_mutators
-
-    def extend_response_mutators(self, response_mutators: List[ResponseMutator]):
-        if self.response_mutators is None:
-            self.response_mutators = []
-
-        self.response_mutators.extend(response_mutators)
+    def __init__(self, *args: Any, **kwargs: Any) -> None:
+        super().__init__(*args, **kwargs)
+        self.response_mutators: List[ResponseMutator] = []
 
 
 class TokenTheftError(SuperTokensSessionError):

supertokens_python/recipe/session/session_request_functions.py

@@ -422,7 +422,7 @@ async def refresh_session_in_request(
                     )
                 )
 
-        e.extend_response_mutators(response_mutators)
+        e.response_mutators.extend(response_mutators)
         raise e
 
     log_debug_message(

supertokens_python/utils.py

@@ -99,11 +99,7 @@ def find_max_version(versions_1: List[str], versions_2: List[str]) -> Union[str,
     return max_v
 
 
-def is_version_gte(
-    version: str, minimum_version: str, must_be_minor: Optional[bool] = None
-) -> bool:
-    if must_be_minor is True:
-        assert len(minimum_version.split(".")) == 2
+def is_version_gte(version: str, minimum_version: str) -> bool:
     return _get_max_version(version, minimum_version) == version
 
 

tests/test_utils.py

@@ -60,22 +60,6 @@ def test_util_is_version_gte(version: str, min_minor_version: str, is_gte: bool)
     assert is_version_gte(version, min_minor_version) == is_gte
 
 
-@pytest.mark.parametrize(
-    "version,base_version",
-    [
-        ("1.12.0", "1.12.0"),
-        ("1.12.0", "1.12.0.1"),
-        ("1.12.0", "1.0.0"),
-        ("1.12.0", "1"),
-    ],
-)
-def test_utils_is_version_gte_raises_error_if_not_minimum_minor_version(
-    version: str, base_version: str
-):
-    with pytest.raises(AssertionError):
-        is_version_gte(version, base_version, must_be_minor=True)
-
-
 SECOND = 1000
 MINUTE = 60 * SECOND
 HOUR = 60 * MINUTE