fixes a few tests

Author: rishabhpoddar

CONTRIBUTING.md

@@ -47,7 +47,7 @@ You will need to setup the [supertokens-core](https://github.com/supertokens/sup
 3. Open a new terminal and navigate to the `supertokens-python` respositry.
 4. Use `export SUPERTOKENS_PATH=path/to/supertokens-root` (**MANDATORY**)
 4. To run all tests, while ensuring the test environment is running on a different terminal, use `make test`.
-5. To run individual tests, use `pytest ./tests/path/to/test/file.py  -k test_function_name` OR use your IDE's in-built UI for running python tests. You may read [VSCode Python Testing](https://code.visualstudio.com/docs/python/testing) and [PyCharm Testing](https://www.jetbrains.com/help/pycharm/testing-your-first-python-application.html#debug-test) for more info.
+5. To run individual tests, use `INSTALL_DIR=../supertokens-root pytest ./tests/path/to/test/file.py::test_function_name` OR use your IDE's in-built UI for running python tests. You may read [VSCode Python Testing](https://code.visualstudio.com/docs/python/testing) and [PyCharm Testing](https://www.jetbrains.com/help/pycharm/testing-your-first-python-application.html#debug-test) for more info.
 
 ## Pull Request
 

supertokens_python/recipe/session/utils.py

@@ -428,6 +428,12 @@ def validate_and_normalise_user_input(
     if expose_access_token_to_frontend_in_cookie_based_auth is None:
         expose_access_token_to_frontend_in_cookie_based_auth = False
 
+    if cookie_same_site is not None:
+        # this is just so that we check that the user has provided the right
+        # values, since normalise_same_site throws an error if the user
+        # as provided an empty string.
+        _ = normalise_same_site(cookie_same_site)
+
     def get_cookie_same_site(
         request: Optional[BaseRequest], user_context: Dict[str, Any]
     ) -> Literal["lax", "strict", "none"]:

tests/test_config.py

@@ -418,7 +418,8 @@ async def test_config_values():
     )
 
     assert SessionRecipe.get_instance().config.get_cookie_same_site(None, {}) == "lax"
-    assert SessionRecipe.get_instance().config.anti_csrf_function_or_string == "NONE"
+    anti_csrf = SessionRecipe.get_instance().config.anti_csrf_function_or_string
+    assert not isinstance(anti_csrf, str) and anti_csrf(None, {}) == "NONE"
     assert SessionRecipe.get_instance().config.cookie_secure
 
     reset()
@@ -439,10 +440,8 @@ async def test_config_values():
     )
 
     assert SessionRecipe.get_instance().config.get_cookie_same_site(None, {}) == "none"
-    assert (
-        SessionRecipe.get_instance().config.anti_csrf_function_or_string
-        == "VIA_CUSTOM_HEADER"
-    )
+    anti_csrf = SessionRecipe.get_instance().config.anti_csrf_function_or_string
+    assert not isinstance(anti_csrf, str) and anti_csrf(None, {}) == "VIA_CUSTOM_HEADER"
     assert SessionRecipe.get_instance().config.cookie_secure
 
     reset()
@@ -463,7 +462,8 @@ async def test_config_values():
     )
 
     assert SessionRecipe.get_instance().config.get_cookie_same_site(None, {}) == "lax"
-    assert SessionRecipe.get_instance().config.anti_csrf_function_or_string == "NONE"
+    anti_csrf = SessionRecipe.get_instance().config.anti_csrf_function_or_string
+    assert not isinstance(anti_csrf, str) and anti_csrf(None, {}) == "NONE"
     assert SessionRecipe.get_instance().config.cookie_secure
 
     reset()
@@ -484,7 +484,8 @@ async def test_config_values():
     )
 
     assert SessionRecipe.get_instance().config.get_cookie_same_site(None, {}) == "lax"
-    assert SessionRecipe.get_instance().config.anti_csrf_function_or_string == "NONE"
+    anti_csrf = SessionRecipe.get_instance().config.anti_csrf_function_or_string
+    assert not isinstance(anti_csrf, str) and anti_csrf(None, {}) == "NONE"
     assert not SessionRecipe.get_instance().config.cookie_secure
 
     reset()
@@ -527,10 +528,8 @@ async def test_config_values():
     )
 
     assert SessionRecipe.get_instance().config.get_cookie_same_site(None, {}) == "none"
-    assert (
-        SessionRecipe.get_instance().config.anti_csrf_function_or_string
-        == "VIA_CUSTOM_HEADER"
-    )
+    anti_csrf = SessionRecipe.get_instance().config.anti_csrf_function_or_string
+    assert not isinstance(anti_csrf, str) and anti_csrf(None, {}) == "VIA_CUSTOM_HEADER"
     assert SessionRecipe.get_instance().config.cookie_secure
 
     reset()
@@ -551,7 +550,8 @@ async def test_config_values():
     )
 
     assert SessionRecipe.get_instance().config.get_cookie_same_site(None, {}) == "lax"
-    assert SessionRecipe.get_instance().config.anti_csrf_function_or_string == "NONE"
+    anti_csrf = SessionRecipe.get_instance().config.anti_csrf_function_or_string
+    assert not isinstance(anti_csrf, str) and anti_csrf(None, {}) == "NONE"
     assert not SessionRecipe.get_instance().config.cookie_secure
 
     reset()