Skip to content

Commit d5e35ee

Browse files
committed
more fixes
1 parent 08bc4c6 commit d5e35ee

File tree

7 files changed

+16
-21
lines changed

7 files changed

+16
-21
lines changed

supertokens_python/framework/django/django_middleware.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ async def __asyncMiddleware(request: HttpRequest):
4949
request.supertokens, SessionContainer # type: ignore
5050
):
5151
manage_session_post_response(
52-
request.supertokens, result # type: ignore
52+
request.supertokens, result, user_context # type: ignore
5353
)
5454
if isinstance(result, DjangoResponse):
5555
return result.response
@@ -85,7 +85,7 @@ def __syncMiddleware(request: HttpRequest):
8585
request.supertokens, SessionContainer # type: ignore
8686
):
8787
manage_session_post_response(
88-
request.supertokens, result # type: ignore
88+
request.supertokens, result, user_context # type: ignore
8989
)
9090
return result.response
9191

supertokens_python/framework/fastapi/fastapi_middleware.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,7 @@ async def dispatch(self, request: Request, call_next: RequestResponseEndpoint):
5959
if hasattr(request.state, "supertokens") and isinstance(
6060
request.state.supertokens, SessionContainer
6161
):
62-
manage_session_post_response(request.state.supertokens, result)
62+
manage_session_post_response(request.state.supertokens, result, user_context)
6363
if isinstance(result, FastApiResponse):
6464
return result.response
6565
except SuperTokensError as e:

supertokens_python/framework/flask/flask_middleware.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,7 @@ def _(response: Response):
6969

7070
response_ = FlaskResponse(response)
7171
if hasattr(g, "supertokens") and g.supertokens is not None:
72-
manage_session_post_response(g.supertokens, response_)
72+
manage_session_post_response(g.supertokens, response_, {})
7373

7474
return response_.response
7575

supertokens_python/recipe/session/cookie_and_header.py

Lines changed: 6 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -141,10 +141,10 @@ def set_cookie_response_mutator(
141141
expires: int,
142142
path_type: Literal["refresh_token_path", "access_token_path"],
143143
request: BaseRequest,
144-
user_context: Dict[str, Any],
145144
):
146145
def mutator(
147146
response: BaseResponse,
147+
user_context: Dict[str, Any],
148148
):
149149
return _set_cookie(
150150
response, config, key, value, expires, path_type, request, user_context
@@ -161,6 +161,7 @@ def _attach_anti_csrf_header(response: BaseResponse, value: str):
161161
def anti_csrf_response_mutator(value: str):
162162
def mutator(
163163
response: BaseResponse,
164+
_: Dict[str, Any],
164165
):
165166
return _attach_anti_csrf_header(response, value)
166167

@@ -195,10 +196,10 @@ def clear_session_mutator(
195196
config: SessionConfig,
196197
transfer_method: TokenTransferMethod,
197198
request: BaseRequest,
198-
user_context: Dict[str, Any],
199199
):
200200
def mutator(
201201
response: BaseResponse,
202+
user_context: Dict[str, Any],
202203
):
203204
return _clear_session(response, config, transfer_method, request, user_context)
204205

@@ -232,10 +233,10 @@ def clear_session_response_mutator(
232233
config: SessionConfig,
233234
transfer_method: TokenTransferMethod,
234235
request: BaseRequest,
235-
user_context: Dict[str, Any],
236236
):
237237
def mutator(
238238
response: BaseResponse,
239+
user_context: Dict[str, Any],
239240
):
240241
return _clear_session(response, config, transfer_method, request, user_context)
241242

@@ -313,9 +314,8 @@ def token_response_mutator(
313314
expires: int,
314315
transfer_method: TokenTransferMethod,
315316
request: BaseRequest,
316-
user_context: Dict[str, Any],
317317
):
318-
def mutator(response: BaseResponse):
318+
def mutator(response: BaseResponse, user_context: Dict[str, Any],):
319319
_set_token(
320320
response,
321321
config,
@@ -341,10 +341,9 @@ def access_token_mutator(
341341
config: SessionConfig,
342342
transfer_method: TokenTransferMethod,
343343
request: BaseRequest,
344-
user_context: Dict[str, Any],
345344
):
346345
def mutator(
347-
response: BaseResponse,
346+
response: BaseResponse, user_context: Dict[str, Any],
348347
):
349348
_set_access_token_in_response(
350349
response,

supertokens_python/recipe/session/interfaces.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -378,7 +378,7 @@ async def verify_session(
378378
pass
379379

380380

381-
ResponseMutator = Callable[[BaseResponse], None]
381+
ResponseMutator = Callable[[BaseResponse, Dict[str, Any]], None]
382382

383383

384384
class TokenInfo:

supertokens_python/recipe/session/session_class.py

Lines changed: 3 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@
3838
from ...framework import BaseRequest
3939
from supertokens_python.utils import (
4040
log_debug_message,
41-
set_request_in_user_context_if_not_defined,
41+
default_user_context
4242
)
4343

4444
_T = TypeVar("_T")
@@ -55,15 +55,14 @@ async def attach_to_request_response(
5555

5656
if self.access_token_updated:
5757
if user_context is None:
58-
user_context = set_request_in_user_context_if_not_defined({}, request)
58+
user_context = default_user_context(request)
5959
self.response_mutators.append(
6060
access_token_mutator(
6161
self.access_token,
6262
self.front_token,
6363
self.config,
6464
transfer_method,
6565
request,
66-
user_context,
6766
)
6867
)
6968
if self.refresh_token is not None:
@@ -75,7 +74,6 @@ async def attach_to_request_response(
7574
self.refresh_token.expiry,
7675
transfer_method,
7776
request,
78-
user_context,
7977
)
8078
)
8179
if self.anti_csrf_token is not None:
@@ -108,7 +106,6 @@ async def revoke_session(self, user_context: Union[Any, None] = None) -> None:
108106
self.config,
109107
transfer_method,
110108
self.req_res_info.request,
111-
user_context,
112109
)
113110
)
114111

@@ -330,8 +327,7 @@ async def merge_into_access_token_payload(
330327
self.front_token,
331328
self.config,
332329
transfer_method,
333-
self.req_res_info.request,
334-
user_context,
330+
self.req_res_info.request
335331
)
336332
)
337333
else:

supertokens_python/supertokens.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -192,10 +192,10 @@ def defaultImpl(o: Any):
192192
return json.dumps(self, default=defaultImpl, sort_keys=True, indent=4)
193193

194194

195-
def manage_session_post_response(session: SessionContainer, response: BaseResponse):
195+
def manage_session_post_response(session: SessionContainer, response: BaseResponse, user_context: Dict[str, Any]):
196196
# Something similar happens in handle_error of session/recipe.py
197197
for mutator in session.response_mutators:
198-
mutator(response=response) # type: ignore
198+
mutator(response, user_context)
199199

200200

201201
class Supertokens:

0 commit comments

Comments
 (0)