fixes linting and formatting in tests

Author: rishabhpoddar

.pylintrc

@@ -45,7 +45,7 @@ limit-inference-results=100
 
 # List of plugins (as comma separated values of python module names) to load,
 # usually to register additional checkers.
-load-plugins=pylint.extensions.no_self_use
+load-plugins=
 
 # Pickle collected data for later comparisons.
 persistent=yes

.vscode/settings.json

@@ -1,4 +1,6 @@
 {
+    "python.linting.pylintEnabled": true,
+    "python.linting.enabled": true,
     "editor.codeActionsOnSave": {
         "source.organizeImports": true
     },

supertokens_python/recipe/session/utils.py

@@ -377,6 +377,7 @@ def validate_and_normalise_user_input(
     use_dynamic_access_token_signing_key: Union[bool, None] = None,
     expose_access_token_to_frontend_in_cookie_based_auth: Union[bool, None] = None,
 ):
+    _ = cookie_same_site  # we have this otherwise pylint complains that cookie_same_site is unused, but it is being used in the get_cookie_same_site function.
     if anti_csrf not in {"VIA_TOKEN", "VIA_CUSTOM_HEADER", "NONE", None}:
         raise ValueError(
             "anti_csrf must be one of VIA_TOKEN, VIA_CUSTOM_HEADER, NONE or None"

tests/test_config.py

@@ -266,7 +266,7 @@ async def test_same_site_values():
         recipe_list=[session.init(cookie_same_site="lax")],
     )
 
-    assert SessionRecipe.get_instance().config.get_cookie_same_site(None, None) == "lax"
+    assert SessionRecipe.get_instance().config.get_cookie_same_site(None, {}) == "lax"
 
     reset()
 
@@ -281,9 +281,7 @@ async def test_same_site_values():
         recipe_list=[session.init(cookie_same_site="none")],
     )
 
-    assert (
-        SessionRecipe.get_instance().config.get_cookie_same_site(None, None) == "none"
-    )
+    assert SessionRecipe.get_instance().config.get_cookie_same_site(None, {}) == "none"
 
     reset()
 
@@ -299,7 +297,7 @@ async def test_same_site_values():
     )
 
     assert (
-        SessionRecipe.get_instance().config.get_cookie_same_site(None, None) == "strict"
+        SessionRecipe.get_instance().config.get_cookie_same_site(None, {}) == "strict"
     )
 
     reset()
@@ -355,7 +353,7 @@ async def test_same_site_values():
         ],
     )
 
-    assert SessionRecipe.get_instance().config.get_cookie_same_site(None, None) == "lax"
+    assert SessionRecipe.get_instance().config.get_cookie_same_site(None, {}) == "lax"
 
     reset()
 
@@ -372,9 +370,7 @@ async def test_same_site_values():
         ],
     )
 
-    assert (
-        SessionRecipe.get_instance().config.get_cookie_same_site(None, None) == "none"
-    )
+    assert SessionRecipe.get_instance().config.get_cookie_same_site(None, {}) == "none"
 
     reset()
 
@@ -395,7 +391,7 @@ async def test_config_values():
         recipe_list=[session.init(anti_csrf="VIA_CUSTOM_HEADER")],
     )
 
-    assert SessionRecipe.get_instance().config.get_cookie_same_site(None, None) == "lax"
+    assert SessionRecipe.get_instance().config.get_cookie_same_site(None, {}) == "lax"
     assert (
         SessionRecipe.get_instance().config.anti_csrf_function_or_string
         == "VIA_CUSTOM_HEADER"
@@ -419,7 +415,7 @@ async def test_config_values():
         ],
     )
 
-    assert SessionRecipe.get_instance().config.get_cookie_same_site(None, None) == "lax"
+    assert SessionRecipe.get_instance().config.get_cookie_same_site(None, {}) == "lax"
     assert SessionRecipe.get_instance().config.anti_csrf_function_or_string == "NONE"
     assert SessionRecipe.get_instance().config.cookie_secure
 
@@ -440,9 +436,7 @@ async def test_config_values():
         ],
     )
 
-    assert (
-        SessionRecipe.get_instance().config.get_cookie_same_site(None, None) == "none"
-    )
+    assert SessionRecipe.get_instance().config.get_cookie_same_site(None, {}) == "none"
     assert (
         SessionRecipe.get_instance().config.anti_csrf_function_or_string
         == "VIA_CUSTOM_HEADER"
@@ -466,7 +460,7 @@ async def test_config_values():
         ],
     )
 
-    assert SessionRecipe.get_instance().config.get_cookie_same_site(None, None) == "lax"
+    assert SessionRecipe.get_instance().config.get_cookie_same_site(None, {}) == "lax"
     assert SessionRecipe.get_instance().config.anti_csrf_function_or_string == "NONE"
     assert SessionRecipe.get_instance().config.cookie_secure
 
@@ -487,7 +481,7 @@ async def test_config_values():
         ],
     )
 
-    assert SessionRecipe.get_instance().config.get_cookie_same_site(None, None) == "lax"
+    assert SessionRecipe.get_instance().config.get_cookie_same_site(None, {}) == "lax"
     assert SessionRecipe.get_instance().config.anti_csrf_function_or_string == "NONE"
     assert not SessionRecipe.get_instance().config.cookie_secure
 
@@ -506,7 +500,7 @@ async def test_config_values():
         recipe_list=[session.init(anti_csrf="VIA_CUSTOM_HEADER")],
     )
 
-    assert SessionRecipe.get_instance().config.get_cookie_same_site(None, None) == "lax"
+    assert SessionRecipe.get_instance().config.get_cookie_same_site(None, {}) == "lax"
     assert (
         SessionRecipe.get_instance().config.anti_csrf_function_or_string
         == "VIA_CUSTOM_HEADER"
@@ -530,9 +524,7 @@ async def test_config_values():
         ],
     )
 
-    assert (
-        SessionRecipe.get_instance().config.get_cookie_same_site(None, None) == "none"
-    )
+    assert SessionRecipe.get_instance().config.get_cookie_same_site(None, {}) == "none"
     assert (
         SessionRecipe.get_instance().config.anti_csrf_function_or_string
         == "VIA_CUSTOM_HEADER"
@@ -556,7 +548,7 @@ async def test_config_values():
         ],
     )
 
-    assert SessionRecipe.get_instance().config.get_cookie_same_site(None, None) == "lax"
+    assert SessionRecipe.get_instance().config.get_cookie_same_site(None, {}) == "lax"
     assert SessionRecipe.get_instance().config.anti_csrf_function_or_string == "NONE"
     assert not SessionRecipe.get_instance().config.cookie_secure
 
@@ -577,9 +569,7 @@ async def test_config_values():
         ],
     )
 
-    assert (
-        SessionRecipe.get_instance().config.get_cookie_same_site(None, None) == "none"
-    )
+    assert SessionRecipe.get_instance().config.get_cookie_same_site(None, {}) == "none"
     assert SessionRecipe.get_instance().config.cookie_secure
 
     reset()
@@ -782,9 +772,7 @@ async def test_cookie_samesite_with_ec2_public_url():
     # domain name isn't provided so browser decides to use the same host
     # which will be ec2-xx-yyy-zzz-0.compute-1.amazonaws.com
     assert SessionRecipe.get_instance().config.cookie_domain is None
-    assert (
-        SessionRecipe.get_instance().config.get_cookie_same_site(None, None) == "none"
-    )
+    assert SessionRecipe.get_instance().config.get_cookie_same_site(None, {}) == "none"
     assert SessionRecipe.get_instance().config.cookie_secure is True
 
     reset()
@@ -804,9 +792,7 @@ async def test_cookie_samesite_with_ec2_public_url():
     )
 
     assert SessionRecipe.get_instance().config.cookie_domain is None
-    assert (
-        SessionRecipe.get_instance().config.get_cookie_same_site(None, None) == "none"
-    )
+    assert SessionRecipe.get_instance().config.get_cookie_same_site(None, {}) == "none"
     assert SessionRecipe.get_instance().config.cookie_secure is False
 
     reset()
@@ -826,5 +812,5 @@ async def test_cookie_samesite_with_ec2_public_url():
     )
 
     assert SessionRecipe.get_instance().config.cookie_domain is None
-    assert SessionRecipe.get_instance().config.get_cookie_same_site(None, None) == "lax"
+    assert SessionRecipe.get_instance().config.get_cookie_same_site(None, {}) == "lax"
     assert SessionRecipe.get_instance().config.cookie_secure is False

tests/test_config_without_core.py

@@ -52,7 +52,7 @@ def test_same_site_cookie_values(
     )
 
     s = SessionRecipe.get_instance()
-    assert s.config.get_cookie_same_site(None, None) == cookie_same_site
+    assert s.config.get_cookie_same_site(None, {}) == cookie_same_site
     SessionRecipe.reset()
     MultitenancyRecipe.reset()
     Supertokens.reset()