add tests for hubspot utils

Author: surajit

hubspot_api/utils.py

@@ -34,7 +34,6 @@ def create_contact(data):
             "email": "email",
             "phone": "phone",
         }
-
         data = {contact_map[k]: v for k, v in data.items()}
         simple_public_object_input = SimplePublicObjectInput(properties=data)
         contact = api_client.crm.contacts.basic_api.create(
@@ -104,11 +103,12 @@ def get_contact_by_email(email):
         if contact.results:
             contact_detail = contact.results[0]
             contact_properties = contact_detail.properties
-            return {"id": contact_detail.id,
-                    "email": contact_properties["email"],
-                    "firstname": contact_properties["firstname"],
-                    "lastname": contact_properties["lastname"],
-                    }
+            return {
+                "id": contact_detail.id,
+                "email": contact_properties["email"],
+                "firstname": contact_properties["firstname"],
+                "lastname": contact_properties["lastname"],
+            }
         else:
             return {}
     except contacts.exceptions.ApiException as e:

tests/integrations/test_hubspot.py

@@ -0,0 +1,96 @@
+from unittest import mock
+
+import pytest
+
+from hubspot_api.utils import (
+    create_contact,
+    ContactException,
+    create_company,
+    CompanyException,
+)
+
+
+class MockHubspotContact:
+    def __init__(self, id):
+        self.id = id
+
+
+class MockHubspotCompany:
+    def __init__(self, id):
+        self.id = id
+
+
+@mock.patch("hubspot_api.utils.associate_contact_to_organization")
+@mock.patch("hubspot_api.utils.get_company_by_name")
+@mock.patch("hubspot_api.utils.api_client")
+def test_create_contact(
+    mock_api_basic_api_create,
+    mock_get_company_by_name,
+    mock_associate_contact_to_organization,
+):
+    mock_api_basic_api_create.crm.contacts.basic_api.create.return_value = (
+        MockHubspotContact(1234)
+    )
+    mock_get_company_by_name.return_value = {"id": 1234}
+    mock_associate_contact_to_organization.return_value = "ok"
+    contact = create_contact(
+        dict(
+            company_name="Test org",
+            first_name="Test",
+            last_name="User",
+            email="[email protected]",
+            phone="111111111",
+        )
+    )
+    assert contact == {"contact_id": 1234}
+
+
+@mock.patch("hubspot_api.utils.api_client")
+def test_create_contact_raises_contact_exception(mock_api_client):
+    mock_api_client.crm.contacts.basic_api.create.side_effect = ContactException(
+        "Contact Already " "exists"
+    )
+
+    with pytest.raises(ContactException) as exc:
+        create_contact(
+            dict(
+                company_name="Test org",
+                first_name="Test",
+                last_name="User",
+                email="[email protected]",
+                phone="111111111",
+            )
+        )
+    assert isinstance(exc.value, ContactException)
+    assert exc.value.args[0] == "Contact Already exists"
+
+
+@mock.patch("hubspot_api.utils.api_client")
+def test_create_company(mock_api_client):
+    mock_api_client.crm.companies.basic_api.create.return_value = MockHubspotCompany(
+        777
+    )
+    company = create_company(
+        dict(
+            name="Test org",
+            org_id="999",
+        )
+    )
+    assert company == {"company_id": 777}
+
+
+@mock.patch("hubspot_api.utils.api_client")
+def test_create_company_raises_company_exception(mock_api_client):
+    mock_api_client.crm.companies.basic_api.create.side_effect = CompanyException(
+        "Company already exists"
+    )
+    with pytest.raises(CompanyException) as exc:
+        create_company(
+            dict(
+                name="Test org",
+                org_id="999",
+            )
+        )
+
+    assert isinstance(exc.value, CompanyException)
+    assert exc.value.args[0] == "Company already exists"

tests/routes/test_email.py

@@ -37,7 +37,9 @@ def test_email_send(mock_logger_debug, mock_send_email, client, db):
 
 @mock.patch("routes.v1.email.email.send_email")
 @mock.patch("logger.log.logger.debug")
-def test_email_send_with_sendgrid_unauthorizedexception(mock_logger_debug, mock_send_email, client):
+def test_email_send_with_sendgrid_unauthorizedexception(
+    mock_logger_debug, mock_send_email, client
+):
     mock_logger_debug.return_value = "Ok"
     mock_send_email.side_effect = UnauthorizedException("Not allowed to access the API")
     response = client.post("/api/v1/email/send/", json=read_json("email_data.json"))
@@ -47,7 +49,9 @@ def test_email_send_with_sendgrid_unauthorizedexception(mock_logger_debug, mock_
 
 @mock.patch("routes.v1.email.email.send_email")
 @mock.patch("logger.log.logger.debug")
-def test_email_send_with_sendgrid_bad_request_exception(mock_logger_debug, mock_send_email, client):
+def test_email_send_with_sendgrid_bad_request_exception(
+    mock_logger_debug, mock_send_email, client
+):
     mock_logger_debug.return_value = "Ok"
     mock_send_email.side_effect = BadRequestException("Bad request")
     response = client.post("/api/v1/email/send/", json=read_json("email_data.json"))
@@ -58,7 +62,7 @@ def test_email_send_with_sendgrid_bad_request_exception(mock_logger_debug, mock_
 @mock.patch("routes.v1.email.email.send_email")
 @mock.patch("logger.log.logger.debug")
 def test_email_send_with_db_duplicate_message_id(
-        mock_logger_debug, mock_send_email, client, message
+    mock_logger_debug, mock_send_email, client, message
 ):
     mock_logger_debug.return_value = "Ok"
     sendgrid_response_mock = SendGridResponseMock(
@@ -69,6 +73,6 @@ def test_email_send_with_db_duplicate_message_id(
     assert response.status_code == 200
     assert response.json() == {
         "detail": "duplicate key value violates unique constraint "
-                  '"ix_message_message_id"\nDETAIL:  Key (message_id)=('
-                  "123657ab) already exists.\n"
+        '"ix_message_message_id"\nDETAIL:  Key (message_id)=('
+        "123657ab) already exists.\n"
     }