add test for contact exceptions

Author: surajit

tests/conftest.py

@@ -8,6 +8,8 @@
 
 import schemas.schema
 from crud.company import create_company
+from crud.contact import create_contact
+from models.payment import Organization
 from tests.test_database import SQLALCHEMY_DATABASE_URL
 
 from dependencies.dependencies import get_db
@@ -47,3 +49,19 @@ def client(db):
 @pytest.fixture
 def organization(db):
     create_company(db, schemas.schema.CreateCompany(name="Test org", org_id=12345))
+
+
+@pytest.fixture
+def contact(db):
+    organization = db.query(Organization).filter_by(name="Test org").all()[0]
+    create_contact(
+        db,
+        schemas.schema.CreateContact(
+            first_name="Test",
+            last_name="User",
+            email="[email protected]",
+            phone="2547120202002",
+            company_name=organization.name,
+        ),
+        org_id=organization.id,
+    )

tests/routes/test_contact.py

@@ -1,5 +1,8 @@
 from unittest import mock
 
+from hubspot_api.utils import ContactException
+from models.contact import Contact
+
 
 @mock.patch("routes.v1.contact.utils.get_contact_by_email")
 def test_get_contact_by_email(mock_get_contact_by_email, client):
@@ -43,3 +46,68 @@ def test_create_contact(
     )
     assert response.status_code == 200
     assert response.json() == {"contact_id": 12356}
+
+
+def test_create_contact_returns_duplicate_email_error(organization, contact, client):
+    response = client.post(
+        "/api/v1/contacts/",
+        json={
+            "first_name": "raaj",
+            "last_name": "das",
+            "email": "[email protected]",
+            "phone": "2547120202002",
+            "company_name": "Test org",
+        },
+    )
+    assert response.status_code == 200
+    assert response.json() == {
+        "detail": "duplicate key value violates unique constraint "
+        '"contact_email_key"\nDETAIL:  Key (email)=('
+        "[email protected]) already exists.\n"
+    }
+
+
+@mock.patch("routes.v1.contact._contact.delete_contact")
+@mock.patch("routes.v1.contact.utils.create_contact")
+def test_create_contact_raises_hubspot_contactexception(
+    mock_create_contact, mock_delete_contact, organization, client
+):
+    mock_create_contact.side_effect = ContactException(
+        "Email with this contact exists " "in Hubspot"
+    )
+    mock_delete_contact.return_value = True
+    response = client.post(
+        "/api/v1/contacts/",
+        json={
+            "first_name": "test",
+            "last_name": "user",
+            "email": "[email protected]",
+            "phone": "2547120202002",
+            "company_name": "Test org",
+        },
+    )
+    assert response.status_code == 200
+    assert response.json() == {"detail": "Email with this contact exists in Hubspot"}
+
+
+@mock.patch("routes.v1.contact.utils.create_contact")
+def test_create_contact_rollbacks_db_contact_for_hubspot_exception(
+    mock_create_contact, db, organization, client
+):
+    mock_create_contact.side_effect = ContactException(
+        "Email with this contact exists " "in Hubspot"
+    )
+    response = client.post(
+        "/api/v1/contacts/",
+        json={
+            "first_name": "test",
+            "last_name": "user",
+            "email": "[email protected]",
+            "phone": "2547120202002",
+            "company_name": "Test org",
+        },
+    )
+    contact = db.query(Contact).filter_by(email="[email protected]").all()
+    assert response.status_code == 200
+    assert response.json() == {"detail": "Email with this contact exists in Hubspot"}
+    assert contact == []