fix a11y issues

Author: NullIsOne

Components/Sources/Collection/CollectionWrappedCell.swift

@@ -28,7 +28,15 @@ public final class CollectionWrappedCell<View: ConfigurableItem>: UICollectionVi
 extension CollectionWrappedCell: CalculatableHeightItem where View: CalculatableHeightItem {
 
     public static func getHeight(forWidth width: CGFloat, with model: Model) -> CGFloat {
-        return View.getHeight(forWidth: width, with: model)
+        let nestedViewHeight = View.getHeight(forWidth: width, with: model)
+        if let alignment = (model as? AlignmentProvider)?.alignment {
+            switch alignment {
+            case .leading(let insets), .trailing(let insets), .all(let insets):
+                return nestedViewHeight + insets.top + insets.bottom
+            }
+        } else {
+            return nestedViewHeight
+        }
     }
 
 }
@@ -38,7 +46,15 @@ extension CollectionWrappedCell: CalculatableHeightItem where View: Calculatable
 extension CollectionWrappedCell: CalculatableWidthItem where View: CalculatableWidthItem {
 
     public static func getWidth(forHeight height: CGFloat, with model: View.Model) -> CGFloat {
-        return View.getWidth(forHeight: height, with: model)
+        let nestedViewWidth = View.getWidth(forHeight: height, with: model)
+        if let alignment = (model as? AlignmentProvider)?.alignment {
+            switch alignment {
+            case .leading(let insets), .trailing(let insets), .all(let insets):
+                return nestedViewWidth + insets.left + insets.right
+            }
+        } else {
+            return nestedViewWidth
+        }
     }
 
 }

Components/Sources/Table/TableWrappedCell.swift

@@ -28,7 +28,15 @@ public final class TableWrappedCell<View: ConfigurableItem>: UITableViewCell, Vi
 extension TableWrappedCell: CalculatableHeightItem where View: CalculatableHeightItem {
 
     public static func getHeight(forWidth width: CGFloat, with model: Model) -> CGFloat {
-        return View.getHeight(forWidth: width, with: model)
+        let nestedViewHeight = View.getHeight(forWidth: width, with: model)
+        if let alignment = (model as? AlignmentProvider)?.alignment {
+            switch alignment {
+            case .leading(let insets), .trailing(let insets), .all(let insets):
+                return nestedViewHeight + insets.top + insets.bottom
+            }
+        } else {
+            return nestedViewHeight
+        }
     }
 
 }

Example/ReactiveDataDisplayManager/Application/AppDelegate.swift

@@ -19,6 +19,7 @@ class AppDelegate: UIResponder, UIApplicationDelegate {
         UITabBar.appearance().tintColor = .rddm
         UITableView.appearance().sectionIndexColor = .rddm
         UICollectionView.appearance().tintColor = .rddm
+        UITextView.appearance().adjustsFontForContentSizeCategory = true
         UILabel.appearance().adjustsFontForContentSizeCategory = true
         UIButton.appearance().adjustsImageSizeForAccessibilityContentSizeCategory = true
 

Example/ReactiveDataDisplayManager/Collection/CollectionViewController/CollectionViewController.swift

@@ -64,7 +64,7 @@ private extension CollectionViewController {
         CollectionGenerators {
             titles.map { title -> CollectionCellGenerator in
                 // Create generator
-                let generator = TitleCollectionViewCell.rddm.baseGenerator(with: title)
+                let generator = TitleCollectionViewCell.rddm.calculatableHeightGenerator(with: title, referencedWidth: 100)
                 generator.didSelectEvent += {
                     debugPrint("\(title) selected")
                 }

Example/ReactiveDataDisplayManager/Collection/StackCellExampleCollectionViewController/StackCellExampleCollectionViewController.swift

@@ -53,7 +53,7 @@ final class StackCellExampleCollectionViewController: UIViewController {
 
     override func viewDidLoad() {
         super.viewDidLoad()
-        title = "Stack cell collection"
+        title = "Stack incide collection"
 
         let flowLayout = makeFlowLayout()
         collectionView.setCollectionViewLayout(flowLayout, animated: false)

Example/ReactiveDataDisplayManager/Table/ComponentsOverviewTableViewController/ComponentsOverviewTableViewController.swift

@@ -100,19 +100,6 @@ final class ComponentsOverviewTableViewController: UIViewController {
                                      bottom: 3,
                                      right: 5))
         property.text(.string("Lorem ipsum dolor sit amet Lorem ipsum dolor sit amet"))
-
-        let tapAction: () -> Void = {
-            if var topController = UIApplication.shared.keyWindow?.rootViewController {
-                while let presentedViewController = topController.presentedViewController {
-                    topController = presentedViewController
-                }
-
-                let alertController = UIAlertController(title: "MessageView Tapped", message: "The MessageView was tapped!", preferredStyle: .alert)
-                alertController.addAction(UIAlertAction(title: "OK", style: .default, handler: nil))
-                topController.present(alertController, animated: true, completion: nil)
-            }
-        }
-
     }
 
     private lazy var sentMessageGenerator = MessageView.rddm.tableGenerator(with: sentMessageModel, and: .class)

Example/ReactiveDataDisplayManager/Table/DiffableTableViewController/DiffableTableViewController.swift

@@ -113,9 +113,9 @@ private extension DiffableTableViewController {
                 generators: generators,
                 header: EmptyTableHeaderGenerator(uniqueId: Constants.sectionId.appending("header")),
                 footer: EmptyTableFooterGenerator(uniqueId: Constants.sectionId.appending("footer"))
-            ).decorate(with: .space(model: .init(size: .height(16), color: .rddm)),
+            ).decorate(with: .space(model: .init(size: .height(32), color: .rddm)),
                        at: .end,
-                       and: .each)
+                       and: .first)
             .erased()
         }
 

Example/ReactiveDataDisplayManager/Table/StackCellExampleViewController/StackCellExampleViewController.swift

@@ -34,7 +34,7 @@ final class StackCellExampleViewController: UIViewController {
 
     override func viewDidLoad() {
         super.viewDidLoad()
-        title = "Stack cell example view controller"
+        title = "Stack inside table"
         tableView.accessibilityIdentifier = "Stack_Cell_Example_View_Controller"
         fillAdapter()
     }

Example/ReactiveDataDisplayManager/Table/TwoDirectionPaginatableTableViewController/TwoDirectionPaginatableTableViewController.swift

@@ -64,7 +64,7 @@ final class TwoDirectionPaginatableTableViewController: UIViewController {
 
     override func viewDidLoad() {
         super.viewDidLoad()
-        title = "Table with two directions pagination"
+        title = "two directional pagination"
 
         configureActivityIndicatorIfNeeded()
         loadFirstPage()