Accesibility Tweaks (#197)

- If the source has gone dont use it in ally either. This fixes an
  async rebuild accessible case in short circuit.

- Toggle button and radio button label improved

Author: baconpaul

include/sst/jucegui/accessibility/AccessibilityKeyboardEdits.h

@@ -33,6 +33,7 @@ template <typename T> struct AccessibilityKeyboardEditSupport
         enum AccessibleKeyEditAction
         {
             None,
+            Trigger,
             Increase,
             Decrease,
             ToMax,
@@ -111,6 +112,11 @@ template <typename T> struct AccessibilityKeyboardEditSupport
             return {Action::ToDefault};
         }
 
+        if (key.getKeyCode() == juce::KeyPress::returnKey)
+        {
+            return {Action::Trigger};
+        }
+
         return {};
     }
 };

src/sst/jucegui/components/ContinuousParamEditor.cpp

@@ -302,27 +302,43 @@ struct ContinuousParamEditorAH : public juce::AccessibilityHandler
         ContinuousParamEditor *slider;
 
         bool isReadOnly() const override { return false; }
-        double getCurrentValue() const override { return slider->continuous()->getValue(); }
+        double getCurrentValue() const override
+        {
+            if (!slider->continuous())
+                return 0;
+            return slider->continuous()->getValue();
+        }
         void setValue(double newValue) override
         {
+            if (!slider->continuous())
+                return;
+
             slider->onBeginEdit();
             slider->continuous()->setValueFromGUI(newValue);
             slider->notifyAccessibleChange();
             slider->onEndEdit();
         }
         juce::String getCurrentValueAsString() const override
         {
+            if (!slider->continuous())
+                return "null";
+
             return slider->continuous()->getValueAsString();
         }
         void setValueAsString(const juce::String &newValue) override
         {
+            if (!slider->continuous())
+                return;
+
             slider->onBeginEdit();
             slider->continuous()->setValueAsString(newValue.toStdString());
             slider->notifyAccessibleChange();
             slider->onEndEdit();
         }
         AccessibleValueRange getRange() const override
         {
+            if (!slider->continuous())
+                return {{0, 1}, 1};
             return {{slider->continuous()->getMin(), slider->continuous()->getMax()},
                     slider->continuous()->getMinMaxRange() * 0.01};
         }
@@ -342,6 +358,9 @@ struct ContinuousParamEditorAH : public juce::AccessibilityHandler
 
     void resetToDefault()
     {
+        if (!slider->continuous())
+            return;
+
         slider->continuous()->setValueFromGUI(slider->continuous()->getDefaultValue());
         slider->notifyAccessibleChange();
     }

src/sst/jucegui/components/DiscreteParamEditor.cpp

@@ -103,6 +103,8 @@ struct DiscreteParamEditorAH : public juce::AccessibilityHandler
         double getCurrentValue() const override { return slider->data->getValue(); }
         void setValue(double newValue) override
         {
+            if (!slider->data)
+                return;
             slider->onBeginEdit();
             slider->data->setValueFromGUI(newValue);
             slider->notifyAccessibleChange();
@@ -111,10 +113,16 @@ struct DiscreteParamEditorAH : public juce::AccessibilityHandler
         }
         juce::String getCurrentValueAsString() const override
         {
+            if (!slider->data)
+                return "-null-";
+
             return slider->data->getValueAsString();
         }
         void setValueAsString(const juce::String &newValue) override
         {
+            if (!slider->data)
+                return;
+
             slider->onBeginEdit();
             slider->data->setValueAsString(newValue.toStdString());
             slider->notifyAccessibleChange();
@@ -123,6 +131,8 @@ struct DiscreteParamEditorAH : public juce::AccessibilityHandler
         }
         AccessibleValueRange getRange() const override
         {
+            if (!slider->data)
+                return {{0, 1}, 1};
             return {{(double)slider->data->getMin(), (double)slider->data->getMax()}, 1};
         }
 
@@ -141,6 +151,9 @@ struct DiscreteParamEditorAH : public juce::AccessibilityHandler
 
     void resetToDefault()
     {
+        if (!slider->data)
+            return;
+
         slider->data->setValueFromGUI(slider->data->getDefaultValue());
         slider->repaint();
         slider->notifyAccessibleChange();

src/sst/jucegui/components/ToggleButton.cpp

@@ -192,6 +192,16 @@ bool ToggleButton::keyPressed(const juce::KeyPress &e)
         auto a = accessibleEdit(e);
         switch (a.action)
         {
+        case Action::Trigger:
+        {
+            onBeginEdit();
+            data->setValueFromGUI(!data->getValue());
+            notifyAccessibleChange();
+            repaint();
+            onEndEdit();
+            return true;
+        }
+        break;
         case Action::Increase:
         case Action::ToMax:
         {

src/sst/jucegui/components/ToggleButtonRadioGroup.cpp

@@ -33,7 +33,7 @@ struct subordinateDiscrete : data::Discrete
     }
     virtual ~subordinateDiscrete() = default;
 
-    std::string getLabel() const override { return "unused"; }
+    std::string getLabel() const override { return under->getValueAsStringFor(idx); }
     int getValue() const override { return under->getValue() == idx ? 1 : 0; }
 
     void setValueFromGUI(const int &f) override
@@ -91,6 +91,7 @@ void ToggleButtonRadioGroup::dataChanged()
         {
             auto b = std::make_unique<ToggleButton>();
             b->setLabel(data->getValueAsStringFor(i));
+            b->setTitle(data->getValueAsStringFor(i));
             addAndMakeVisible(*b);
 
             auto sd = std::make_unique<subordinateDiscrete>(data, i);