[Fix] Repository: Prevent duplicate non-deletable ref_ids (ILIAS-eLearning#11147)

mjansenDatabay · web-flow · commit e4dbb70093fa · 2026-02-20T14:57:38.000+01:00
diff --git a/components/ILIAS/Repository/Deletion/PermissionStandardAdapter.php b/components/ILIAS/Repository/Deletion/PermissionStandardAdapter.php
@@ -41,6 +41,7 @@ public function getRefIdsWithoutDeletePermission(array $ids): array
             if (!$this->access->checkAccess('delete', "", $id)) {
                 $not_deletable[] = (int) $id;
             }
+
             if ($this->tree->isInTree($id)) {
                 $node_data = $this->tree->getNodeData($id);
                 $subtree_nodes = $this->tree->getSubTree($node_data);
@@ -55,7 +56,8 @@ public function getRefIdsWithoutDeletePermission(array $ids): array
                 }
             }
         }
-        return $not_deletable;
+
+        return array_unique($not_deletable);
     }
 
     public function revokePermission(int $ref_id): void

Original file line number	Diff line number	Diff line change
`@@ -41,6 +41,7 @@ public function getRefIdsWithoutDeletePermission(array $ids): array`
`41`	`41`	`if (!$this->access->checkAccess('delete', "", $id)) {`
`42`	`42`	`$not_deletable[] = (int) $id;`
`43`	`43`	`}`
	`44`	`+`
`44`	`45`	`if ($this->tree->isInTree($id)) {`
`45`	`46`	`$node_data = $this->tree->getNodeData($id);`
`46`	`47`	`$subtree_nodes = $this->tree->getSubTree($node_data);`
`@@ -55,7 +56,8 @@ public function getRefIdsWithoutDeletePermission(array $ids): array`
`55`	`56`	`}`
`56`	`57`	`}`
`57`	`58`	`}`
`58`		`- return $not_deletable;`
	`59`	`+`
	`60`	`+ return array_unique($not_deletable);`
`59`	`61`	`}`
`60`	`62`
`61`	`63`	`public function revokePermission(int $ref_id): void`