fix: revision injection was broken due to entrypoint change (#72)

* fix: revision injection was broken due to entrypoint change

* ci: use nolint comment

* ci: use nolint comment for clarify

Author: sushichan044

.golangci.yml

@@ -512,12 +512,6 @@ linters:
           - gosec
           - noctx
           - wrapcheck
-      - text: 'reassigning variable VersionPrinter'
-        linters:
-          - reassign
-      - text: 'revision is a global variable'
-        linters:
-          - gochecknoglobals
       - text: 'BinaryPath is a global variable'
         linters:
           - gochecknoglobals

.goreleaser.yaml

@@ -30,7 +30,6 @@ builds:
       - darwin
     ldflags:
       - -s -w
-      - -X main.version={{.Version}}
       - -X main.revision={{.ShortCommit}}
 
 archives:

cmd/ajisai/root.go

@@ -14,13 +14,8 @@ import (
 	"github.com/sushichan044/ajisai/version"
 )
 
-var (
-	// noglobals error is suppressed by golangci-lint.
-	revision = "dev"
-)
-
-func Run(args []string) error {
-	// reassign error is suppressed by golangci-lint.
+func Run(args []string, revision string) error {
+	//nolint:reassign // This is expected usecase by urfave/cli.
 	cli.VersionPrinter = func(cmd *cli.Command) {
 		root := cmd.Root()
 		fmt.Fprintf(root.Writer, "%s version %s (revision:%s)\n", root.Name, root.Version, revision)

main.go

@@ -7,8 +7,13 @@ import (
 	"github.com/sushichan044/ajisai/cmd/ajisai"
 )
 
+var (
+	//nolint:gochecknoglobals // This value is overridden by goreleaser.
+	revision = "dev"
+)
+
 func main() {
-	if err := ajisai.Run(os.Args); err != nil {
+	if err := ajisai.Run(os.Args, revision); err != nil {
 		fmt.Fprintf(os.Stderr, "Error: %v\n", err)
 		os.Exit(1)
 	}