Skip to content

Commit 0278c38

Browse files
committed
change cpu_time unit (us to ms)
Signed-off-by: Sunyanan Choochotkaew <[email protected]>
1 parent dc4d631 commit 0278c38

File tree

7 files changed

+9
-9
lines changed

7 files changed

+9
-9
lines changed

cmd/cmd_util.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,7 @@ def summary_validation(validate_df):
5858
# CPU instruction is mainly used for ratio.
5959
# reference: https://github.com/sustainable-computing-io/kepler/blob/0b328cf7c79db9a11426fb80a1a922383e40197c/pkg/config/config.go#L92
6060
"hwc": "kepler_container_cpu_instructions_total",
61-
"bpf": "kepler_container_bpf_cpu_time_us_total",
61+
"bpf": "kepler_container_bpf_cpu_time_ms_total",
6262
}
6363
metric_to_validate_power = {
6464
"intel_rapl": "kepler_node_package_joules_total",

manifests/kepler/patch/patch-ci.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,4 +17,4 @@ spec:
1717
containers:
1818
- name: kepler-exporter
1919
imagePullPolicy: IfNotPresent
20-
image: quay.io/sustainable_computing_io/kepler:latest-libbpf
20+
image: quay.io/sustainable_computing_io/kepler:latest

model_training/script.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
set -e
44
# Supported CLUSTER_PROVIDER are kind,microshift
55
export CLUSTER_PROVIDER=${CLUSTER_PROVIDER:-kind}
6-
export IMAGE_TAG=${IMAGE_TAG:-latest-libbpf}
6+
export IMAGE_TAG=${IMAGE_TAG:-latest}
77
export KIND_CLUSTER_NAME=${KIND_CLUSTER_NAME:-kind-for-training}
88
export KIND_REGISTRY_NAME=${KIND_REGISTRY_NAME:-kind-registry-for-training}
99
export REGISTRY_PORT=${REGISTRY_PORT:-5101}

src/util/prom_types.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@
3535

3636
usage_ratio_query = "kepler_container_cpu_usage_per_package_ratio"
3737
# mostly available
38-
valid_container_query = "kepler_container_bpf_cpu_time_us_total"
38+
valid_container_query = "kepler_container_bpf_cpu_time_ms_total"
3939
node_info_query = "kepler_node_node_info"
4040
cpu_frequency_info_query = "kepler_node_cpu_scaling_frequency_hertz"
4141

src/util/train_types.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@
1616

1717
COUNTER_FEAUTRES = ["cache_miss", "cpu_cycles", "cpu_instructions"]
1818
CGROUP_FEATURES = ["cgroupfs_cpu_usage_us", "cgroupfs_memory_usage_bytes", "cgroupfs_system_cpu_usage_us", "cgroupfs_user_cpu_usage_us"]
19-
BPF_FEATURES = ["bpf_cpu_time_us", "bpf_page_cache_hit"]
19+
BPF_FEATURES = ["bpf_cpu_time_ms", "bpf_page_cache_hit"]
2020
IRQ_FEATURES = ["bpf_block_irq", "bpf_net_rx_irq", "bpf_net_tx_irq"]
2121
ACCELERATE_FEATURES = ['accelerator_intel_qat']
2222
WORKLOAD_FEATURES = COUNTER_FEAUTRES + CGROUP_FEATURES + BPF_FEATURES + IRQ_FEATURES + ACCELERATE_FEATURES
@@ -97,8 +97,8 @@ def is_single_source_feature_group(fg):
9797
FeatureGroup.WorkloadOnly: "cpu_instructions",
9898
FeatureGroup.CounterOnly: "cpu_instructions",
9999
FeatureGroup.CgroupOnly: "cgroupfs_cpu_usage_us",
100-
FeatureGroup.BPFOnly: "bpf_cpu_time_us",
101-
FeatureGroup.BPFIRQ: "bpf_cpu_time_us",
100+
FeatureGroup.BPFOnly: "bpf_cpu_time_ms",
101+
FeatureGroup.BPFIRQ: "bpf_cpu_time_ms",
102102
FeatureGroup.CounterIRQCombined: "cpu_instructions",
103103
FeatureGroup.Basic: "cpu_instructions",
104104
FeatureGroup.AcceleratorOnly: "accelerator_intel_qat",

tests/data/prom_output/idle.json

Lines changed: 1 addition & 1 deletion
Large diffs are not rendered by default.

tests/data/prom_output/prom_response.json

Lines changed: 1 addition & 1 deletion
Large diffs are not rendered by default.

0 commit comments

Comments
 (0)