Skip to content

Commit 0957464

Browse files
authored
Merge pull request #429 from vprashar2929/add-yamllint
feat(ci): Add yamllint workflow
2 parents 6955354 + 2d882b8 commit 0957464

File tree

82 files changed

+2200
-2194
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

82 files changed

+2200
-2194
lines changed

.github/ISSUE_TEMPLATE/bug_report.yaml

Lines changed: 5 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -113,7 +113,6 @@ body:
113113
</details>
114114
validations:
115115
required: false
116-
117116
- type: textarea
118117
id: kubeVersion
119118
attributes:
@@ -151,20 +150,17 @@ body:
151150
$ KEPLER_NAMESPACE=kepler
152151
153152
# provide kepler configmap
154-
$ kubectl get configmap kepler-cfm -n ${KEPLER_NAMESPACE}
153+
$ kubectl get configmap kepler-cfm -n ${KEPLER_NAMESPACE}
155154
# paste output here
156-
157-
# provide kepler model server configmap if Kepler Model Server is deployed
158-
$ kubectl get configmap kepler-model-server-cfm -n ${KEPLER_NAMESPACE}
155+
# provide kepler model server configmap if Kepler Model Server is deployed
156+
$ kubectl get configmap kepler-model-server-cfm -n ${KEPLER_NAMESPACE}
159157
# paste output here
160-
161158
# provide kepler deployment description
162-
$ kubectl describe deployment kepler-exporter -n ${KEPLER_NAMESPACE}
159+
$ kubectl describe deployment kepler-exporter -n ${KEPLER_NAMESPACE}
163160
```
164-
165161
For standalone:
166162
# put your Kepler command argument here
167163
168164
</details>
169165
validations:
170-
required: false
166+
required: false

.github/ISSUE_TEMPLATE/document.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,4 +22,4 @@ body:
2222
attributes:
2323
label: How do you suggest this is fixed?
2424
validations:
25-
required: false
25+
required: false

.github/ISSUE_TEMPLATE/feature_request.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,4 +18,4 @@ body:
1818
attributes:
1919
label: Why is this needed?
2020
validations:
21-
required: true
21+
required: true

.github/dependabot.yml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,4 +12,3 @@ updates:
1212
directory: /
1313
schedule:
1414
interval: daily
15-

.github/workflows/build-push.yml

Lines changed: 55 additions & 55 deletions
Original file line numberDiff line numberDiff line change
@@ -1,33 +1,33 @@
11
name: Build-Push Kepler Model Server Image
22

3-
on:
3+
on: # yamllint disable-line rule:truthy
44
workflow_call:
55
secrets:
66
docker_username:
7-
description: 'Docker username'
7+
description: Docker username
88
required: false
99
docker_password:
10-
description: 'Docker password'
10+
description: Docker password
1111
required: false
1212
inputs:
1313
base_change:
14-
description: 'Change flag on base image'
14+
description: Change flag on base image
1515
required: true
1616
type: string
1717
s3_change:
18-
description: 'Change flag on s3 image'
18+
description: Change flag on s3 image
1919
required: true
2020
type: string
2121
image_repo:
22-
description: 'The image repo to use'
22+
description: The image repo to use
2323
required: true
2424
type: string
2525
image_tag:
26-
description: 'The image tag to use'
26+
description: The image tag to use
2727
required: true
2828
type: string
2929
push:
30-
description: 'Push image'
30+
description: Push image
3131
required: false
3232
type: string
3333
default: false
@@ -68,58 +68,58 @@ jobs:
6868
exists: ${{ steps.check-base-exist.outputs.exists }}
6969

7070
steps:
71-
- name: Check if Docker base image exists
72-
id: check-base-exist
73-
run: |
74-
if docker pull ${{ env.base_image }}; then
75-
echo "exists=true" >> "$GITHUB_OUTPUT"
76-
else
77-
echo "exists=false" >> "$GITHUB_OUTPUT"
78-
fi
71+
- name: Check if Docker base image exists
72+
id: check-base-exist
73+
run: |
74+
if docker pull ${{ env.base_image }}; then
75+
echo "exists=true" >> "$GITHUB_OUTPUT"
76+
else
77+
echo "exists=false" >> "$GITHUB_OUTPUT"
78+
fi
7979
8080
build:
8181
runs-on: ubuntu-latest
8282
needs: [check-secret, check-base-exist]
8383
steps:
84-
- name: checkout
85-
uses: actions/checkout@v4
86-
- name: set up QEMU
87-
uses: docker/setup-qemu-action@v3
88-
- name: set up Docker Buildx
89-
uses: docker/setup-buildx-action@v3
90-
- name: Login to Docker
91-
if: ${{ needs.check-secret.outputs.available == 'true' }}
92-
uses: docker/login-action@v3
93-
with:
84+
- name: checkout
85+
uses: actions/checkout@v4
86+
- name: set up QEMU
87+
uses: docker/setup-qemu-action@v3
88+
- name: set up Docker Buildx
89+
uses: docker/setup-buildx-action@v3
90+
- name: Login to Docker
91+
if: ${{ needs.check-secret.outputs.available == 'true' }}
92+
uses: docker/login-action@v3
93+
with:
9494
registry: ${{ inputs.image_repo }}
9595
username: ${{ secrets.docker_username }}
9696
password: ${{ secrets.docker_password }}
97-
- name: Build-push s3 image
98-
if: ${{ needs.check-secret.outputs.available == 'true' && env.s3_change == 'true' }}
99-
uses: docker/build-push-action@v6
100-
with:
101-
platforms: linux/amd64
102-
push: ${{ inputs.push }}
103-
tags: ${{ env.s3_image }}
104-
context: model_training/s3
105-
file: model_training/s3/Dockerfile
106-
- name: Build-push base image
107-
if: ${{ (needs.check-secret.outputs.available == 'true') && ((needs.check-base-exist.outputs.exists == 'false') || (env.base_change == 'true')) }}
108-
uses: docker/build-push-action@v6
109-
with:
110-
platforms: linux/amd64
111-
push: true
112-
tags: ${{ env.base_image }}
113-
file: dockerfiles/Dockerfile.base
114-
- name: Replace value in file
115-
if: ${{ (needs.check-secret.outputs.available == 'true') && ((needs.check-base-exist.outputs.exists == 'false') || (env.base_change == 'true')) }}
116-
run: |
117-
sed -i "s|quay.io/sustainable_computing_io/kepler_model_server_base:latest|${{ env.base_image }}|" dockerfiles/Dockerfile
118-
- name: Build-push image
119-
uses: docker/build-push-action@v6
120-
with:
121-
context: .
122-
platforms: linux/amd64
123-
push: ${{ inputs.push }}
124-
tags: ${{ env.image }}
125-
file: dockerfiles/Dockerfile
97+
- name: Build-push s3 image
98+
if: ${{ needs.check-secret.outputs.available == 'true' && env.s3_change == 'true' }}
99+
uses: docker/build-push-action@v6
100+
with:
101+
platforms: linux/amd64
102+
push: ${{ inputs.push }}
103+
tags: ${{ env.s3_image }}
104+
context: model_training/s3
105+
file: model_training/s3/Dockerfile
106+
- name: Build-push base image
107+
if: ${{ (needs.check-secret.outputs.available == 'true') && ((needs.check-base-exist.outputs.exists == 'false') || (env.base_change == 'true')) }}
108+
uses: docker/build-push-action@v6
109+
with:
110+
platforms: linux/amd64
111+
push: true
112+
tags: ${{ env.base_image }}
113+
file: dockerfiles/Dockerfile.base
114+
- name: Replace value in file
115+
if: ${{ (needs.check-secret.outputs.available == 'true') && ((needs.check-base-exist.outputs.exists == 'false') || (env.base_change == 'true')) }}
116+
run: |
117+
sed -i "s|quay.io/sustainable_computing_io/kepler_model_server_base:latest|${{ env.base_image }}|" dockerfiles/Dockerfile
118+
- name: Build-push image
119+
uses: docker/build-push-action@v6
120+
with:
121+
context: .
122+
platforms: linux/amd64
123+
push: ${{ inputs.push }}
124+
tags: ${{ env.image }}
125+
file: dockerfiles/Dockerfile

.github/workflows/collect-data-self-hosted.yml

Lines changed: 26 additions & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -1,44 +1,44 @@
11
name: Self-hosted Collect Data Workflow
22

3-
on:
3+
on: # yamllint disable-line rule:truthy
44
workflow_call:
55
secrets:
66
self_hosted_github_token:
7-
description: 'The GitHub token to use'
7+
description: The GitHub token to use
88
required: true
99
aws_access_key_id:
10-
description: 'The AWS access key id to use'
10+
description: The AWS access key id to use
1111
required: true
1212
aws_secret_access_key:
13-
description: 'The AWS secret access key to use'
13+
description: The AWS secret access key to use
1414
required: true
1515
security_group_id:
16-
description: 'The AWS security group id to use'
16+
description: The AWS security group id to use
1717
required: true
1818
aws_region:
19-
description: 'The AWS region to use'
19+
description: The AWS region to use
2020
required: true
2121
inputs:
2222
github_repo:
23-
description: 'The GitHub repo to use'
23+
description: The GitHub repo to use
2424
required: true
2525
type: string
2626
ami_id:
27-
description: 'The AMI ID to use for the EC2 instance'
27+
description: The AMI ID to use for the EC2 instance
2828
required: true
2929
type: string
3030
instance_type:
31-
description: 'The instance type to use for the EC2 instance'
31+
description: The instance type to use for the EC2 instance
3232
required: true
3333
type: string
3434
model_server_image:
35-
description: 'Kepler Model Server image'
35+
description: Kepler Model Server image
3636
required: true
3737
type: string
3838

3939
env:
4040
KUBECONFIG: /tmp/kubeconfig
41-
41+
4242
jobs:
4343
setup-runner:
4444
name: Setup Self Hosted Runner
@@ -52,18 +52,18 @@ jobs:
5252
uses: sustainable-computing-io/aws_ec2_self_hosted_runner@v4
5353
id: create-runner
5454
with:
55-
action: "create"
56-
aws_region: ${{ secrets.aws_region }}
57-
github_token: ${{ secrets.self_hosted_github_token }}
58-
aws_access_key_id: ${{ secrets.aws_access_key_id }}
59-
aws_secret_access_key: ${{ secrets.aws_secret_access_key }}
60-
security_group_id: ${{ secrets.security_group_id }}
61-
github_repo: ${{ inputs.github_repo }}
62-
ami_id: ${{ inputs.ami_id }}
63-
instance_type: ${{ inputs.instance_type }}
64-
create_s3_bucket: "false"
65-
spot_instance_only: "true"
66-
root_volume_size: "100"
55+
action: create
56+
aws_region: ${{ secrets.aws_region }}
57+
github_token: ${{ secrets.self_hosted_github_token }}
58+
aws_access_key_id: ${{ secrets.aws_access_key_id }}
59+
aws_secret_access_key: ${{ secrets.aws_secret_access_key }}
60+
security_group_id: ${{ secrets.security_group_id }}
61+
github_repo: ${{ inputs.github_repo }}
62+
ami_id: ${{ inputs.ami_id }}
63+
instance_type: ${{ inputs.instance_type }}
64+
create_s3_bucket: "false"
65+
spot_instance_only: "true"
66+
root_volume_size: "100"
6767

6868
- name: Print Output
6969
id: output
@@ -165,7 +165,7 @@ jobs:
165165
id: unregister
166166
uses: sustainable-computing-io/aws_ec2_self_hosted_runner@v4
167167
with:
168-
action: "unregister"
168+
action: unregister
169169
runner_name: ${{ needs.setup-runner.outputs.runner_name }}
170170
github_token: ${{ secrets.self_hosted_github_token }}
171171
github_repo: ${{ inputs.github_repo }}
@@ -174,7 +174,7 @@ jobs:
174174
id: terminate
175175
uses: sustainable-computing-io/aws_ec2_self_hosted_runner@v4
176176
with:
177-
action: "terminate"
177+
action: terminate
178178
aws_access_key_id: ${{ secrets.aws_access_key_id }}
179179
aws_secret_access_key: ${{ secrets.aws_secret_access_key }}
180-
instance_id: ${{ needs.setup-runner.outputs.instance_id }}
180+
instance_id: ${{ needs.setup-runner.outputs.instance_id }}

.github/workflows/collect-train.yml

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
# manually run on collect needed
2-
on:
2+
on: # yamllint disable-line rule:truthy
33
workflow_dispatch:
44

55
jobs:
@@ -11,7 +11,7 @@ jobs:
1111
max-parallel: 1
1212
with:
1313
instance_type: ${{ matrix.instance_type }}
14-
ami_id: 'ami-0e4d0bb9670ea8db0'
14+
ami_id: ami-0e4d0bb9670ea8db0
1515
github_repo: ${{ github.repository }}
1616
model_server_image: ${{ vars.IMAGE_REPO }}/kepler_model_server:latest
1717
secrets:
@@ -20,7 +20,7 @@ jobs:
2020
aws_secret_access_key: ${{ secrets.AWS_SECRET_ACCESS_KEY }}
2121
security_group_id: ${{ secrets.AWS_SECURITY_GROUP_ID }}
2222
aws_region: ${{ secrets.AWS_REGION }}
23-
23+
2424
train-model:
2525
needs: [collect-data]
2626
strategy:
@@ -30,12 +30,12 @@ jobs:
3030
with:
3131
pipeline_name: std_v0.7.11
3232
instance_type: ${{ matrix.instance_type }}
33-
ami_id: 'ami-0e4d0bb9670ea8db0'
33+
ami_id: ami-0e4d0bb9670ea8db0
3434
github_repo: ${{ github.repository }}
3535
model_server_image: ${{ vars.IMAGE_REPO }}/kepler_model_server:latest
3636
trainers: LogisticRegressionTrainer,ExponentialRegressionTrainer,SGDRegressorTrainer,GradientBoostingRegressorTrainer,XgboostFitTrainer
3737
secrets:
3838
self_hosted_github_token: ${{ secrets.GH_SELF_HOSTED_RUNNER_TOKEN }}
3939
aws_access_key_id: ${{ secrets.AWS_ACCESS_KEY_ID }}
4040
aws_secret_access_key: ${{ secrets.AWS_SECRET_ACCESS_KEY }}
41-
aws_region: ${{ secrets.AWS_REGION }}
41+
aws_region: ${{ secrets.AWS_REGION }}

.github/workflows/commit-msg.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
name: Commit message check
22

3-
on:
3+
on: # yamllint disable-line rule:truthy
44
pull_request:
55

66
jobs:

0 commit comments

Comments
 (0)