Skip to content

Commit f9da980

Browse files
committed
fix: remove remaining intel_rapl source in script
Signed-off-by: Sunyanan Choochotkaew <[email protected]>
1 parent 7f134ce commit f9da980

File tree

5 files changed

+14
-8
lines changed

5 files changed

+14
-8
lines changed

model_training/script.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ declare KIND_CLUSTER_NAME=${KIND_CLUSTER_NAME:-"kind-for-training"}
1616
declare KIND_REGISTRY_NAME=${KIND_REGISTRY_NAME:-"kind-registry-for-training"}
1717

1818
declare PROM_SERVER=${PROM_SERVER:-"http://localhost:9090"}
19-
declare ENERGY_SOURCE=${ENERGY_SOURCE:-"intel_rapl,acpi"}
19+
declare ENERGY_SOURCE=${ENERGY_SOURCE:-"rapl-sysfs,acpi"}
2020

2121
declare VERSION=${VERSION:-"latest"}
2222
declare PIPELINE_PREFIX=${PIPELINE_PREFIX:-"std_"}

src/kepler_model/estimate/estimator.py

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414
from kepler_model.estimate.model_server_connector import is_model_server_enabled, make_request
1515
from kepler_model.util.config import SERVE_SOCKET, download_path, set_env_from_model_config
1616
from kepler_model.util.loader import get_download_output_path
17-
from kepler_model.util.train_types import ModelOutputType, is_output_type_supported
17+
from kepler_model.util.train_types import ModelOutputType, convert_enery_source, is_output_type_supported
1818

1919
###############################################
2020
# power request
@@ -57,9 +57,7 @@ def handle_request(data: str) -> dict:
5757
return {"powers": dict(), "msg": msg}
5858

5959
output_type = ModelOutputType[power_request.output_type]
60-
# TODO: need revisit if get more than one rapl energy source
61-
if power_request.energy_source is None or "rapl" in power_request.energy_source:
62-
power_request.energy_source = "rapl-sysfs"
60+
power_request.energy_source = convert_enery_source(power_request.energy_source)
6361

6462
if output_type.name not in loaded_model:
6563
loaded_model[output_type.name] = dict()

src/kepler_model/estimate/model_server_connector.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@
55

66
import requests
77

8+
from kepler_model.server.model_server import ModelListParam
89
from kepler_model.util.config import (
910
download_path,
1011
get_model_server_list_endpoint,
@@ -13,7 +14,7 @@
1314
)
1415
from kepler_model.util.loader import get_download_output_path
1516
from kepler_model.util.train_types import ModelOutputType
16-
from kepler_model.server.model_server import ModelListParam
17+
1718

1819
# discover_spec: determine node spec in json format (refer to NodeTypeSpec)
1920
def discover_spec():

src/kepler_model/server/model_server.py

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,9 @@
11
import codecs
2+
import enum
23
import logging
34
import os
45
import shutil
56
import sys
6-
import enum
77

88
import click
99
import requests
@@ -39,6 +39,7 @@
3939
FeatureGroups,
4040
ModelOutputType,
4141
PowerSourceMap,
42+
convert_enery_source,
4243
get_valid_feature_groups,
4344
weight_support_trainers,
4445
)
@@ -52,7 +53,7 @@
5253
class ModelRequest:
5354
def __init__(self, metrics, output_type, source="rapl-sysfs", node_type=-1, weight=False, trainer_name="", filter="", pipeline_name="", spec=None):
5455
# target source of power metric to be predicted (e.g., rapl-sysfs, acpi)
55-
self.source = source
56+
self.source = convert_enery_source(source)
5657
# type of node to select a model learned from similar nodes (default: -1, applied universal model learned by all node_type (TODO))
5758
self.node_type = node_type
5859
# list of available resource usage metrics to find applicable models (using a valid feature group that can be obtained from the list)
@@ -197,6 +198,7 @@ def get_available_models():
197198
fg = request.args.get(ModelListParam.FeatureGroup.value)
198199
ot = request.args.get(ModelListParam.OutputType.value)
199200
energy_source = request.args.get(ModelListParam.EnergySource.value)
201+
energy_source = convert_enery_source(energy_source)
200202
node_type = request.args.get(ModelListParam.NodeType.value)
201203
filter = request.args.get(ModelListParam.Filter.value)
202204

src/kepler_model/util/train_types.py

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -234,6 +234,11 @@ def is_weight_output(output_type):
234234
return True
235235
return False
236236

237+
def convert_enery_source(energy_source: str) -> str:
238+
# TODO: need revisit if get more than one rapl energy source
239+
if energy_source is None or "rapl" in energy_source:
240+
return "rapl-sysfs"
241+
return energy_source
237242

238243
if __name__ == "__main__":
239244
for g, g_features in FeatureGroups.items():

0 commit comments

Comments
 (0)