Skip to content

Commit 2263f0b

Browse files
committed
ci: remove EOF from the config change message
This commit fixes the issue where the config change message was ending with an EOF. It also updates the rest of the workflows to include `yamllint disable rule` for `truly` values Signed-off-by: vprashar2929 <[email protected]>
1 parent 0bd4dc2 commit 2263f0b

File tree

6 files changed

+14
-15
lines changed

6 files changed

+14
-15
lines changed

.github/workflows/assign-labels.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
name: Assign Labels
22

3-
on:
3+
on: # yamllint disable-line rule:truthy
44
pull_request_target:
55

66
jobs:

.github/workflows/check-x-crypto-deps.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
name: Check x/crypto
22

3-
on:
3+
on: # yamllint disable-line rule:truthy
44
pull_request:
55

66
jobs:

.github/workflows/config-change.yaml

Lines changed: 9 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
name: Check Config Changes
22

3-
on: #yamllint disable-line rule:truthy
3+
on: # yamllint disable-line rule:truthy
44
pull_request:
55

66
jobs:
@@ -38,14 +38,14 @@ jobs:
3838
generate-comment-message:
3939
needs: check-changes
4040
if: >-
41-
needs.check-changes.outputs.changes == 'true' &&
42-
(
43-
needs.check-changes.outputs.doc_changes != 'true' ||
44-
needs.check-changes.outputs.compose_changes != 'true' ||
45-
needs.check-changes.outputs.hack_changes != 'true' ||
46-
needs.check-changes.outputs.manifest_changes != 'true' ||
47-
needs.check-changes.outputs.helm_changes != 'true'
48-
)
41+
needs.check-changes.outputs.changes == 'true' &&
42+
(
43+
needs.check-changes.outputs.doc_changes != 'true' ||
44+
needs.check-changes.outputs.compose_changes != 'true' ||
45+
needs.check-changes.outputs.hack_changes != 'true' ||
46+
needs.check-changes.outputs.manifest_changes != 'true' ||
47+
needs.check-changes.outputs.helm_changes != 'true'
48+
)
4949
runs-on: ubuntu-latest
5050
steps:
5151
- name: Generate comment message
@@ -68,7 +68,6 @@ jobs:
6868
if [[ "${{ needs.check-changes.outputs.helm_changes }}" != "true" ]]; then
6969
echo "- manifests/helm/kepler/values.yaml"
7070
fi
71-
echo "EOF"
7271
} > /tmp/message-${{ github.event.pull_request.number }}.txt
7372
7473
# NOTE: Uploading the message as an artifact so that PR Comment workflow can use it to

.github/workflows/pr-comment.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
# Triggered when specified workflows complete successfully
33
name: PR Comment
44

5-
on:
5+
on: # yamllint disable-line rule:truthy
66
workflow_run:
77
# NOTE: Add any workflow that needs to comment on PRs to this list
88
workflows:

.github/workflows/release.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
name: Release
22

3-
on: #yamllint disable-line rule:truthy
3+
on: # yamllint disable-line rule:truthy
44
push:
55
tags:
66
- v[0-9]+.[0-9]+.[0-9]+

.github/workflows/test-and-codecov.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
name: Test and Upload Coverage
22

3-
on:
3+
on: # yamllint disable-line rule:truthy
44
workflow_call:
55
secrets:
66
CODECOV_TOKEN:

0 commit comments

Comments
 (0)