Merge pull request #2263 from sthaha/feat-redfish-impl

feat(redfish):  add redfish support

Author: Sunil Thaha

cmd/kepler/main.go

@@ -11,13 +11,15 @@ import (
 	"syscall"
 
 	"github.com/alecthomas/kingpin/v2"
+
 	"github.com/sustainable-computing-io/kepler/config"
 	"github.com/sustainable-computing-io/kepler/internal/device"
 	"github.com/sustainable-computing-io/kepler/internal/exporter/prometheus"
 	"github.com/sustainable-computing-io/kepler/internal/exporter/stdout"
 	"github.com/sustainable-computing-io/kepler/internal/k8s/pod"
 	"github.com/sustainable-computing-io/kepler/internal/logger"
 	"github.com/sustainable-computing-io/kepler/internal/monitor"
+	"github.com/sustainable-computing-io/kepler/internal/platform/redfish"
 	"github.com/sustainable-computing-io/kepler/internal/resource"
 	"github.com/sustainable-computing-io/kepler/internal/server"
 	"github.com/sustainable-computing-io/kepler/internal/service"
@@ -157,6 +159,8 @@ func createServices(logger *slog.Logger, cfg *config.Config) ([]service.Service,
 		monitor.WithMinTerminatedEnergyThreshold(monitor.Energy(cfg.Monitor.MinTerminatedEnergyThreshold)*monitor.Joule),
 	)
 
+	// Create Redfish service if enabled (experimental feature)
+
 	apiServer := server.NewAPIServer(
 		server.WithLogger(logger),
 		server.WithListenAddress(cfg.Web.ListenAddresses),
@@ -170,43 +174,69 @@ func createServices(logger *slog.Logger, cfg *config.Config) ([]service.Service,
 		pm,
 	)
 
+	// Add Redfish service if enabled
+	var redfishService *redfish.Service
+	if cfg.IsFeatureEnabled(config.ExperimentalRedfishFeature) {
+		rs, err := createRedfishService(logger, cfg)
+		if err != nil {
+			return nil, fmt.Errorf("failed to create Redfish service: %w", err)
+		}
+		services = append(services, rs)
+		redfishService = rs
+	}
+
 	// Add Prometheus exporter if enabled
-	if *cfg.Exporter.Prometheus.Enabled {
-		promExporter, err := createPrometheusExporter(logger, cfg, apiServer, pm)
+	if cfg.IsFeatureEnabled(config.PrometheusFeature) {
+		promExporter, err := createPrometheusExporter(logger, cfg, apiServer, pm, redfishService)
 		if err != nil {
 			return nil, fmt.Errorf("failed to create Prometheus exporter: %w", err)
 		}
 		services = append(services, promExporter)
 	}
 
 	// Add pprof if enabled
-	if *cfg.Debug.Pprof.Enabled {
+	if cfg.IsFeatureEnabled(config.PprofFeature) {
 		pprof := server.NewPprof(apiServer)
 		services = append(services, pprof)
 	}
 
 	// Add stdout exporter if enabled
-	if *cfg.Exporter.Stdout.Enabled {
+	if cfg.IsFeatureEnabled(config.StdoutFeature) {
 		stdoutExporter := stdout.NewExporter(pm, stdout.WithLogger(logger))
 		services = append(services, stdoutExporter)
 	}
 
 	return services, nil
 }
 
-func createPrometheusExporter(logger *slog.Logger, cfg *config.Config, apiServer *server.APIServer, pm *monitor.PowerMonitor) (*prometheus.Exporter, error) {
+func createRedfishService(logger *slog.Logger, cfg *config.Config) (*redfish.Service, error) {
+	return redfish.NewService(cfg.Experimental.Platform.Redfish, logger, redfish.WithStaleness(cfg.Monitor.Staleness))
+}
+
+func createPrometheusExporter(
+	logger *slog.Logger, cfg *config.Config,
+	apiServer *server.APIServer, pm *monitor.PowerMonitor,
+	rs *redfish.Service,
+) (*prometheus.Exporter, error) {
 	logger.Debug("Creating Prometheus exporter")
 
 	// Use metrics level from configuration (already parsed)
 	metricsLevel := cfg.Exporter.Prometheus.MetricsLevel
 
-	collectors, err := prometheus.CreateCollectors(
-		pm,
+	var collectorOpts []prometheus.OptionFn
+	collectorOpts = append(collectorOpts,
 		prometheus.WithLogger(logger),
 		prometheus.WithProcFSPath(cfg.Host.ProcFS),
 		prometheus.WithNodeName(cfg.Kube.Node),
 		prometheus.WithMetricsLevel(metricsLevel),
 	)
+
+	// Add platform data provider if Redfish service is available
+	if rs != nil {
+		collectorOpts = append(collectorOpts, prometheus.WithPlatformDataProvider(rs))
+	}
+
+	collectors, err := prometheus.CreateCollectors(pm, collectorOpts...)
 	if err != nil {
 		return nil, fmt.Errorf("failed to create Prometheus collectors: %w", err)
 	}

compose/default/kepler/etc/kepler/config.yaml

@@ -70,3 +70,13 @@ dev:
   fake-cpu-meter:
     enabled: false
     zones: [] # zones to be enabled, empty enables all default zones
+
+# EXPERIMENTAL FEATURES - These features are experimental and may be unstable
+# and are disabled by default
+experimental:
+  platform:
+    redfish:
+      enabled: false # Enable experimental Redfish BMC power monitoring
+      configFile: /etc/kepler/redfish.yaml # Path to Redfish BMC configuration file
+      nodeName: "" # Node name to use (overrides Kubernetes node name and hostname fallback)
+      httpTimeout: 5s # HTTP client timeout for BMC requests (default: 5s)

compose/dev/kepler-dev/etc/kepler/config.yaml

@@ -70,3 +70,13 @@ dev:
   fake-cpu-meter:
     enabled: false
     zones: [] # zones to be enabled, empty enables all default zones
+
+# EXPERIMENTAL FEATURES - These features are experimental and may be unstable
+# and are disabled by default
+experimental:
+  platform:
+    redfish:
+      enabled: false # Enable experimental Redfish BMC power monitoring
+      configFile: /etc/kepler/redfish.yaml # Path to Redfish BMC configuration file
+      nodeName: "" # Node name to use (overrides Kubernetes node name and hostname fallback)
+      httpTimeout: 5s # HTTP client timeout for BMC requests (default: 5s)