Skip to content

Commit d7015bf

Browse files
authored
ci: specify version when running make targets (#2243)
This commit fixes the issue where the release workflow failed due to referencing a non-existent version. Now when building and pushing images we specify the version when running make targets. Signed-off-by: Vibhu Prashar <[email protected]>
1 parent 3f467c6 commit d7015bf

File tree

1 file changed

+6
-6
lines changed

1 file changed

+6
-6
lines changed

.github/workflows/release.yaml

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -46,18 +46,18 @@ jobs:
4646
shell: bash
4747
run: make deps
4848

49-
- name: Build Image
50-
shell: bash
51-
run: |
52-
make image
53-
5449
- name: Extract version
5550
shell: bash
5651
id: version
5752
run: |
5853
TAG_NAME=${{ github.ref_name }}
5954
echo "version=$TAG_NAME" >> "$GITHUB_OUTPUT"
6055
56+
- name: Build Image
57+
shell: bash
58+
run: |
59+
make image VERSION=${{ steps.version.outputs.version }}
60+
6161
- name: Update Helm Chart Version
6262
shell: bash
6363
run: |
@@ -107,4 +107,4 @@ jobs:
107107
- name: Push Image
108108
shell: bash
109109
run: |
110-
make push
110+
make push VERSION=${{ steps.version.outputs.version }}

0 commit comments

Comments
 (0)