Updating cacheSize to be alligned to MaxQuerySampleCount

Author: sv-splunk

receiver/oracledbreceiver/config.go

@@ -26,13 +26,11 @@ var (
 	errEmptyUsername       = errors.New("username must be set")
 	errMaxQuerySampleCount = errors.New("`max_query_sample_count` must be between 1 and 10000")
 	errTopQueryCount       = errors.New("`top_query_count` must be between 1 and 200 and less than or equal to `max_query_sample_count`")
-	errQueryCacheSize      = errors.New("`query_cache_size` must be strictly positive")
 )
 
 type TopQueryCollection struct {
 	MaxQuerySampleCount uint `mapstructure:"max_query_sample_count"`
 	TopQueryCount       uint `mapstructure:"top_query_count"`
-	QueryCacheSize      int  `mapstructure:"query_cache_size"`
 }
 
 type Config struct {
@@ -98,8 +96,5 @@ func (c Config) Validate() error {
 	if c.TopQueryCount < 1 || c.TopQueryCount > 200 || c.TopQueryCount > c.MaxQuerySampleCount {
 		allErrs = multierr.Append(allErrs, errTopQueryCount)
 	}
-	if c.QueryCacheSize <= 0 {
-		allErrs = multierr.Append(allErrs, errQueryCacheSize)
-	}
 	return allErrs
 }

receiver/oracledbreceiver/factory.go

@@ -47,7 +47,6 @@ func createDefaultConfig() component.Config {
 		TopQueryCollection: TopQueryCollection{
 			MaxQuerySampleCount: 1000,
 			TopQueryCount:       200,
-			QueryCacheSize:      5000,
 		},
 	}
 }
@@ -111,8 +110,9 @@ func createLogsReceiverFunc(sqlOpenerFunc sqlOpenerFunc, clientProviderFunc clie
 			return nil, hostNameErr
 		}
 
-		cacheSize := sqlCfg.QueryCacheSize
-		metricCache, err := lru.New[string, map[string]int64](cacheSize)
+		// cacheSize is kept at 2 times MaxQuerySampleCount to keep queries of adjacent collections available for delta calculation.
+		cacheSize := sqlCfg.MaxQuerySampleCount * 2
+		metricCache, err := lru.New[string, map[string]int64](int(cacheSize))
 		if err != nil {
 			settings.Logger.Error("Failed to create LRU cache, skipping the current scraper", zap.Error(err))
 			return nil, err

receiver/oracledbreceiver/testdata/config.yaml

@@ -9,7 +9,6 @@ oracledb:
   top_query_collection:
     max_query_sample_count: 222
     top_query_count: 200
-    query_cache_size: 1000
   metrics:
     oracledb.exchange_deadlocks:
       enabled: false